clarkwinkelmann The actions seem to happen when I edit or like or upvote another person's post.

The auto moderator seems to flag this up even on admin posts, so I can post something fine and then if I upvote someone else post it will send their post for approval although it's already been approved.

    JAC but what is "auto moderator"? That word doesn't exist in Flarum core or this extension.

    I don't know what that is, I guessed it was something to do with the first approval extension? Is it not? 😛

    Unless it is to do with other permissions.

      2 months later
      18 days later

      Hi, I noticed what I think is maybe a bug with this plugin. I enabled the plugin and set it first_discussion_approval_count to 1 and first_discussion_approval_count to 0.

      When a new user joins and tries to make a discussion they an error that says "The requested resource was not found.". However the discussion is still created (admins get a notification about it) but it's not accessible to anyone.

        User18 does the issue go away when you disable this extension?

        Maybe you have another extension that prevents users from seeing their own discussions when they are under approval?

        Can you share your php flarum info output?

          clarkwinkelmann yes. it doesn't happen when I disable the extension

          Flarum core 0.1.0-beta.15
          PHP version: 7.4.3
          Loaded extensions: Core, date, libxml, openssl, pcre, zlib, filter, hash, pcntl, Reflection, SPL, session, standard, sodium, mysqlnd, PDO, xml, apcu, calendar, ctype, curl, dom, mbstring, FFI, fileinfo, ftp, gd, gettext, iconv, json, exif, mysqli, pdo_mysql, apc, posix, readline, shmop, SimpleXML, sockets, sysvmsg, sysvsem, sysvshm, tokenizer, xmlreader, xmlwriter, xsl, Phar, Zend OPcache
          +-----------------------------+------------------+--------+
          | Flarum Extensions | | |
          +-----------------------------+------------------+--------+
          | ID | Version | Commit |
          +-----------------------------+------------------+--------+
          | flarum-lang-english | v0.1.0-beta.15 | |
          | flarum-lock | v0.1.0-beta.15 | |
          | flarum-likes | v0.1.0-beta.15 | |
          | flarum-flags | v0.1.0-beta.15 | |
          | flarum-mentions | v0.1.0-beta.15 | |
          | flarum-tags | v0.1.0-beta.15 | |
          | flarum-markdown | v0.1.0-beta.15 | |
          | flarum-suspend | v0.1.0-beta.15 | |
          | flarum-subscriptions | v0.1.0-beta.15 | |
          | flarum-sticky | v0.1.0-beta.15.1 | |
          | flarum-statistics | v0.1.0-beta.15 | |
          | flarum-bbcode | v0.1.0-beta.15 | |
          | flarum-nicknames | v0.1.0-beta.15 | |
          | fof-best-answer | 0.3.6 | |
          | fof-byobu | 0.6.1 | |
          | fof-drafts | 0.3.2 | |
          | fof-polls | 0.3.2 | |
          | fof-impersonate | 0.7.0 | |
          | fof-merge-discussions | 0.5.1 | |
          | fof-moderator-notes | 0.4.4 | |
          | fof-split | 0.6.0 | |
          | fof-links | 0.5.4 | |
          | fof-socialprofile | 0.2.3 | |
          | fof-upload | 0.13.1 | |
          | fof-user-bio | 0.4.2 | |
          | fof-user-directory | 0.5.3 | |
          | fof-username-request | 0.4.2 | |
          | fof-formatting | 0.3.1 | |
          | zerosonesfun-bbcode-audio | 2.0.3 | |
          | matteocontrini-imgur-upload | v3.6.0 | |
          +-----------------------------+------------------+--------+

          I have version 0.1.4 of first-post-approval. hmm maybe I should try updating to beta 16 first.

            User18 0.1.4 is the latest version and is compatible with both Flarum beta 15 and 16.

            I'm not able to reproduce using your instructions (tested on beta 16 only). A freshly enabled user can create discussions and see them fine on my test forum.

            There's something odd with your output. It seems like you don't have Flarum Approval enabled. You should not have been able to enable First Post Approval without first enabling Approval, and likewise it shouldn't be possible to disable Approval while First Post Approval is enabled. If Approval is indeed disabled, then it's certainly why it doesn't work. Try enabling it.

            If you are able to disable Approval while First Post Approval is enabled, then there must be a bug in Flarum because Flarum should prevent you from doing it.

            Sorry I should have mentioned I disabled Approval and First Post Approval after I couldn't fix that problem. Like you said I Approval needs to be enabled for First Post Approval to be enabled. I will try and investigate a bit more and see if I can figure out what's happening.

              User18 the most likely extension in that list that could cause trouble would be Byobu I'd say (because it alters which discussions are visible to who). I've never tested the two extensions together. You could try disabling Byobu temporarily to see if anything changes. And you can also try the same with other extensions to see if anything changes.

                clarkwinkelmann Everything seems to work now (even with Byobu enabled). Not sure what changed. Thanks for your help!

                I wouldn't mind contributing some money to helping you make it compatible with Byobu. Maybe I should PM you about that. I think this should be a fof extension because it's so invaluable to fighting spam and way simpler to use than captcha.

                  User18 sometimes it's the order in which extensions were enabled that can cause issues.

                  If everything's fine now then the two extensions are probably working fine together. Unless we can find a clear error when the two are used together, then there's probably nothing to change.

                  You can contact me via email or Discord DM if you want a quote for a change or additional features. You can also donate through the Paypal link in the extension README or through GitHub sponsors if you would like.

                  FriendsOfFlarum already has many extension to manage, and historically they have focused on extensions that no longer had any maintainer. This extension is also quite simple so it doesn't require too much work to maintain. Once we reach Flarum stable an extension like this one should continue to work for a very long time.

                  13 days later

                  This is such a great plugin.
                  I have it set to only require approval on the first discussion, with a sql query that runs periodically to check for metrics (like if others liked their post), and if it does it sets their first_discussion_approval_count to 1.
                  This way the majority of my real users never require manual approval.

                  I was having a big spam problem and had moderators getting upset. I think the people posting spam get paid for simply having a spam discussion successfully be visible, so even taking them down and banning quickly didn't do much.
                  This completely disrupted that whole system. After a few weeks of a post never getting through, I think they gave up. 👍

                    Kulga After a few weeks of a post never getting through, I think they gave up.

                    That's my observation too.

                    Kulga interesting implementation, something like this should be an extension 😃

                    7 days later

                    Any updates on if/when this will be updated for beta 16? I am down to my final couple of extensions before I can update 😃