FriendsOfFlarum OAuth

Communitybuilder

tankerkiller125 Do you know if Google OAuth will be integrated in FoF Oauth ?
I would like to know if it's a choice or if it's planned in the future ^^
Thank you very much

tankerkiller125

Communitybuilder Not on the FoF team so I can't say, with that said if someone made a good PR I'm sure the FoF team would look into it. The big problem with Google though is that they require their logo to be shown in color to approve mass deployment of things, so it's not quite as simple as choosing the Font Awesome icon to display.

Communitybuilder

tankerkiller125
I understand better. This one from Beta 13 was really nice https://discuss.flarum.org/d/18250-google-login @Staszek , I wish someone make a PR to merge with it ^^
But I understand there's an issue of being compliant with their design charter...

Thank you for your answer.

Staszek

Communitybuilder Thanks for mentioning me, I didn't know about this plugin. Soon I will try to create PR with Google support. It certainly should be supported, as Google is second biggest player in Oauth after Facebook. Besides these two, the rest has less than 10% of share: https://www.webmarketingpros.com/90-of-website-social-logins-are-with-facebook-or-google/

Communitybuilder

Staszek So cool to hear ! Thank you 😃

lukeeexd

I get this after setting it all up

datitisev

lukeeexd You need to set the redirect URI of the Discord application to what the modal tells you - see screenshot below

lukeeexd

datitisev Maybe I'm blind but I cannot see an option for callback URL anywhere

datitisev

lukeeexd If you click the OAuth tab you can add as many redirects as you need. See screenshot below.

screenshot

EvilExecutor

I think found a bug (or maybe not). If a avatar is not set a person cannot login via discord. Here is what the debug looks like.


POST https://mydomainname/register

Intervention\Image\Exception\NotReadableException: Unable to init from given url (https://cdn.discordapp.com/avatars/0.png). in file /home/pxpocvvj/forum/vendor/intervention/image/src/Intervention/Image/AbstractDecoder.php on line 84
Stack trace:
  1. Intervention\Image\Exception\NotReadableException->() /home/pxpocvvj/forum/vendor/intervention/image/src/Intervention/Image/AbstractDecoder.php:84
  2. Intervention\Image\AbstractDecoder->initFromUrl() /home/pxpocvvj/forum/vendor/intervention/image/src/Intervention/Image/AbstractDecoder.php:330
  3. Intervention\Image\AbstractDecoder->init() /home/pxpocvvj/forum/vendor/intervention/image/src/Intervention/Image/AbstractDriver.php:66
  4. Intervention\Image\AbstractDriver->init() /home/pxpocvvj/forum/vendor/intervention/image/src/Intervention/Image/ImageManager.php:54
  5. Intervention\Image\ImageManager->make() /home/pxpocvvj/forum/vendor/flarum/core/src/User/Command/RegisterUserHandler.php:139
  6. Flarum\User\Command\RegisterUserHandler->uploadAvatarFromUrl() /home/pxpocvvj/forum/vendor/flarum/core/src/User/Command/RegisterUserHandler.php:121
  7. Flarum\User\Command\RegisterUserHandler->applyToken() /home/pxpocvvj/forum/vendor/flarum/core/src/User/Command/RegisterUserHandler.php:93
  8. Flarum\User\Command\RegisterUserHandler->handle() /home/pxpocvvj/forum/vendor/illuminate/bus/Dispatcher.php:90
  9. Illuminate\Bus\Dispatcher->Illuminate\Bus\{closure}() /home/pxpocvvj/forum/vendor/illuminate/pipeline/Pipeline.php:130
 10. Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}() /home/pxpocvvj/forum/vendor/illuminate/pipeline/Pipeline.php:105
 11. Illuminate\Pipeline\Pipeline->then() /home/pxpocvvj/forum/vendor/illuminate/bus/Dispatcher.php:98
 12. Illuminate\Bus\Dispatcher->dispatchNow() /home/pxpocvvj/forum/vendor/illuminate/bus/Dispatcher.php:76
 13. Illuminate\Bus\Dispatcher->dispatch() /home/pxpocvvj/forum/vendor/flarum/core/src/Api/Controller/CreateUserController.php:45
 14. Flarum\Api\Controller\CreateUserController->data() /home/pxpocvvj/forum/vendor/flarum/core/src/Api/Controller/AbstractSerializeController.php:96
 15. Flarum\Api\Controller\AbstractSerializeController->handle() /home/pxpocvvj/forum/vendor/flarum/core/src/Api/Controller/AbstractCreateController.php:22
 16. Flarum\Api\Controller\AbstractCreateController->handle() /home/pxpocvvj/forum/vendor/flarum/core/src/Api/Client.php:72
 17. Flarum\Api\Client->send() /home/pxpocvvj/forum/vendor/flarum/core/src/Forum/Controller/RegisterController.php:58
 18. Flarum\Forum\Controller\RegisterController->handle() /home/pxpocvvj/forum/vendor/flarum/core/src/Http/RouteHandlerFactory.php:38
 19. Flarum\Http\RouteHandlerFactory->Flarum\Http\{closure}() /home/pxpocvvj/forum/vendor/flarum/core/src/Http/Middleware/DispatchRoute.php:65
 20. Flarum\Http\Middleware\DispatchRoute->process() /home/pxpocvvj/forum/vendor/laminas/laminas-stratigility/src/Next.php:61
 21. Laminas\Stratigility\Next->handle() /home/pxpocvvj/forum/vendor/fof/ban-ips/src/Middleware/RegisterMiddleware.php:93
 22. FoF\BanIPs\Middleware\RegisterMiddleware->process() /home/pxpocvvj/forum/vendor/laminas/laminas-stratigility/src/Next.php:61
 23. Laminas\Stratigility\Next->handle() /home/pxpocvvj/forum/vendor/fof/oauth/src/Middleware/ErrorHandler.php:46
 24. FoF\OAuth\Middleware\ErrorHandler->process() /home/pxpocvvj/forum/vendor/laminas/laminas-stratigility/src/Next.php:61
 25. Laminas\Stratigility\Next->handle() /home/pxpocvvj/forum/vendor/kilowhat/flarum-ext-audit-free/src/Middlewares/SetLoggerActor.php:28
 26. Kilowhat\Audit\Middlewares\SetLoggerActor->process() /home/pxpocvvj/forum/vendor/laminas/laminas-stratigility/src/Next.php:61
 27. Laminas\Stratigility\Next->handle() /home/pxpocvvj/forum/vendor/flarum/core/src/Http/Middleware/ShareErrorsFromSession.php:57
 28. Flarum\Http\Middleware\ShareErrorsFromSession->process() /home/pxpocvvj/forum/vendor/laminas/laminas-stratigility/src/Next.php:61
 29. Laminas\Stratigility\Next->handle() /home/pxpocvvj/forum/vendor/flarum/core/src/Http/Middleware/SetLocale.php:50
 30. Flarum\Http\Middleware\SetLocale->process() /home/pxpocvvj/forum/vendor/laminas/laminas-stratigility/src/Next.php:61
 31. Laminas\Stratigility\Next->handle() /home/pxpocvvj/forum/vendor/flarum/core/src/Http/Middleware/CheckCsrfToken.php:45
 32. Flarum\Http\Middleware\CheckCsrfToken->process() /home/pxpocvvj/forum/vendor/laminas/laminas-stratigility/src/Next.php:61
 33. Laminas\Stratigility\Next->handle() /home/pxpocvvj/forum/vendor/flarum/core/src/Http/Middleware/AuthenticateWithSession.php:32
 34. Flarum\Http\Middleware\AuthenticateWithSession->process() /home/pxpocvvj/forum/vendor/laminas/laminas-stratigility/src/Next.php:61
 35. Laminas\Stratigility\Next->handle() /home/pxpocvvj/forum/vendor/flarum/core/src/Http/Middleware/RememberFromCookie.php:51
 36. Flarum\Http\Middleware\RememberFromCookie->process() /home/pxpocvvj/forum/vendor/laminas/laminas-stratigility/src/Next.php:61
 37. Laminas\Stratigility\Next->handle() /home/pxpocvvj/forum/vendor/flarum/core/src/Http/Middleware/StartSession.php:61
 38. Flarum\Http\Middleware\StartSession->process() /home/pxpocvvj/forum/vendor/laminas/laminas-stratigility/src/Next.php:61
 39. Laminas\Stratigility\Next->handle() /home/pxpocvvj/forum/vendor/flarum/core/src/Http/Middleware/CollectGarbage.php:46
 40. Flarum\Http\Middleware\CollectGarbage->process() /home/pxpocvvj/forum/vendor/laminas/laminas-stratigility/src/Next.php:61
 41. Laminas\Stratigility\Next->handle() /home/pxpocvvj/forum/vendor/flarum/core/src/Http/Middleware/ParseJsonBody.php:28
 42. Flarum\Http\Middleware\ParseJsonBody->process() /home/pxpocvvj/forum/vendor/laminas/laminas-stratigility/src/Next.php:61
 43. Laminas\Stratigility\Next->handle() /home/pxpocvvj/forum/vendor/flarum/core/src/Http/Middleware/HandleErrors.php:57
 44. Flarum\Http\Middleware\HandleErrors->process() /home/pxpocvvj/forum/vendor/laminas/laminas-stratigility/src/Next.php:61
 45. Laminas\Stratigility\Next->handle() /home/pxpocvvj/forum/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php:84
 46. Laminas\Stratigility\MiddlewarePipe->process() /home/pxpocvvj/forum/vendor/middlewares/request-handler/src/RequestHandler.php:84
 47. Middlewares\RequestHandler->process() /home/pxpocvvj/forum/vendor/laminas/laminas-stratigility/src/Next.php:61
 48. Laminas\Stratigility\Next->handle() /home/pxpocvvj/forum/vendor/middlewares/base-path-router/src/BasePathRouter.php:97
 49. Middlewares\BasePathRouter->process() /home/pxpocvvj/forum/vendor/laminas/laminas-stratigility/src/Next.php:61
 50. Laminas\Stratigility\Next->handle() /home/pxpocvvj/forum/vendor/laminas/laminas-stratigility/src/Middleware/OriginalMessages.php:42
 51. Laminas\Stratigility\Middleware\OriginalMessages->process() /home/pxpocvvj/forum/vendor/laminas/laminas-stratigility/src/Next.php:61
 52. Laminas\Stratigility\Next->handle() /home/pxpocvvj/forum/vendor/middlewares/base-path/src/BasePath.php:53
 53. Middlewares\BasePath->process() /home/pxpocvvj/forum/vendor/laminas/laminas-stratigility/src/Next.php:61
 54. Laminas\Stratigility\Next->handle() /home/pxpocvvj/forum/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php:84
 55. Laminas\Stratigility\MiddlewarePipe->process() /home/pxpocvvj/forum/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php:73
 56. Laminas\Stratigility\MiddlewarePipe->handle() /home/pxpocvvj/forum/vendor/laminas/laminas-httphandlerrunner/src/RequestHandlerRunner.php:96
 57. Laminas\HttpHandlerRunner\RequestHandlerRunner->run() /home/pxpocvvj/forum/vendor/flarum/core/src/Http/Server.php:42
 58. Flarum\Http\Server->listen() /home/pxpocvvj/forum/public/index.php:26

I set a profile pic to the same account and logged in, then it worked fine.

lukeeexd

datitisev Yep already had that

datitisev

lukeeexd You misspelled forum 🙂

lukeeexd

datitisev I had it spelt correctly for my inital post when it didnt work, Only before my screenshot above was it spelt incorrectly after I added it back after removing it. However it's working now, thanks

TOWUK_ru

maybe add [VK . com] service? its most popular social web like facebook and twitter...?

Marty

How about adding support for generic OAuth providers? We have a keycloak instance running for our community and want to use that. There is an extension for that, but it's not actively maintained for the last release is from april and throws errors when installed https://github.com/spookygames/flarum-ext-auth-keycloak

clarkwinkelmann

Marty maybe you are able to use the Passport extension? https://discuss.flarum.org/d/5203-fof-passport-the-laravel-passport-oauth-extension

Maybe the two extensions will be merged at some point, but for now Passport remains a separate extension.

kris88

@datitisev @Staszek
+1 to the Google Login requirement. All that most people need is Facebook and Google login. In addition, this fof/oauth extension and saleksin/flarum-auth-google cannot be installed together - there's a conflict that shows up - the forum doesn't work as soon as the second extension is installed.

Please... Please... and with some instructions on setting up the google app ID and secret as it can be a little overwhelming there.

EvilExecutor

@kris88 as a temporary solution you can use this extension with fof/oauth https://discuss.flarum.org/d/25381-legit-google-auth-extends-fofoauth

kris88

EvilExecutor I have installed this extension and enabled it from extension section but I don;t see an option anywhere to open settings. Even an icon / button for login/sign up with Google didn't show up! any thoughts?

luuhai48

I did submit a pull request for google oauth to FoF/oauth, but no response, it's been 2 weeks 🙄

tankerkiller125

luuhai48 A lot of the FoF team is Flarum team members, and a ton of us have been very busy, both with regular life as well as working on the next release of Flarum.

luuhai48

kris88
Its right here, dude
luuhai48 oauth google

« Previous Page Next Page »