FriendsOfFlarum OAuth

010101

Alright, I know I've replied a lot. I tried deleting above posts but you all must have the delete post permission turned off or soft deleting posts is broken right now. I'll try to make this my last reply. I just discovered one other thing. The reason I feel like sometimes this works and sometimes it doesn't comes down to the browser. If I try from my iPhone it doesn't work. If I try from Safari on my MacBook, it doesn't work. But, if I try from Chrome from my MacBook, it works. I've tried emptying cache/cookies. I just don't get why it acts buggy for me in certain browsers, and possibly only my installation of Flarum if I'm the only one still posting here about it.

I would concede and say, it's me. That I have the settings wrong. But, that can't be if it works in Chrome. Why is it working in Chrome on MacBook, but nowhere else for me? These kinds of bugs eat at me. It's the weirdest bug I've dealt with during my time with Flarum.

Well, for now, I'm using CSS hacks to hide social log in if Safari, or if iOS. First chunk targets Safari, second chunk targets iOS.

/* Hide because Apple makes me mad */

@media not all and (min-resolution:.001dpcm) { 
  @supports (-webkit-appearance: none) {
.LogInButtons {
display: none;
}
}}

@supports (-webkit-touch-callout: none) {
.LogInButtons {
display: none;
}
}

/* End hide for apple */

010101

I can't stop. Every time I tell myself I'm giving up, the fact that I can't figure this out eats at me. Here's my log. See anything interesting?

[2021-12-31 01:12:37] flarum.ERROR: TypeError: League\OAuth1\Client\Server\Server::getTokenCredentials(): Argument #1 ($temporaryCredentials) must be of type League\OAuth1\Client\Credentials\TemporaryCredentials, bool given, called in /mysite/vendor/fof/oauth/src/Controllers/TwitterAuthController.php on line 98 and defined in /mysite/vendor/league/oauth1-client/src/Server/Server.php:163
Stack trace:
#0 /mysite/vendor/fof/oauth/src/Controllers/TwitterAuthController.php(98): League\OAuth1\Client\Server\Server->getTokenCredentials(false, 'La9eoAAAAAABGE6...', 'Ss4juqjoP8q9MHd...')
#1 /mysite/vendor/fof/oauth/src/Controllers/TwitterAuthController.php(60): FoF\OAuth\Controllers\TwitterAuthController->work(Object(Laminas\Diactoros\ServerRequest))
#2 /mysite/vendor/flarum/core/src/Http/RouteHandlerFactory.php(41): FoF\OAuth\Controllers\TwitterAuthController->handle(Object(Laminas\Diactoros\ServerRequest))
#3 /mysite/vendor/flarum/core/src/Http/Middleware/ExecuteRoute.php(27): Flarum\Http\RouteHandlerFactory->Flarum\Http\{closure}(Object(Laminas\Diactoros\ServerRequest), Array)
#4 /mysite/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\ExecuteRoute->process(Object(Laminas\Diactoros\ServerRequest), Object(Closure))
#5 /mysite/vendor/fof/masquerade/src/Middleware/DemandProfileCompletion.php(67): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#6 /mysite/vendor/laminas/laminas-stratigility/src/Next.php(51): FoF\Masquerade\Middleware\DemandProfileCompletion->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#7 /mysite/vendor/fof/oauth/src/Middleware/ErrorHandler.php(50): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#8 /mysite/vendor/laminas/laminas-stratigility/src/Next.php(51): FoF\OAuth\Middleware\ErrorHandler->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#9 /mysite/vendor/fof/stopforumspam/src/Middleware/RegisterMiddleware.php(77): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#10 /mysite/vendor/laminas/laminas-stratigility/src/Next.php(51): FoF\StopForumSpam\Middleware\RegisterMiddleware->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#11 /mysite/vendor/fof/terms/src/Middlewares/RegisterMiddleware.php(59): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#12 /mysite/vendor/laminas/laminas-stratigility/src/Next.php(51): FoF\Terms\Middlewares\RegisterMiddleware->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#13 /mysite/vendor/flarum/core/src/Http/Middleware/ContentTypeOptionsHeader.php(21): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#14 /mysite/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\ContentTypeOptionsHeader->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#15 /mysite/vendor/flarum/core/src/Http/Middleware/ReferrerPolicyHeader.php(30): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#16 /mysite/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\ReferrerPolicyHeader->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#17 /mysite/vendor/flarum/core/src/Http/Middleware/FlarumPromotionHeader.php(30): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#18 /mysite/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\FlarumPromotionHeader->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#19 /mysite/vendor/flarum/core/src/Http/Middleware/ShareErrorsFromSession.php(57): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#20 /mysite/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\ShareErrorsFromSession->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#21 /mysite/vendor/flarum/core/src/Http/Middleware/CheckCsrfToken.php(36): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#22 /mysite/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\CheckCsrfToken->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#23 /mysite/vendor/flarum/core/src/Http/Middleware/ResolveRoute.php(67): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#24 /mysite/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\ResolveRoute->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#25 /mysite/vendor/flarum/core/src/Http/Middleware/SetLocale.php(51): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#26 /mysite/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\SetLocale->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#27 /mysite/vendor/flarum/core/src/Http/Middleware/AuthenticateWithSession.php(31): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#28 /mysite/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\AuthenticateWithSession->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#29 /mysite/vendor/flarum/core/src/Http/Middleware/RememberFromCookie.php(52): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#30 /mysite/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\RememberFromCookie->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#31 /mysite/vendor/flarum/core/src/Http/Middleware/StartSession.php(61): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#32 /mysite/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\StartSession->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#33 /mysite/vendor/flarum/core/src/Http/Middleware/CollectGarbage.php(46): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#34 /mysite/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\CollectGarbage->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#35 /mysite/vendor/flarum/core/src/Http/Middleware/ParseJsonBody.php(28): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#36 /mysite/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\ParseJsonBody->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#37 /mysite/vendor/flarum/core/src/Http/Middleware/HandleErrors.php(57): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#38 /mysite/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\HandleErrors->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#39 /mysite/vendor/flarum/core/src/Http/Middleware/InjectActorReference.php(25): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#40 /mysite/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\InjectActorReference->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#41 /mysite/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(76): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#42 /mysite/vendor/middlewares/request-handler/src/RequestHandler.php(84): Laminas\Stratigility\MiddlewarePipe->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#43 /mysite/vendor/laminas/laminas-stratigility/src/Next.php(51): Middlewares\RequestHandler->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#44 /mysite/vendor/middlewares/base-path-router/src/BasePathRouter.php(101): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#45 /mysite/vendor/laminas/laminas-stratigility/src/Next.php(51): Middlewares\BasePathRouter->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#46 /mysite/vendor/laminas/laminas-stratigility/src/Middleware/OriginalMessages.php(36): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#47 /mysite/vendor/laminas/laminas-stratigility/src/Next.php(51): Laminas\Stratigility\Middleware\OriginalMessages->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#48 /mysite/vendor/middlewares/base-path/src/BasePath.php(73): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#49 /mysite/vendor/laminas/laminas-stratigility/src/Next.php(51): Middlewares\BasePath->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#50 /mysite/vendor/flarum/core/src/Http/Middleware/ProcessIp.php(24): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#51 /mysite/vendor/laminas/laminas-stratigility/src/Next.php(51): Flarum\Http\Middleware\ProcessIp->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\Next))
#52 /mysite/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(76): Laminas\Stratigility\Next->handle(Object(Laminas\Diactoros\ServerRequest))
#53 /mysite/vendor/laminas/laminas-stratigility/src/MiddlewarePipe.php(65): Laminas\Stratigility\MiddlewarePipe->process(Object(Laminas\Diactoros\ServerRequest), Object(Laminas\Stratigility\EmptyPipelineHandler))
#54 /mysite/vendor/laminas/laminas-httphandlerrunner/src/RequestHandlerRunner.php(96): Laminas\Stratigility\MiddlewarePipe->handle(Object(Laminas\Diactoros\ServerRequest))
#55 /mysite/vendor/flarum/core/src/Http/Server.php(44): Laminas\HttpHandlerRunner\RequestHandlerRunner->run()
#56 /mysite/index.php(26): Flarum\Http\Server->listen()
#57 {main}

A similar error happens with Google Sign in. But, these errors only happen in Safari. In Chrome, I log in just fine with both. I am using the very latest MacOS.

It says bool given... so that means, boolean given and it doesn't like that?

girefko

010101 Do you have PWA enabled? This caused a lot of issues to my forum (Facebook login gives me "Invalid state. Please try again"). Try disabling PWA and try again

010101

girefko Interesting… thanks, for letting me know! I think I deactivated PWA at one point and it didn’t make a difference. But, it could be that deactivating wasn’t enough. After deactivating I’m thinking there still could be things stored locally causing a conflict. I’ll try this again at some point. But, I’m not in a hurry. I’d rather have the PWA feature over OAuth login.

If I do ever confirm this I will of course alert everyone here.

girefko

I am having issues with Google OAuth. When I get to choose an account, nothing happens (loads for 2 seconds and nothing).

Is it because OAuth consent screen in Google Platform is still under "Verification in progress"?

girefko

girefko Update: For some reason, after enabling Google OAuth and trying to log-in, it breaks my website. Only way to fix it is by logging in through a mobile browser and disabling OAuth all together. Website just stops working on the PC. Anyone have a solution for this?

luceos

Is this extension not working at all? Seems there are quite a few unresolved issues with it?

010101

luceos My understanding is it works for many people. But, I’m thinking there is a popular extension that conflicts. One theory is the PWA extension conflicts. Or, could be another Safari bug. Or, user error.

I like the PWA theory. Because PWA stores a lot in local storage. Maybe too much is cached causing the auth to fail due to mismatched keys of some sort or something else the security doesn’t like.

To be 100% honest. I’m too stressed/lazy right now to test this anymore to find out if it is PWA.

Although this probably wouldn’t explain other issues I see.

girefko

010101 Hello, I have Uninstalled PWA through the Composer and the issue still persists. I am guessing there is another Extension that makes Google OAuth break the website. This is the 3rd time I have to login through a mobile browser and disable Flarum oauth in order to restore the site..

Is there any information I can provide that can be useful to the creators/DEVS of this Extension so they can check it out?

010101

girefko Yeah your Google issue sounds different. Your issue is about a window not closing right? Not sure I understand. That sounds like a browser bug to me. 🤷‍♂️

girefko

010101 Exactly! Window not closing and then the whole website crashes. I have tried with Firefox & Google and the only solution is to disable the Extension

Could it be a Google OAuth setup issue?

010101

girefko I had this issue too come to think of it.

I checked my error logs and there were errors about mismatched keys.

It could be the window isn’t closing because of the same types of issues I’ve been reporting.

Unfortunately, it’s not consistent for other people. Others swear this extension works fine. And so, it’s probably pretty hard to troubleshoot.

girefko

010101 Very strange.. Site crashes (desktop only) and only mobile website works after enabling Google OAuth. Takes about 30 minutes for everything to restore after disabling OAuth

Google console: VM156:6772 crbug/1173575, non-JS module files deprecated. (anonymous) @ VM156:6772

I have enabled Debug mode but no new files were created in Storage/logs

Flarum core 1.1.1 PHP version: 7.4.27 MySQL version: 5.5.5-10.3.32-MariaDB Loaded extensions: Core, date, libxml, openssl, pcre, zlib, filter, hash, pcntl, readline, Reflection, SPL, session, standard, bcmath, bz2, calendar, ctype, curl, dba, dom, enchant, mbstring,fileinfo, ftp, gd, gettext, gmp, iconv, imap, intl, json, ldap, exif, mysqlnd, odbc, PDO, pgsql, Phar, posix, pspell, shmop, SimpleXML, snmp, soap, sockets, sqlite3, sysvmsg, sysvsem, sysvshm, tidy, tokenizer, xml, xmlwriter, xsl, zip, mysqli, pdo_mysql, PDO_ODBC, pdo_pgsql, pdo_sqlite, xmlreader, xmlrpc, imagick, redis, ionCube Loader, Zend OPcache +---------------------------------+---------+--------+ | Flarum Extensions | | | +---------------------------------+---------+--------+ | ID | Version | Commit | +---------------------------------+---------+--------+ | flarum-flags | v1.1.0 | | | flarum-suspend | v1.1.0 | | | flarum-approval | v1.1.0 | | | flarum-tags | v1.1.0 | | | v17development-seo | v1.8.0 | | | michaelbelgium-discussion-views | v7.1.1 | | | ianm-level-ranks | 1.0.0 | | | futuresound-el | 0.1.24 | | | fof-spamblock | 1.0.2 | | | fof-sitemap | 1.0.3 | | | fof-share-social | 1.0.1 | | | fof-profile-image-crop | 1.0.1 | | | fof-pages | 1.0.1 | | | fof-filter | 1.0.2 | | | fof-custom-footer | 1.0.1 | | | fof-cookie-consent | 1.0.2 | | | fof-best-answer | 1.1.7 | | | fof-analytics | 1.0.0 | | | flarum-subscriptions | v1.1.0 | | | flarum-sticky | v1.1.0 | | | flarum-statistics | v1.1.0 | | | flarum-nicknames | v1.1.0 | | | flarum-mentions | v1.1.3 | | | flarum-markdown | v1.1.1 | | | flarum-lock | v1.1.0 | | | flarum-likes | v1.1.0 | | | flarum-lang-english | v1.1.0 | | | flarum-emoji | v1.1.1 | | | flarum-bbcode | v1.1.0 | | | extiverse-mercury | 0.1.3 | | | davwheat-ads | 1.0.1 | | | askvortsov-moderator-warnings | v0.6.1 | | +---------------------------------+---------+--------+ Base URL: https://girefko.com Installation path: /home/rwuaheww/public_html Queue driver: sync Mail driver: mail Debug mode: ON

010101

girefko I don’t think you will be able to fix this right now. At least, I can’t help. But, I’m the reason I say this is not to be negative. I think that browsers trying to become more and more secure. Thus, they keep changing things making it very hard to have a OAuth extension that will work in all situations. Sometimes I think my issues are mostly due to Safari bugs. But, there’s all kinds of reasons various OAuth set ups won’t work. Could also come down to the device itself.

It also boils down to the developers of this extension having time. They work on a lot of stuff. Or, the fof crew may not be able to replicate any of these issues and so where do you start?

girefko

Sorry for keep bumping this post but I can't figure out a solution to this.. I have just upgraded to Flarum 1.2 hoping to fix the issue but it happened again.

My site crashes completely when I enable Google oAuth

Only way to fix it is by logging-in to the admin panel through a web broswer (don't know why mobile works) and disable Google oAuth. Takes about 30 minutes for everything to get back to normal. Can you tell me why this happens and how to fix it? Is there an official way to submit such bugs?

luceos

girefko My site crashes completely when I enable Google oAuth

Try to look through your storage/logs files. There should be entries starting with flarum.ERROR, if any of those relate to vendor/fof/oauth you got the right one. Now copy and paste any complete trace (start at flarum.ERROR and any following line that starts with a hash # and a number.).

girefko

luceos Hi Luceos, no new logs appear in storage/logs. I tried turning on debug mode ON and replicated the issue but again no new .log files were created..

I wonder if it has to do with my Google OAuth console settings? What are you guys using?

010101

girefko there are other settings aren’t there? But the image you show there looks fine. That is the correct redirect URI.

Plus, didn’t you say this only happens in certain browsers? If yes, that’s my issue too. No known way to solve it.

I think browsers are adding/changing things for security. They may not even really advertise what they’ve changed. But, that is my theory. Browsers are getting stricter and so there’s probably just one or two lines of code deep in the library this extension uses which isn’t quite right.

One way to possibly fix this extension is if fof devs were able to find different decencies/libraries to use. We could then see if that clears anything up.

But, this is a lot of work. And for example, I don’t know what libraries to suggest. 🤷‍♂️

Keegan

Have a question about discord, on mobile (ios at least) it does not prompt app. Asks for discord login/pass. I don't have an example, but I remember other services that also allow discord sign-in to prompt my already-installed app to authorize instead of browser input.

Any suggestions? Or am I out to lunch

clarkwinkelmann

Keegan do you have the name of such a website? Or maybe it was a native app instead of a website?

We use the official OAuth2 flow and I don't see any special option for this. But there might be some sort of SDK that implements what you describe. The GameSDK mentioned in the documentation doesn't appear to be for mobile or web though.

« Previous Page Next Page »