Discussion Bookmarks

[deleted]

clarkwinkelmann

Version 1.0.0

Added compatibility with Flarum 1.0+
Changed discussion title to "Discussion Bookmarks" to prevent confusion with "Post Bookmarks"

Update sponsored by @glowingblue

Provokator86

Hi clarkwinkelmann . Add forum.js to your code
&& "comment" === o.contentType()
in Object(e.extend)(i.a, "userControls", function (t, o) { app.session.user **THIS** && "menu" === app.forum.attribute("post-bookmarks.buttonPosition") && t.add("bookmark", j.component({ className: "Button", post: o })); }),
This code will hide the 3 dots button in the banner of a closed and pinned discussion

clarkwinkelmann

Provokator86 you're saying the event posts can be bookmarked and that's undesirable? It's true that there's currently no filtering on which kinds of posts can be bookmarked. Not sure if that's a bug or feature though because there are other kind of event posts that users could want to bookmark.

I don't recommend modifying any file in vendor as the changes will be overridden during any update.

I'll try to take a look if I ever publish an update.

clarkwinkelmann

Version 1.1.0

This release adds a bookmark button on blog item pages from v17development's blog extension

Bookmarked articles appear like regular discussions on the bookmark list page. There's no change in behavior from version 1.0, just the button that was previously missing. (Articles are just themed discussions in this context)

clarkwinkelmann

Version 2.0

This update doesn't bring any immediate benefit, but is required for compatibility with some of my other extensions.

These changes bring consistency and reduce risks of conflict with the similar post-bookmarks extension.

User-facing changes:

Composer package name has changed.
Bookmark page was moved from /bookmarks to /bookmarked-discussions. There is no redirect.
Default setting value is properly reflected in the admin panel.
Added missing database index, should improve performance on large forums.
Use new Flarum sortMap feature to support extension-provided sort options at page load.

Internal changes:

Route names changed.
Javascript initializer name changed.
PHP namespace changed.
Translation keys changed.
Setting key changed.
CSS class names changed.
CSS now uses CSS variables.
Compiled javascript with Webpack 5.

Installation

composer require clarkwinkelmann/flarum-ext-discussion-bookmarks

The old extension will automatically be removed.

Visit the admin panel to enable the new extension.

If you had disabled the only setting, you will need to disable it again.

If you need to redirect your users to the new URL, you will have to create a rewrite rule in your webserver configuration, or you can use my KILOWHAT Custom Paths extension to rename the route back to the previous path.

maisen20

Thank you for this very useful extension, which is very well integrated.

Unfortunately it does not work if you have installed and activated the extension blomstra/flarum-ext-search (https://github.com/blomstra/flarum-ext-search). The bookmarks then don't appear at all under /bookmarked-discussions.

I can't expect you fix it, of course, but maybe you'll have time to look at it.

Anyway, many thanks and greetings from German-speaking Switzerland =)

maisen20

maisen20 Unfortunately it does not work if you have installed and activated the extension blomstra/flarum-ext-search (https://github.com/blomstra/flarum-ext-search). The bookmarks then don't appear at all under /bookmarked-discussions.

Am I the only one with this problem?

I have now made some manual adjustments, although it is probably not the best solution, at least the user can see his set bookmarks.

tahmid

Thanks for this helpful extension. Can I rename it to something shorter? The current name is quite long and gets truncated.

clarkwinkelmann

tahmid in which part of the UI? If you are referring to a text in a button or something you could use Linguist to change the translation to something different.

If you are talking about the URL path my Custom Paths extension can be used to customize it.

tahmid

Here is the issue

Bookmarks might be look more prettier.

clarkwinkelmann

tahmid install Linguist and search for translation clarkwinkelmann-discussion-bookmarks.forum.page.link 😉

I will not change the default text because it was intentionally written this way so there's no confusion if you also install Post Bookmarks

clarkwinkelmann

Version 2.0.1

Fixed incompatibility with some extensions that modify the SQL query used to retrieve Flarum discussions, thanks Ziiven for the GitHub PR

clarkwinkelmann

maisen20 can you share which changes you made ? If I have an idea what part to look at I might be able to write a fix, but at the moment I don't have any time for a full investigation myself.

maisen20

I made all the adjustments in the blomstra search extension, not in this bookmark extension.

So to have said it, I am not a Laravel / Flarum pro. But my customizations are in such a way that I have written a function which gets the bookmarked posts of the user from the database.

And I have changed the data function so that it simply checks if the request is filtering by "is:bookmarked", so $filter_bookmarked is set to true and this filter is removed from the request (cleaned up).
This way the bookmarked discussions from the user are fetched (via my new function) and then two filters (type & rawId) are added to the blomstra search query.

However, I have not really tested this intensively. For example, if I enter something in the search and want to see the search results only from the bookmarked discussions, i only get discussions which have a hit in the title (and no discussions which have a hint in the posts). I assume this is because I filter for discussions and posts are ignored...

But at least it shows the bookmarks.

« Previous Page