Making FoF/Gamification works with flarum beta.14

luuhai48

So i made some changes to the pack for it to work on the beta.14 of flarum. But i don't have enough time to test it carefully, so i'm asking help from you guys. Please help me test this, tell me if you find any issue. Thanks.

How To Install

Because i didn't submit it to Packagist.org, so you won't be able to composer require it. To install it, do:

Step 1: edit your composer.json file, so it should looks something like this:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/luuhai48/gamification.git"
        }
    ],
    "require": {
        ...
        "fof/gamification": "dev-master"
    }
}

Step 2: run composer update. You should get it working.

NOTE:

While updating the package, because you're pulling the package from github, it might hit the rate limit. In that case, it will ask you to provide a token from github. Just click the link provided in the console and follow instruction.

Link

https://github.com/luuhai48/gamification

luceos

Feel free to pr back when you are confident it works well.

luuhai48

luceos i actually learn a lot from this 🙂

luceos

luuhai48 a pull request could also help in getting a review from the maintainers right away. That's usually how this works. One of the maintainers can then also test the changes and accept it for merging or offer feedback for improvement.

EvilExecutor

Okay so I tested this extension, so I have some problems & suggestions to add.

The look at ranking page.

In the ranking page Start a Discussion button appears along with the tags which I thinks is unnecessary and makes the look bad. Also I think it would be awesome if the load more is centered instead of left alighned.

fof/reactions & fof/gamification not working good with each other.

This happens when I hover over the reactions button which makes reacting really hard 😳. I'm not sure the problem is caused by fof/reactions or fof/gamification, but surely it's due to one of them or maybe both 🤔 .

Reactions changes the Gamification points by "2"

So when I integrate Reactions with Gamification and identifiers in reactions to upvote & downvote, it changes the value by "2" instead of one. As an example if I have -1 points and upvote using fof/reactions, the no. points is set to 1 which is expected to be 0. Again not sure what caused the issue.

Found a little bug caused by Reactions extension when integrated with Gamification except those all works fine! Thanks for your effort @luuhai48

[deleted]

EvilExecutor All of these are easily fixed with CSS 🙂

Ralkage

EvilExecutor all of these are know issues except for probably #3.

Can we keep all related extension issues in their perspective discussions, please? 😁

EvilExecutor

Ralkage So is it okay if I report the third issue in fof/reactions Discussion?