Follow Tags Prompt

clarkwinkelmann

troymccann you mean the forum only has one hidden tag, and no other tags?

I suppose I could add a check for the number of tags on the forum before opening the modal.

troymccann

clarkwinkelmann No there are lots of tags. Some are hidden. In the setting's for this, though, I've told it to only work with one tag - which happens to be a hidden tag.

clarkwinkelmann

Version 0.2.1

Add compatibility with Flarum beta 16
Make modal open on custom homepages as well

Thanks @ctml for sponsoring the update.

enricodx

I don't fully understand what the "Show all discussions on the Following page for guests" do, since any guest can't see the Following page link 🤔

clarkwinkelmann

enricodx that's for when the Following page is set as homepage, which this extension also allows doing.

Otherwise it doesn't make much sense indeed.

enricodx

clarkwinkelmann Thanks!

clarkwinkelmann

Version 1.0.0

Added compatibility with Flarum 1.0+

Don't forget to set the extension version constraint to * or ^1.0 in your composer.json file before updating Flarum (as explained in Flarum's own upgrade guide)

Update sponsored by my GitHub Sponsors. Thanks for the support!

HasanMerkit

UI Bug:

clarkwinkelmann

HasanMerkit does the screenshot show the full viewport or does the modal appear like that on all screens including desktop computers? How many tags are listed in the modal?

If it is the full viewport, are there devices where this is likely to happen? Is it a mobile phone in landscape orientation?

HasanMerkit

clarkwinkelmann not happened after adding more tags.
1920x1080 resolution on Windows. (Latest Google Chrome)

May be required test with 1 tag website.

HasanMerkit

Plugin enabled: Tags are corrupted

Disabled:

clarkwinkelmann

Version 1.0.1

Fixes tag navigation in the left sidebar breaking when second-level primary tag are selected for the follow prompt modal.

Second level primary tags that weren't already preloaded would incorrectly appear as first-level primary tags.

This release also updates compilation to Webpack 5 and therefore requires Flarum 1.2+.

Thanks HasanMerkit for the report.

hrvoje_hr

I gave this a try and the only issue is that the front page doesn't have private discussions from Byobu anymore.

GreXXL

For me it says in the popup "follow tags not enabled" although it is. Can it be that due to version changes this has broken?

clarkwinkelmann

Version 1.1.0

Added compatibility with Follow Tags 1.2.0+.

Requires Flarum 1.5 or higher.

GreXXL this should fix it. There were breaking changes in Follow Tags 1.2.0.

Now a stacked modal will open to choose follow method instead of a dropdown.

GreXXL

clarkwinkelmann thanks for the quick action - works perfectly now!

GreXXL

Another question: Could this extension be modified (have an option) to show the dialog first only after the account has been activated. I do have the issue that due to permissions the prompt shows up empty which is a bummer because it most likely will get dismissed without any action. If necessary, would be interested in sponsoring this.

clarkwinkelmann

GreXXL this problem already has a GitHub issue since last year clarkwinkelmann/flarum-ext-follow-tags-prompt1

I took a quick look while working on my last update but I didn't identify any straightforward solution. User activation, suspend and FoF Terms might all require slightly different logic to work smoothly.

This could definitely be sponsored. I expect it's less than 1h of work but it's difficult to say for sure. If we ignore FoF Terms and just focus on user activation this would make the requirements for the update a bit easier to test.

GreXXL

clarkwinkelmann well I think the terms issue is not really my biggest problem because you do have to accept the terms in order to register anyways. The issue arises afterwards in an empty popup because none of the selected tags is visible for non-activated users. Even if terms change it would not trigger the popup again - so I don't thing this is a big issue? Anyhow for the context of this extension I would love to see this realised and am willing to sponsor this.

« Previous Page