Adding "Author" label to posts

[deleted]

enricodx Can you provide a link so I can check ?

Thanks

[deleted]

Ok. I just tried this on my own forum, and it works fine. I choose a random discussion from the list, and the AUTHOR tag shows. I then copy the URL and open it in another browser, and the AUTHOR tag shows there, too. If you can provide me with a URL so I can check, I'd appreciate it.

Thanks

Justoverclock

[deleted] u can try any url on Flarum.it

[deleted]

I think this is a bug in core to be honest. I can replicate this, and the reason as to why the author badge doesn't show is because the CSS class it relies on is not loaded unless triggered from the discussion list. There's nothing I can do to fix this sadly.

Justoverclock

[deleted] u think is good to open an issue? But I don't know how to explain that in technical terms

enricodx

[deleted] interesting 🤔 so why the Topic Starter extension works the opposite way? It show the label only on pages recalled by url

[deleted]

enricodx no idea, but perhaps they should meet 🤭

JohnP

I think it makes more sense for the 'author' badge to not be part of the link to the usercard/profile.

So, I think I'd be tempted to use

article.CommentPost.Post.Post--by-start-user .Post-header h3:after

instead of

article.CommentPost.Post.Post--by-start-user .Post-header h3 span.username:after

enricodx

JohnP Aaaaaaaand... a way to hide it from the first post only? Cause is obvious that he started the topic

JohnP

enricodx You could probably use The CSS selector :not(:first-child)

I'm not in front of computer right now, but I'll take a look when I am.

JohnP

enricodx

This should work:

div.PostStream div.PostStream-item:not(:first-child) article.CommentPost.Post.Post--by-start-user .Post-header h3:after { content: "Author"; background: #F05D1D; border-radius: 4px; padding-left: 10px; padding-right: 10px; color: #fff; margin-left: 14px; }

Justoverclock

JohnP with this code works on mobile, but not on desktop 😃

Walys

JohnP
I have similar code I view in this thread some months ago but now I update to Flarum 1.2 version and this resource not working for me.

This is my code:

It´s strange that not working with a minimal flarum update no?
In v104 working perfect and now in v120 not view any label with same code.

Any other user stay in Flarum v120 have possibility to testing the same code?

JohnP

Justoverclock That's weird, I'm looking at it on a desktop now and it's working. Which browser?

Justoverclock

JohnP google chrome

EDIT: fixed, it was the cache 🙂

but if i use a direct link, same issue, it works only if i choose a discussion from discussion list, not for direct link

Justoverclock

another strange thing:

here: https://flarum.it/d/53-language-pack-italiano-by-flarumit/20 i can see the label
here not: https://flarum.it/d/72-cookie-policy

enricodx

Justoverclock I don't see the labels on either

Justoverclock

enricodx

Justoverclock Checked, and the label appears only if opened directly from the discussions page. If I open it in a new tab, the label not shows. Non ne usciamo vivi.

[deleted]

enricodx Yes, this is exactly the same issue I reported previously.

peopleinside

Any idea of what JavaScript is needed for fix the behavior that made author label disappear when a discussion is opened in a new tab or when the page is reloaded?

Justoverclock

peopleinside actually the solution is an extension, i'm working on it

datitisev

peopleinside Looks like this probably happens because the "user" object is compared (see https://github.com/flarum/core/blob/d4e3254395fa03a0653218a543e23ad9de76ae77/js/src/forum/components/Post.js#L135-L137) and may differ between the session user & the discussion user. The solution would probably be to compare their IDs or specific data instead of the entire object.

I can confirm this is a Flarum core bug.

« Previous Page Next Page »