• [deleted]

  • Post #1
  • Edited

IMPORTANT!! - I have removed the phenomlab/fancybox repository, and replaced this with phenomlab-fancybox-wrapper (to more accurately reflect what this extension does).

If you have this extension installed, please issue composer remove phenomlab/fancybox then issue composer require phenomlab/fancybox-wrapper

Fancybox-Wrapper

I've put together a simple extension that wraps all images (including those generated by fof-upload) and makes them compatible with the Fancybox library

Installation

composer require phenomlab/fancybox-wrapper

Updating

composer update phenomlab/fancybox-wrapper

Removal

composer remove phenomlab/fancybox-wrapper

Links

INFORMATION: If you use reflar/recache you will happy to know that this extension fully supports LazyLoad of images.

  • [deleted]

  • Post #2

Just tagged 0.1.7, which will resolve a raft of issues 🙂

composer update phenomlab/fancybox, or composer require phenomlab/fancybox:0.1.7

So just saw this thread after posting in the other thread.... Looks like my issues is probably the lazy loading being turned on in recache....

Anyway to make this work with lazy loading? I have a lot of images in my post so that's needed to keep page speeds at a decent load time.

    • [deleted]

    • Post #6
    • Edited

    All - please note, I have removed the phenomlab/fancybox repository, and replaced this with phenomlab-fancybox-wrapper (to more accurately reflect what this extension does).

    IMPORTANT: If you have this extension installed, please issue composer remove phenomlab/fancybox then issue composer require phenomlab/fancybox-wrapper

    Note, that this train will soon also support lazy loading via reflar/recache

    • [deleted]

    • Post #7

    MikeJones tagged phenomlab\fancybox-wrapper at 0.2 which now has support for reflar/recache lazyloaded images 🙂 You might need to wait a while for it to be available, but the tag is 0.2 - you should be able to execute composer update phenomlab/fancybox-wrapper

        @[deleted] when I close the fancy box it jumps me to the top of my post each time, and does an odd animation. Not sure how to explain it....

          • [deleted]

          • Post #11

          MikeJones no need to explain. I've seen this also. It's coming from the Fancybox library, and it's something I need to take a look at in order to override.

            • [deleted]

            • Post #12

            MikeJones when I close the fancy box it jumps me to the top of my post each time, and does an odd animation. Not sure how to explain it....

            I've just tagged 0.4 which resolves this issue. It also adds a few performance increases - mostly deferring JS and CSS using async and preload. It's available on packagist now

            Use composer update phenomlab/fancybox-wrapper. Check php flarum info to ensure you have 0.4. If not, use composer require phenomlab/fancybox-wrapper

                [deleted] well it didn't update...

                Loading composer repositories with package information
https://flagrow.io/satis could not be fully loaded (The "https://extiverse.com/satis/packages.json" file could not be downloaded (HTTP/2 400 )), package information was loaded from the local cache and may be out of date
Updating dependencies
Nothing to modify in lock file
Installing dependencies from lock file (including require-dev)
Nothing to install, update or remove
Generating autoload files
composer/package-versions-deprecated: Generating version class...
composer/package-versions-deprecated: ...done generating version class
98 packages you are using are looking for funding.
Use the `composer fund` command to find out more!

                    • [deleted]

                    • Post #15
                    • Edited

                    MikeJones try composer require phenomlab/fancybox-wrapper as I mentioned in my previous post.

                        [deleted] Worked!

                        Looking good! It does look like I get an orange highlight on my images at the bottom. Maybe an underline? but I will look into css, I think the highlight looks odd on mouse over.

                            • [deleted]

                            • Post #17

                            MikeJones that's probably your own CSS as I'm definitely not seeing that on my sites 👍

                                MikeJones @[deleted] Have the same underline under all images (thin if not over, but present)That's maybe because it's simply a link and apply the default css

                                    • [deleted]

                                    • Post #20

                                    Amarok yes, I had to set border-bottom: none; on all links to get rid of the same thing which is why I don't see it