[deleted]
Darkle Exactly. Thanks
Darkle Exactly. Thanks
[deleted] never tried this extension earlier. seekadventure always inspired me to install this. I have installed it just now .. no issues ... it's working like a sharp knife.
Thanks a lot
Hari Thanks for letting me know !
[deleted] i was searching for this extension in the forum using words like : image gallery, image popup, image view, photo gallery, Light box... i could not find it in the beginning later using https://lab.migratetoflarum.com/ I have come to know the exact name
add this image in the first post na . it does help others too
Yeah found a bug fixing this will be appreciated, This extension is not compatible with Internal Links No Reload However i can give up Internal Links No Reload as It is more better IF you can fix this please fix this.
One More thing:
This extension is Super Ultra useful can you please also make this as WordPress Plugin as I searched whole plugins all are good but this FEEL is nowhere and Some wants to collect unsensitive data and all that PRO, etc..
[deleted] What icon are you referring to ?
Few days before I seen a like icon instead of this gamification icon
[deleted] Yeah found a bug fixing this will be appreciated, This extension is not compatible with Internal Links No Reload However i can give up Internal Links No Reload as It is more better
IF you can fix this please fix this.
I'm aware of the incompatibility. It seems that this extension overwrites elements that mine does, so I don't think it's going to be incompatible anytime soon. I also have no plans to make it compatible.
[deleted] This extension is Super Ultra useful can you please also make this as WordPress Plugin as I searched whole plugins all are good but this FEEL is nowhere and Some wants to collect unsensitive data and all that PRO, etc
There are already several WordPress plugins that offer this functionality. There's no need to reinvent the wheel.
[deleted] Few days before I seen a like icon instead of this gamificatio
As @User24 has already mentioned, this is from the gamification extension. All I did here was to replace the font awesome icon from the default to another one (by the way, metabullet.com uses the font awesome 5 Pro extensions which are not free)
Darkle No, it shouldn't. Can you try clearing the cache and let me know if the issue resolves, or if it remains ? I'll also need a URL to test on your site.
Thanks
[deleted] The error is super weird, more than I thought, it turns out that the moment I add 1 image uploaded through FoF upload to a discussion that goes to my bucket automatically all the images have this problem, whether or not they are uploaded by FoF upload.
On the other hand if a discussion has no images uploaded by FoF upload no image suffers from this problem.
First image no FoF Upload, second one yes. Both experience the error.
https://brickdose.com/d/193-test
First image (the same as in the previous test) and second image not FoF Upload. Neither experiences the error.
https://brickdose.com/d/194-test-2
Darkle I can't see any issue with the links you provided in terms of the images being loaded ?
Darkle I tried that, and cannot replicate. Tried across 3 browsers also. Are you sure this isn't a cache issue ?
EDIT - I see it now, yes.
Darkle The code itself is relatively simplistic in the sense that it looks for IMG tags, and then adds a HREF wrapper
<script>
flarum.core.compat.extend.extend(flarum.core.compat['components/CommentPost'].prototype, 'oncreate', function (output, vnode) {
const self = this;
this.$('img').not('.emoji').not(".Avatar").not($(".PostMeta-ip img")).each(function () {
var currentImage = $(this);
var checksrc = currentImage.attr("data-src");
if (checksrc) {
$(this).wrap("<a class=\"fancybox\" href='" + currentImage.attr("data-src") + "'></a>");
}
else {
$(this).wrap("<a class=\"fancybox\" href='" + currentImage.attr("src") + "'></a>");
}
try {
$().ready(function(){
$().fancybox({
selector: '.fancybox'
});
})
} catch (e) {
console.error(e.name);
console.error(e.message);
}
});
});
</script>
My guess is that this could be coming from the Fancybox library itself rather than this extension.
[deleted] Ok I see, that would make sense. So with this I'm sure it's not a problem with the extension, sorry for the inconvenience.
The other thing that occurs to me is that if it's only because of these images maybe my bucket could be related? Sometimes permissions do strange things and I don't have much idea about S3 permissions
Darkle The other thing that occurs to me is that if it's only because of these images maybe my bucket could be related?
That's entirely possible, yes. I can't test this myself, as I do not use remote storage (as such for Flarum), but will be happy to work with you to determine any workaround we could put into place. However, I am fairly convinced it's the Fancybox library causing this.
Darkle WOW your forum is ultra super amazing, Can you please also tell me how you have added this tab layout in this discussion https://brickdose.com/d/44-faq-forums/2
Can I also get footer html css