Flarum Discussion Views

[deleted]

010101 But, anyone out there, hopefully someone can duplicate my issue mentioned above... with the latest version of this views extension installed, and the abbreviation setting turned on, and the Pages extension with a page created, go to the page.

I can replicate this exact issue. As you state, it's evident when the number abbreviation is enabled.

In addition, it looks like (according to the pace.js progress bar I have) that the page is being loaded twice.

Alshain

MichaelBelgium

http://www.bytecheck.com/

When I install the Discussion Views plugin, the site opens automatically 1-2 seconds late.
You can check this with gtmetrix and pagespeed.
What is this problem caused by?

I had to disable the plugin just because of this problem 🙁

[deleted]

Alshain I'm thinking of doing the same

zyronix

@MichaelBelgium the issue indeed easy to replicate, just make sure you're going straight to the page URL at first (and not for instance using the Links extension instead).

it looks like your discussionviews relationships are not loaded if the page doesn't load with any discussion data. I don't have this issue by appending a relationship to ForumSerializer / ShowForumController instead

@[deleted] only a negligible 40ms difference in load speeds (its literally only a few kilobytes difference in js) or anything that would indicate files are being loaded twice on my end

[deleted]

MichaelBelgium My issue is that sometimes it only shows the eye and not the number. When i go on the post again and back i see the number again.

Littlegolden

[deleted] Yes, me too.

zyronix

[deleted] It's related to the same issue, that happens with abbreviations disabled

Littlegolden

MichaelBelgium Yeah, that either way because there's no way to know who viewed the discussions in the past. It's inaccurate data in my opinion and I have no idea if people rather want inaccurate data than no data.

@010101 @Alshain @[deleted] @zyronix @[deleted]
So what do you guys think about "inheriting views data from the old version"? Don’t you care about the uncomfortableness of counting views from zero after the update? 🙁

010101

Littlegolden I personally don’t care because no one uses my forum. 😂 But, if people ever found my forum and started using it and something like this happened, I would care. At the same time, this is a great extension that @MichaelBelgium maintains for free and the update he did sets it up for cool new features in the future.

Plus, I’m mentally preparing myself for Flarum Stable. I think I’ve read hints here and there that some extensions will break again once we hit Flarum 1.0. We might have to go through many more little things like this with other extensions as they update and Flarum updates. Eventually, the way extensions are done will become more stable as Flarum core becomes more stable. Right now, it’s kind of like a new civilization. A brand new colony. There will be set backs. ✌️

MichaelBelgium

Version 3.0.1 released

Everyone, say thanks to @datitisev for fixing the redirect bug (MichaelBelgium/flarum-discussion-views17)

010101

MichaelBelgium Thank you! And, @datitisev, thank you! Redirect bug fixed!

Although tip for others. At first I thought it still wasn’t fixed. But, then I deactivated and reactivated the extension.

[deleted]

This and previous version breaks my flarum. v3.0.1 disables mydomain.com/admin :-/

[deleted]

Even after complete removal of this extension, "an eye" is visible:

Is it possible that some parts of this extension are breaking my access to flarum admin site?

Managed to find this from yesterday:

[2020-01-23 18:24:07] production.ERROR: PDOException: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'XXX_fflarum.fl19_discussion_views' doesn't exist in /home/XXX/flarum/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php:61
Stack trace:
#0 /home/XXX/flarum/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php(61): PDO->prepare('select * from `...', Array)
#1 /home/XXX/flarum/vendor/illuminate/database/Connection.php(326): Doctrine\DBAL\Driver\PDOConnection->prepare('select * from `...')
#2 /home/XXX/flarum/vendor/illuminate/database/Connection.php(657): Illuminate\Database\Connection->Illuminate\Database\{closure}('select * from `...', Array)
#3 /home/XXX/flarum/vendor/illuminate/database/Connection.php(624): Illuminate\Database\Connection->runQueryCallback('select * from `...', Array, Object(Closure))

MichaelBelgium

[deleted] u didnt migrate?

php flarum migrate
php flarum cache:clear

[deleted]

MichaelBelgium
"Nothing to migrate"...
So, when visiting flarum admin I get message: "Something went wrong..."

Littlegolden

[deleted] Try this solution, turn off this extension in the dashboard, refresh the web page, then turn on this extension again, refresh the page.

MichaelBelgium

[deleted] Can you check your migrations table in your database to see if you already migrated it? I assume you did already as it says you don't have migrations to run. So you probably dropped the table manually or some kind..

Execute the command php flarum migrate:reset --extension michaelbelgium-discussion-views and php flarum migrate after again

[deleted]

Littlegolden Try this solution, turn off this extension in the dashboard, refresh the web page, then turn on this extension again, refresh the page.

Thanks for reply, but problem is - I can't access admin dashboard 😀

[deleted]

MichaelBelgium thanks for the effort, but this did not solve my priblem. Can I manually delete table row for this extension in MySql using phpMyAdmin, then reinstall extension?

MichaelBelgium

[deleted] Thats what php flarum migrate:reset --extension michaelbelgium-discussion-views wouldve done: remove all database changes that the extension made. I would do that again and remove the extension, afterwards php flarum cache:clear and then install it again

« Previous Page Next Page »