Flarum Discussion Views

DavecUK

@MichaelBelgium I found a problem with the extension on my forum

The biggest problem it caused was blank screens and double tag headers if you tried to view the forum from an external link, into a specific subject.
e.g. if you tried to click on this thread https://coffeetime.freeflarum.com/d/115-random-issues-on-forum-no-likequotereplyphotos-is-it-just-me/194
You could get no posts showing and the tag area header showing twice. Viewing it from within the forum links worked fine though.

Some users had random problems even within the forum when viewing posts. The image below shows what happens when clicking a link that's sent outside the forum e.g. in an e-mail, or on whatsapp. The header actually shows twice and all the posts are blank. It's completely reproducible as well.

MichaelBelgium

DavecUK That's odd, do you have a javascript error or some kind, when u reproduced? As that's the most useful thing for me to fix 😃

DavecUK

MichaelBelgium That's odd, do you have a javascript error or some kind, when u reproduced? As that's the most useful thing for me to fix

I don't,
What I do have is quite a large forum...initially I linked it to one tag area (classifieds) and enabled it...the forum went from fast to barely responding, it took about 5 minutes for me to disable it again. Freflarum increased some resources and suggested I try it again. I did, but did a purge (assuming it would clear the database out), I think that purge then made it look at all Tag areas on the forum. The forum became unusable (unresponsive), and I had to do a full forum reset,

There's something wrong with it, but I don't know what it is...it's doing something very resource intensive and at the time I didn't even have any users on!

My suspicion is that any forums successfully using this may not be large, or possibly on powerful servers that can handle whatever it's doing.

murdocklawless

is it possible take this list under the scrollbar?

MichaelBelgium

murdocklawless I think i tried that before but then it was never visible as the scrollbar has the full height or something

jslirola

@MichaelBelgium In the last backup of my site I have realized that the database is larger than normal, it was the table "discussion_views". I forgot to disable Track guests and now I have almost 500k rows there.

I have already disabled that option, can I truncate the table to leave it empty or will it give me a problem?

And another question, any idea what happens if views don't show up when a discussion has more than one tag? It only happens if I am not logged in, but the permissions to see the counter are set for everyone.

My bet is that it happens when there is a tag that doesn't have permissions defined since I have about 30 but they only have 3 of them.

Thank you.

MichaelBelgium

jslirola U don't have to truncate the table, you can just remove the guest views
For the other question, tags don't matter when showing the viewcount - normally

tyeca If the default css does not suffice, you'll have to edit it more

tyeca

how to fix this?

murdocklawless

default view position is like this, when the numbers getting bigger the view icon is going left side;

I think it should be like this, so even thousands of views can not be move view icon to the left anymore;

MichaelBelgium

murdocklawless I would prefer that too but due to the HTML dom it's not really possible.
When extending the discussionlist item, the "info" is only extendable - which is the lower part of such discussion item. which means the summary or the post preview + whatever u wanna add more. In this case the view number, and with CSS it's a bit messy to place it on the right

lisbonjoker To "disable" viewcount on such listitem you can change permissions. ~~To place it correctly, like i said above, you'd need to play around with the css~~

masihdindar Like i said here https://discuss.flarum.org/d/30447-page-doesnt-load-properly-when-refresh-with-reply-id-in-url/13 I'd need some more info
Or if anyone else is encountering this issue, shout please and give some information how to reproduce

EDIT: ok i actually pushed an update (v1.7.3) that improves the css, now the reply number and view number should be below one another. On mobile this changed too: it's not below eachother anymore, but the viewnumber is litteraly in the list-item info now

lisbonjoker

A way to disable list views and show up on the post itself because with themes like Asirem looks like this:

masihdindar

Somehow this extension can cause a url with "Reply ID" included stop loading the content.
Here my full detailed report:
https://discuss.flarum.org/d/30447-page-doesnt-load-properly-when-refresh-with-reply-id-in-url

And after some spending time, i found out that "Enable footer viewlist" cause this problem. Now this extension is enabled and without "Enable footer viewlist" option everything works fine. Can you check what's wrong with this option?

This is my php flarum info :

Flarum core 1.2.0
PHP version: 7.4.28
MySQL version: 10.3.34-MariaDB-log-cll-lve
Loaded extensions: Core, bcmath, calendar, ctype, date, filter, hash, iconv, json, SPL, pcre, readline, Reflection, session, standard, mysqlnd, tokenizer, zip, zlib, libxml, dom, PDO, bz2, SimpleXML, xml, xmlreader, xmlwriter, openssl, curl, fileinfo, gd, gettext, mbstring, exif, mysqli, pdo_mysql, pdo_sqlite, Phar, ftp
+-------------------------------------+---------+--------+
| Flarum Extensions                   |         |        |
+-------------------------------------+---------+--------+
| ID                                  | Version | Commit |
+-------------------------------------+---------+--------+
| flarum-flags                        | v1.2.0  |        |
| flarum-nicknames                    | v1.2.0  |        |
| flarum-tags                         | v1.2.0  |        |
| flarum-likes                        | v1.2.0  |        |
| flarum-approval                     | v1.2.0  |        |
| flarum-markdown                     | v1.2.0  |        |
| afrux-forum-widgets-core            | v0.1.7  |        |
| v17development-user-badges          | v1.0.0  |        |
| v17development-seo                  | v1.8.0  |        |
| the-turk-flamoji                    | 1.0.2   |        |
| sycho-profile-cover                 | v1.3.1  |        |
| nearata-internal-links-noreload     | v2.0.1  |        |
| michaelbelgium-discussion-views     | v7.1.2  |        |
| justoverclock-purify                | 0.1.7   |        |
| justoverclock-hashtag               | 0.2.3   |        |
| justoverclock-contactme             | 0.2.3   |        |
| justoverclock-auto-post-count-badge | 0.1.9   |        |
| irmmr-rtl                           | V0.1.2  |        |
| fof-username-request                | 1.0.1   |        |
| fof-upload                          | 1.1.0   |        |
| fof-subscribed                      | 1.0.2   |        |
| fof-stopforumspam                   | 1.2.0   |        |
| fof-split                           | 1.0.1   |        |
| fof-socialprofile                   | 1.1.1   |        |
| fof-sitemap                         | 1.0.3   |        |
| fof-secure-https                    | 1.0.1   |        |
| fof-recaptcha                       | 1.0.0   |        |
| fof-pretty-mail                     | 1.0.1   |        |
| fof-pages                           | 1.0.1   |        |
| fof-merge-discussions               | 1.2.1   |        |
| fof-links                           | 1.0.3   |        |
| fof-linguist                        | 1.0.3   |        |
| fof-formatting                      | 1.0.2   |        |
| fof-best-answer                     | 1.1.8   |        |
| flarum-suspend                      | v1.2.0  |        |
| flarum-subscriptions                | v1.2.0  |        |
| flarum-sticky                       | v1.2.0  |        |
| flarum-statistics                   | v1.2.0  |        |
| flarum-mentions                     | v1.2.0  |        |
| flarum-lock                         | v1.2.0  |        |
| flarum-lang-english                 | v1.2.0  |        |
| flarum-bbcode                       | v1.2.0  |        |
| datlechin-title-length              | v0.1.1  |        |
| clarkwinkelmann-who-read            | 1.4.0   |        |
| clarkwinkelmann-likes-received      | 1.0.0   |        |
| clarkwinkelmann-first-post-approval | 1.0.0   |        |
| askvortsov-rich-text                | v2.1.1  |        |
| askvortsov-markdown-tables          | v1.2.1  |        |
| afrux-top-posters-widget            | v0.1.4  |        |
| afrux-online-users-widget           | v0.1.5  |        |
| afrux-forum-stats-widget            | v0.1.1  |        |
| acpl-mobile-tab                     | 1.1.0   |        |
| acpl-lscache                        | 0.4.1   |        |
+-------------------------------------+---------+--------+
Base URL: https://betalk.ir/public
Installation path: C:\xampp\htdocs\flarum
Queue driver: sync
Mail driver: smtp
Debug mode: off

HaPi_r

MichaelBelgium
That option is also the variable name "showFooterViewList"
The source code will see if showFooterViewList is "1" or not
If it is 1, this function will continue to run

external url access when o.posts()[0] return value is not 1 ~ 10 floor information (from the forum click in is there)
The code here is probably around a keyword "showFooterViewList" can search to find the
As I said before, when showFooterViewList is 1, it will execute the function of loading the component (which means the above)

external url access if statement in o.posts()[0] is undefined, resulting in . id will report an error.
That's pretty much what it looks like.

Simply put, external url access will report an error if the transmitted value is not 1 floor (because the server only transmits the last 10 messages when the external link is accessed)
In this case o.posts()[0] is undefined, o.posts()[0].id will report an error

English is not good, translated from Chinese by DEEPL

那个选项也就是变量名"showFooterViewList"
源代码中是会看showFooterViewList是否为"1"
如果为1将继续运行本函数

外部url访问的时候o.posts()[0]返回值是没有1_{10楼的信息的（从坛内点进去是有的）}
这里的代码大概是周围有一个关键字"showFooterViewList"可以搜一下找到的
前面说了当showFooterViewList为1的时候会执行加载组件(也就是指上面那个)的函数

外部url访问的时候 if语句中o.posts()[0]是undefined，导致.id会报错。
差不多就是这个样子。

简单地说，外部url访问的时候如果传输的值没有1楼将会报错（因为外链访问的时候服务器只传输最近的10条信息）
此情况下o.posts()[0] 为 undefined，o.posts()[0].id就会报错

murdocklawless

MichaelBelgium thanks for the update 😃

VusaL_MX

after install fontawesome 6 not wieved icon ![https://prnt.sc/GreZlBetg2kv](https://)

install : https://extiverse.com/extension/blomstra/fontawesome

Ziven

VusaL_MX You can use css to fix this

.item-discussion-views ::before { font-family:'Font Awesome 6 Free' !important; }

Add it to Appearance->Edit Custom CSS

lichengkun135

How can I show the discussion view counts next to the discussion title and not showing who actually viewed the post?

m4v3rick

m4v3rick "Enable footer viewlist" breaks discussion

Still a bug.

m4v3rick

m4v3rick Still a bug.

Did you fix that too, @MichaelBelgium ?

MichaelBelgium

For people who discussions break because of the footer viewlist, please elaborate with an error or some kind so i can find out whats going wrong on your forums.

I also suggest creating github issues, because i check github more often than flarum forums

MichaelBelgium

v7.2

Option to ignore bots/crawlers (yes it took me 2 years, sorry @rob006 - actually almost 3! )
Added help texts to settings

Behind the scenes:

Replaced deprecated Migration::addSettings
Updated js packages
Edited/added translations

Full Changelog: https://github.com/MichaelBelgium/flarum-discussion-views/compare/v7.1.3...v7.2

« Previous Page Next Page »