WYSIWYG / Rich Text Editor

huuduy216

@askvortsov When I copy and paste an image to the editor, I think it get converted to based 64 or something. Then I can't post because it exceed the maximum character allowance. Can we please have a button to disable this feature, this would make using other upload extension like FoF Upload or Simple Imgur much much easier too. Thanks

askvortsov

huuduy216 I will disable pasting base64 images and 010101 I'll investigate:

Auto-starting outside the blockquote when quoting
hashtags incompatibility (I'm not sure at all why this is, the 2 should be able to work fine in theory)

when I have time, as I have a lot of exams in the coming week

010101

askvortsov I’m just happy it was another extension that I don’t necessarily need that was causing my main issues.

I wouldn’t spend too much time trying to figure out why my hashtags extension conflicted. My hashtags extension conflicts with multiple extensions. Which is why I’m ready to just retire it. Flarum needs a better hashtags extension.

ornanovitch

Hi there!

I finally made it to beta-16 and WYSIWYG for my users! Everything looks great, thanks a lot!

~~I just have a little problem of compatibility with the Upload extension. Whenever fof/upload AND wysiwyg are enabled, I have a console error and I can't make upload working:~~

edit: oops, I just wasn't on the last fof/upload version. Fixed.

ornanovitch

I also listed all the little issues I found, if someone could try to reproduce them:

when manually inserting an inline code with back ticks, the second back tick keeps displaying itself after the code, and if I remove it, the code formatting goes away.
when manually inserting italic text with * right after non-italicized text, the space between the two words is deleted (blabla *italic* becomes blablaitalic)
list formatting is breaking some accent characters keyboard behavior, at least for french keyboard. It seems it only occurs with back ticks and circumflex accent (^): everywhere else, including wysiwyg editor (outside a list), you normally have to press twice the back tick key or the ^ key to display those characters, because they are usually used in combination with other characters ("être", "où" for example). But whenever you are on a list (bullet or numbered), the characters are directly put after the first pressing, which is really strange and unusable for a language which use a lot those accents. Let's resume: only in a list, when I press ^e to put a ê, the editor displays ^e (and formats to ^e, which is logic). Outside a list, the behavior is correct: if I want ê, I press ^e, and if I want ^e, I press ^^e

Thanks for reading!

askvortsov

ornanovitch Will look k to these too, thanks for reporting!

BlockCat

Hi!
Is there a way to import extension components?

askvortsov

BlockCat extension components?

What do you mean by extension components? This extension exports all its classes so they can be monkey patched; see https://github.com/askvortsov1/flarum-checklist for an example of consumption

BlockCat

askvortsov I tried the import method from fof/formatting, https://github.com/FriendsOfFlarum/formatting/blob/master/js/src/admin/components/FormattingExtensionSettingsPage.js

webpack.config.js

module.exports = require('flarum-webpack-config')({
    useExtensions: ['askvortsov-flarum-rich-text'],
});

index.js

import { components } from '@askvortsov-flarum-rich-text';
app.initializers.add('myExtension', () => {
  console.log(components);
});

I received:

(index):141 Uncaught TypeError: Cannot read property 'components' of undefined
    at index.js:15
    at Application.js:168
    at Array.forEach (<anonymous>)
    at e.boot (Application.js:168)
    at (index):136

askvortsov

BlockCat

'askvortsov-flarum-rich-text' should be 'askvortsov-rich-text', as flarum- is stripped from extension IDs

BlockCat

askvortsov thank, require('@askvortsov-rich-text').components.CommandButton worked!

010101

Another small bug to test out. It could be another extension conflict. I’m not sure yet.

Post using this editor. Now edit the post. Place cursor somewhere and start typing. Any previous line breaks go away and all the text runs together.

ornanovitch

010101 I just tested, I'm able to reproduce: more precisely, if you edit a paragraph with one or more line breaks into it, all of them will be unwrapped and the paragraph becomes a one-line text.

askvortsov

v1.1.1

Disable pasting base64 huuduy216
Start cursor outside block quote when quoting 010101
Fix lines in paragraph being combined together 010101
Fix italics being combined with previous word ornanovitch

ornanovitch when manually inserting an inline code with back ticks, the second back tick keeps displaying itself after the code, and if I remove it, the code formatting goes away.

I haven't been able to replicate this one, any chance you could record a video of it happening?

ornanovitch list formatting is breaking some accent characters keyboard behavior, at least for french keyboard.

Which accent keyboard are you using?

ornanovitch

askvortsov many thanks for all this! I'll take the time to reproduce those issues on a video 📹 and I'll bring more details on the 🇨🇵 accent stuff asap

010101

askvortsov Thank you!

010101

New small bug. This ones super weird. SoundCloud links will not turn into a music player (embed) with this extension. Other URLs do. YouTube works and Twitter works. Just not SoundCloud. I know it is this extension since deactivating and clearing cache makes the SoundCloud URLs convert. And, SoundCloud URLs work here at discuss.

ornanovitch

askvortsov Here is a little record for both of the issues.

My ⌨️ layout specs:

$ setxkbmap -query
rules:      evdev
model:      pc105
layout:     fr
variant:    latin9

I'm gonna try to reproduce on windows, as I'm on archlinux.

EDIT half-good news: I can't reproduce on windows, so I guess it's something with my linux keyboard layout. I'll try to test with another french keyboard layout

askvortsov

ornanovitch I'm gonna try to reproduce on windows, as I'm on archlinux.

I use Fedora, so no need. I'll try to break it using this setup, thanks!

ornanovitch

askvortsov OK perfect! Maybe a clue regarding the ^ accent problem inside a list: I can't reproduce the issue on the prosemirror official demo. Concerning the second issue with the back tick, I haven't been able to test as they don't seem to have the in-line code feature

« Previous Page Next Page »