Argument 1 passed to [...] must be an instance of s9e\TextFormatter\Renderer

askvortsov

clarkwinkelmann I've seen this happen more and more lately. We should really look into being explicit if such a permissions issue happens; right now users are left with no clue.

matteocontrini

clarkwinkelmann Flarum might not be able to update or delete some of the cache files

If with "cache files" you mean the storage/cache directory, that's not possible with my setup. Those files are created by Flarum and thus the owner is the web server/PHP user, which also has write permission since the default is 644.

luceos

matteocontrini are you using a redis cache (if so post package name and version)?

matteocontrini

luceos I'm not, it's a new Flarum installation with just a few "local" extensions for development

luceos

matteocontrini in case this error happens an output of ls -la storage/formatter would help.

[deleted]

Just chiming in here. This happens to me on a daily basis, and I helped a new user last night with exactly the same issue. It's pretty frustrating to say the least.

Link to the post I created here

matteocontrini

luceos it's empty

askvortsov

luceos storage/formatter seems to be cleared properly, but storage/cache is implemented via laravel's cache system and messes up something with file permissions. More problematically, it fails silently so admins don't know they need to take extra steps. Maybe there's some config we're missing

matteocontrini

askvortsov I still don't get how PHP wouldn't be able to delete those files though...

❯ tree -pu storage/cache
storage/cache
└── [drwxr-xr-x www-data]  77
    └── [drwxr-xr-x www-data]  e1
        └── [-rw-r--r-- www-data]  77e1ba46ee3a2b2d1558d7c5d07c4c0caa46c7bf

2 directories, 1 file

PHP-FPM workers are running as www-data.

luceos

When this error occurs, does the public/assets/rev-manifest.json exist?

matteocontrini

luceos yes. For the record I'm able to reproduce this consistently every single time I clear the cache.

❯ php flarum cache:clear
Clearing the cache...

❯ tree -pu public/assets
public/assets
├── [-rw-r--r-- www-data]  admin-0f433783.css
├── [-rw-r--r-- www-data]  admin-9e2287c7.js
├── [-rw-r--r-- www-data]  admin-9e2287c7.js.map
├── [-rw-r--r-- www-data]  admin-en-02b04265.js
├── [-rw-r--r-- www-data]  admin-en-02b04265.js.map
├── [drw-rw-rw- www-data]  avatars
├── [drwxrwxrwx www-data]  fonts
│   ├── [-rw-r--r-- www-data]  fa-brands-400.eot
│   ├── [-rw-r--r-- www-data]  fa-brands-400.svg
│   ├── [-rw-r--r-- www-data]  fa-brands-400.ttf
│   ├── [-rw-r--r-- www-data]  fa-brands-400.woff
│   ├── [-rw-r--r-- www-data]  fa-brands-400.woff2
│   ├── [-rw-r--r-- www-data]  fa-regular-400.eot
│   ├── [-rw-r--r-- www-data]  fa-regular-400.svg
│   ├── [-rw-r--r-- www-data]  fa-regular-400.ttf
│   ├── [-rw-r--r-- www-data]  fa-regular-400.woff
│   ├── [-rw-r--r-- www-data]  fa-regular-400.woff2
│   ├── [-rw-r--r-- www-data]  fa-solid-900.eot
│   ├── [-rw-r--r-- www-data]  fa-solid-900.svg
│   ├── [-rw-r--r-- www-data]  fa-solid-900.ttf
│   ├── [-rw-r--r-- www-data]  fa-solid-900.woff
│   └── [-rw-r--r-- www-data]  fa-solid-900.woff2
├── [-rw-r--r-- www-data]  forum-4d78bb14.js
├── [-rw-r--r-- www-data]  forum-4d78bb14.js.map
├── [-rw-r--r-- www-data]  forum-817e7ffb.css
├── [-rw-r--r-- www-data]  forum-en-7f7ccb0f.js
├── [-rw-r--r-- www-data]  forum-en-7f7ccb0f.js.map
└── [-rw-rw-rw- www-data]  rev-manifest.json

2 directories, 26 files
❯ cat public/assets/rev-manifest.json
{"admin.js":"9e2287c7","admin-en.js":"02b04265","admin.css":"0f433783","admin-en.css":"empty","forum.js":"4d78bb14","forum-en.js":"7f7ccb0f","forum.css":"817e7ffb","forum-en.css":"empty"}

askvortsov

matteocontrini Any chance you could open a GH issue for this? It's a pretty big issue IMO, so I want to make sure it's properly on the milestone.

matteocontrini

Done: flarum/core2723