Internal Links No Reload

Nearata

2.0.0

Update Flarum 1.0. thanks @Ralkage !

[deleted]

Nearata Hi - there is still a conflict with phenomlab/fancybox-wrapper. As far as I can tell, the link when clicked does not even do anything other than simply redirect to the main site. An example of this can be shown here - https://metabullet.com/d/231-show-off-your-desktop

Go to the first image in the link, then click it. It'll just take you to the homepage.

I don't think there's anything I can do about this as far as my extension is concerned. Perhaps you could include an option to ignore the /assets folder ?

EDIT: in fact, it doesn't seem to work with any images even with phenomlab/fancybox-wrapper removed. It seems to work fine with images outside of the assets folder as can be seen in this link - https://metabullet.com/p/6-site-security

EDIT2 - For now, I've disabled this extension so that my images at least work 🙂 I know several users who want to use both of our extensions together (I'm one of them), so it'd be good if we can work this out.

Nearata

[deleted] thank you for your collaboration ! 💗

i draft a new release (2.0.1) that should fix it, hopefully. i'd be very grateful if you could test this out ! 🚀

[deleted]

Nearata This seems to work fine for phenomlab/fancybox-wrapper but now kills off phenomlab/scrolltotop 🤣

https://extiverse.com/extension/phenomlab/scrolltotop

Any chance you can take a look at this also ?

Thanks

EDIT: Sorry - ignore the part about scrolltoptop. I know why that is which I'll fix.

hereistheme

This extension should not reload the page for tags/menu links as well ? Is annoying to be switched on top of the page when clicking a tag and there are more selections under that tag..

m4v3rick

hereistheme

Good point.

masihdindar

In latest version, Admin link in header doesn't work and we should open it in new tab instead of clicking on it!

Nearata

masihdindar fixed 2.1.1

Nearata

m4v3rick can you give me steps to reproduce this issue? or can you tell me if this still happen in the latest release? (2.1.1)

Teddan

Nearata
I noticed there maybe some problems in 1.4.1

It forces to back to top first when users were trying to back to last page by swiping left on mobile, and sometimes users have to swipe two or three times to go back.

It stucks the page when users try to go back to last page.

Both of them are not happened untill I upgraded to 1.4.1

Nearata

Teddan version 2.1.1? i'm not able to reproduce it

Teddan

Nearata

Yes . It happens in the latest version .

This is how it performed when I enabled this extension. You can see when I tried to go back to last page, it stucks for a while and jumps back to the discussion. Then I can actually go back by swiping the screen :

It acts normally when I disabled the extension:

Like I said it didn’t happen before 1.4.1. I don’t know if there are any conflicts between extensions to be blamed, since I just disabled extensions one by one to find out which causes to it.

This is the flarum info:

Flarum core 1.4.1
PHP version: 8.0.20
MySQL version: 5.7.37-log
Loaded extensions: +------------------------- | Flarum Extensions +------------------------- | ID +------------------------- | flarum-suspend | flarum-subscriptions | flarum-tags | flarum-lock | flarum-sticky | fof-user-directory | fof-follow-tags | flarum-nicknames | flarum-flags | v17development-blog | flamarkt-backoffice | flarum-mentions | afrux-forum-widgets-core | zequeen-acgembed-remastered | yannisme-oxotheme | v17development-user-badges | tohsakarat-table-of-content | the-turk-stickiest | the-turk-flamoji | sycho-profile-cover | sycho-advanced-extension-categories | swaggymacro-only-starter | nearata-internal-links-noreload | nearata-cakeday | kyrne-whisper | justoverclock-hashtag | justoverclock-feedback | ianm-follow-users | ganuonglachanh-sonic | ganuonglachanh-search | fof-username-request | fof-user-bio | fof-terms | fof-prevent-necrobumping | fof-pretty-mail | fof-polls | fof-pages | fof-nightmode | fof-masquerade | fof-links | fof-frontpage | fof-formatting | fof-drafts | fof-default-user-preferences | fof-best-answer | flarumite-simple-discussion-views | flarum-statistics | flarum-pusher | flarum-markdown | flarum-likes | flarum-lang-english | flarum-lang-chinese-simplified | flarum-bbcode | flarum-approval | flamarkt-taxonomies | datlechin-usercard-uid | datlechin-scroll-buttons | datlechin-copy-links | datlechin-bbcode-hide-content | darkle-fancybox | clarkwinkelmann-roll-die | clarkwinkelmann-prominen | clarkwinkelmann-post-bookmarks | clarkwinkelmann-discussi | clarkwinkelmann-discussion-lists | clarkwinkelmann-composer-page | clarkwinkelmann-bookmarks | clarkwinkelmann-author-change | blomstra-cache-assets | askvortsov-moderator-warnings | askvortsov-discussion-templates | askvortsov-categories | afrux-top-posters-widget | afrux-news-widget | afrux-forum-stats-widget | acpl-mobile-tab +------------------------- Core, date, libxml, openssl, pcre, sqlite3, zlib, bcmath, ctype, curl, dom, filter, ftp, gd, gettext, hash, iconv, intl, json, mbstring, SPL, session, pcntl, standard, PDO, mysqlnd, pdo_sqlite, Phar, posix, Reflection, pdo_mysql, shmop, SimpleXML, soap, sockets, sodium, mysqli, sysvsem, tokenizer, xml, xmlreader, xmlwriter, zip, fileinfo, exif
-----------------+-------------+------------------------------------------+
| | |
-----------------+-------------+------------------------------------------+
| Version | Commit |
-----------------+-------------+------------------------------------------+
| v1.4.0 | |
| v1.4.0 | |
| v1.4.0 | |
| v1.4.0 | |
| v1.4.0 | |
| 1.2.3 | |
| 1.1.6 | |
| v1.4.0 | |
| v1.4.0 | |
| v0.6.4 | |
| 0.1.1 | |
| v1.4.0 | |
| v0.1.7 | |
| v1.1.2 | |
| 2.1.5 | |
| v1.1.0 | |
| v1.0.1 | |
| 2.0.3 | |
| 1.0.4 | |
| v1.3.3 | |
| v0.1.3 | |
| 0.6.4 | |
| v2.1.1 | |
| v2.1.0 | |
| 0.1.4 | |
| 1.0.1 | |
| 0.1.9 | |
| 1.2.0 | |
| 0.1.5 | |
| 0.5.1 | |
| 1.0.1 | |
| 1.1.0 | |
| 1.2.0 | |
| 1.1.0 | |
| 1.1.0 | |
| 1.1.0 | |
| 1.0.4 | |
| 1.4.1 | |
| 2.1.3 | |
| 1.1.2 | |
| 1.1.0 | |
| 1.0.2 | |
| 1.1.2 | |
| 1.1.1 | |
| 1.2.3 | |
| 1.1.5 | |
| v1.4.1 | |
| v1.4.0 | |
| v1.4.0 | |
| v1.4.0 | |
| v1.4.0 | |
| v1.1.1.1220 | |
| v1.4.0 | |
| v1.4.0 | |
| 0.1.5 | 55b0985d42b185dc76218f640f710a049aeddd59 |
| v0.1.1 | |
| v1.0.0 | |
| v0.1.1 | |
| v0.1.5 | |
| 1.1.2 | |
| 1.0.0 | |
t-post-numbers | 1.0.0 | |
| 1.0.0 | |
on-open-position | 1.0.0 | |
| dev-main | ed3fc3402531d505e2b859f5bee00225f8602fa7 |
| 1.0.0 | |
| 1.1.0 | |
| 1.0.2 | |
| 0.5 | |
| v0.6.1 | |
| v0.8.3 | |
| v3.0.6 | |
| v0.1.4 | |
| v0.1.1 | |
| v0.1.1 | |
| 1.1.0 | |
-----------------+-------------+------------------------------------------+!<

Wapriaily

After Flarum 1.4.1 updates the plugin 2.1.2, the page accessed from the banner can be returned normally, and other pages cannot be returned normally (including personal homepage and settings, etc.), and it takes two clicks to return normally.

Nearata

@Teddan @Wapriaily try version 2.1.3 when you have time. Thanks for your feedback and patient.

tolgaaaltas

I wonder why this isn't part of Flarum's core.

FullThrottle83

@Nearata I have long wondered why going to the admin via the meny makes me return to startpage.
Just figured out that it's due to this extension.
If disabled, the menu> /admin works.
Not a biggie, I can just type myforum.com/admin - but perhaps that is something you would like to correct.

Tried it on two forums, same result on both.

tolgaaaltas

FullThrottle83 I'm using this extension daily and never faced this problem.

FullThrottle83

Yeah, that's wierd.

@Nearata if you wish to instruct me in how I can troubleshoot this, and perhaps give you important info - please ping me, here or on discord.

hcllmsx

Is it certain that it is really working?Why do I feel like it doesn't work. I clicked on the internal link, for example, the link for the current post is abc.com/d/x. I inserted a link in this post to link abc.com/d/x for the current page. After I clicked on it, the browser still reloaded. It's like pressing the F5 key once.Or perhaps I misunderstood and used the wrong method?

« Previous Page