[1.0+] Using the new loading spinner

pupsik

On my forum, the new spinner (oval thing) only shows on index page, the rest of pages is still round thing. Sopose to be like that?

Braden

I stayed whole night trying to fix this thing in flarum15, it seem to be a small thing Loadingindicator but was unsuccessful. I am ashamed - going back to sleep

davwheat

Braden

You cannot use the spinner on anything below Flarum 1.0.

matteocontrini

Why is the component sometimes called LoadingSpinner in the first post? I see no component named like that in Flarum's source code. 🤨

rafaucau

matteocontrini There is <LoadingIndicator />

clarkwinkelmann

matteocontrini I think it's a mistake. @davwheat can you confirm? There are two JSX examples and the CSS example that are using the wrong name.

davwheat

clarkwinkelmann

Yeah, it's me being an idiot... That's all! 😅

matteocontrini

davwheat thanks ahah I initially thought that LoadingSpinner was wrapping LoadingIndicator or something like that. Mystery solved.

ctml

Love me the new spinner!

I hit one issue with it with fof/upload though, I am not sure if it should be reported there, here, or maybe even rich text extension. When uploading it looks like the below.

clarkwinkelmann

ctml does it require both Rich Text and FoF Upload to reproduce?

If it reproduces just with Upload, then it should be reported to that extension.

Most likely it will have something to do with some custom CSS or another enabled extension because I doubt this would have passed our QA tests in FriendsOfFlarum without anyone noticing.

ctml

clarkwinkelmann I disabled rich text and it still occurred so that rules that out. I don't have any css for .LoadingIndictator-container--block which is looks like where it gets its enormous height.

Hari

this happens to me too, its fof / Upload css issue? button get bigger after selecting the file from local . but it will work okay if we post from our clipboard.

Happens with Imgur only?

matteocontrini

The LoadingIndicator should have the attribute display="inline", that should fix it. (I've seen this issue while updating Imgur Upload as well.)

https://github.com/FriendsOfFlarum/upload/blob/bfa7b523151c021fabd50be14929a042715e841a/js/src/forum/components/UploadButton.js#L43

Hari

matteocontrini i don't know how to report with technical details, could you create an issue at GitHub.