Loading order

llaumgui

Hi,

I would like override BBCode extension... Is there a loading order guaranteeing that my extension is loading after bbcode ?

luceos

Check the optional-dependencies key in the composer.json in the docs: https://docs.flarum.org/extend/extending-extensions.html#optional-dependencies

llaumgui

Thx luceos !

I seem OK, I can override full feature:

return [
    (new Extend\Formatter)
        ->configure(function (Configurator $config) {
            $tag = $config->tags['quote'];
            $tag->template = preg_replace(
                '(.*)',
                'rrrrrrrrr',
                $tag->template
            );
            $config->rendering->parameters['L_WROTE'] = 'A écrit';
            extract($config->finalize());
        })
];

Replace all QUOTE tag by rrrrrrrrr. But I just whould like to replace wrote by a écrit...

return [
    // Override quote tags
    (new Extend\Formatter)
        ->configure(function (Configurator $config) {
            $tag = $config->tags['quote'];
            $config->rendering->parameters['L_WROTE'] = 'A écrit';
            extract($config->finalize());
        })
];

Not working

return [
        // OVerride quote tags
        (new Extend\Formatter)
            ->configure(function (Configurator $config) {
                $config->rendering->parameters['L_WROTE'] = 'A écrit';
            })
];

Not working... I just want override L_WROTEparametter.

SychO

llaumgui you have to clear the cache php flarum cache:clear

we also really need to localize those strings ourselves so that they can be translated into other languages, could you create an issue about that on github please 🙏 ?

llaumgui

SychO llaumgui you have to clear the cache php flarum cache:clear
Already done...

we also really need to localize those strings ourselves so that they can be translated into other languages, could you
create an issue about that on github please 🙏 ?

I tried to fix issue only for me for the moment before to use transition and propose a PR to flarum/bbcode...

Issue open here: flarum/core2841

SychO

llaumgui hmm, yes I can't figure out how we can replace bbcode parameters added from the existing s9e formatter bundle, but I believe this'll work just fine, had to re-declare the template with the parameter.

(new Extend\Formatter)
        ->configure(function ($configurator) {
            $configurator->rendering->parameters['L_WROTE'] = 'A écrit:';
            $tag = $configurator->tags['QUOTE'];
            $tag->template = '<blockquote><xsl:if test="not(@author)"><xsl:attribute name="class">uncited</xsl:attribute></xsl:if><div><xsl:if test="@author"><cite><xsl:value-of select="@author"/> <xsl:value-of select="$L_WROTE"/></cite></xsl:if><xsl:apply-templates/></div></blockquote>';
        })

and thank you for opening the issue!

llaumgui

SychO Thx !!! It's work fine only if I fork bbcode extension:

            $config->BBCodes->addFromRepository('QUOTE');
            $config->rendering->parameters['L_WROTE'] = 'A écrit:';
            $tag = $config->tags['QUOTE'];
            $tag->template = '<blockquote><xsl:if test="not(@author)"><xsl:attribute name="class">uncited</xsl:attribute></xsl:if><div><xsl:if test="@author"><cite><xsl:value-of select="@author"/> <xsl:value-of select="$L_WROTE"/></cite></xsl:if><xsl:apply-templates/></div></blockquote>';
            extract($config->finalize());

But if I put in my own extension I have an issue... I think that my extension is loaded before bbcode... But I use "optional-dependencies":

        "flarum-extension": {
            "title": "Fedora-Fr theme",
            "icon": {
                "name": "fab fa-fedora",
                "backgroundColor": "#51a2da",
                "color": "#fff"
            },
            "optional-dependencies": [
                "flarum/bbcode"
            ]
        }

SychO

llaumgui I don't believe you need to call exctract, also did you add optional-dependencies to your composer.json file after or before installing the extension ?