[Extension Developers] Flarum 1.0 QA Phase Update Period

Justoverclock

askvortsov can u tell me how? so i start to setup a new instance for extension update

SychO

Justoverclock You can install a normal beta 16 instance and then do the steps above.

Justoverclock

here we go!...now i can start update 🙂

but the language pack works fine....how can i check well for error?

edit SychO :
i see this on admin dashboard:

llaumgui

It's me or there is a major change in extender and all plugin are incompatible ?

Flarum encountered a boot error (Flarum\Extension\Exception\ExtensionBootError)
Experienced an error while booting extension: Discussion views. Error occurred while applying an extender of type: Closure.
thrown in /var/www/flarum/vendor/flarum/core/src/Extension/Extension.php on line 142

tankerkiller125

llaumgui This is related to https://docs.flarum.org/extend/update-1.0.html#compat-and-closure-extenders

Qiaeru

I tested the French language pack and it works fine with 1.0.0-dev. 😉

However, I didn't quite understand the changes in the translation system. What do the translators have to do? How to implement genderization?

Justoverclock

Qiaeru me too, it works fine intalian too

datitisev

Qiaeru Justoverclock I think any translations that differ based on a count (e.g. one vs many).

You can see an example @ flarum/coreb455199.

-      allow_some_minutes_button: "For {count} minute|For {count} minutes"
+      allow_some_minutes_button: "{count, plural, one {For # minute} other {For # minutes}}"

Justoverclock

datitisev yes, but there's a method for me to quick check these translations?

what is the simple way to debug all translation?

and there's a constraint that can we use to allow people to install compatible estension on both beta 16 and 1? @datitisev

Qiaeru

Yes, I saw that. I'm updating everything on my side. I need to look how it's possible to genderize. Thanks.

Qiaeru

Justoverclock I checked all the ICU MessageFormat changes, and here it's:

For Flarum's core: flarum/coreb455199 (search for locale/core.yml file)
For "Tags" extension: flarum/tags3694f2c (search for locale/en.yml file)
For "Pusher" extension: flarum/pusher30bebb9 (search for locale/en.yml file)
For "Likes" extension: flarum/likes468f701 (search for locale/en.yml file)

Justoverclock

Qiaeru thank u so much.

i've noticed that i see a warning into console about:

index.js:36 Calling$.tooltipis now deprecated. Please use the<Tooltip>component exposed by flarum/core instead.$.tooltipmay be removed in a future version of Flarum.

but i have only one extension enabled, and i do not call old tooltip....so its related to core?

Darkle

So the core is preprepared for this, but in the case of the extensions the genders would have to be previously defined by the extensions themselves? how would the extension know when to make the gender change?

Qiaeru Thank you 🙏

010101

Justoverclock i've noticed that i see a warning into console about:

index.js:36 Calling$.tooltipis now deprecated. Please use the<Tooltip>component exposed by flarum/core instead.$.tooltipmay be removed in a future version of Flarum.

but i have only one extension enabled, and i do not call old tooltip....so its related to core?

I see this too. Is it correct to assume that a warning like this is only showing due to this being a dev version of 1.0? Real 1.0 wouldn't spam a user's console, right? I have an unhealthy obsession with having a clean console on my production sites (zero warnings, zero errors).

askvortsov

Justoverclock index.js:36 Calling$.tooltipis now deprecated. Please use the<Tooltip>component exposed by flarum/core instead.$.tooltipmay be removed in a future version of Flarum.

I think this is a bug in one of our bundled extensions, well work on it.

datitisev

Darkle Genders aren't currently supported. The change of the translation system allows it to be possible in the future. Currently, extensions can implement their own genderization, however to affect the entirety of core they'd have to replace all the translations & when they are used... so not very feasible at the moment.

Darkle

datitisev Ok that makes it so much easier, I thought I had to implement this as well, thanks!

MichaelBelgium

Looks like my extensions discussion-views and profile-views only require the transchoice change and then it's ready for v1.0! Already got a branch ready to merge

The dutch language pack is another story though ...
And mybb-to-flarum doesn't require any change.

010101

When it was said that 1.0 will bring breaking changes again, what must have been meant was: If you create really advanced, complex extensions with a ton of translations, they could break. Because my handful of extensions require no changes. Including my blatant copy of necrobumping that I recently published (expired posts). Which means necrobumping is compatible too.

🥳

askvortsov

010101 Because my handful of extensions require no changes. Including my blatant copy of necrobumping that I recently published (expired posts).

BTW, don't forget to tag a new version for 1.0

Justoverclock

010101 yeah, the same for me, i hate console log error 😆 .

but i think is only for dev version, you're right