Inline Audio (aka Audio URL to Player)

CyberGene

010101 well, could be a combination of extensions, but I always clean the Flarum cache and the browser cache after installing new extensions. After I removed this extension, the upload button reappeared... Not sure what it is but it's a bit difficult to debug that while my forum is live. Which leads me to another question, if it is possible to somehow create a "staging" copy of my forum to test stuff like that.

010101

CyberGene It’s possible. The SoundManager 2 library this uses could conflict with another extension’s JavaScript.

As far as a staging environment, you’d have to look up how to install Flarum locally on your computer. Or, install another copy in some other ideally password protected directory on your server.

010101

CyberGene I was just able to reproduce this on my local install. It's the way Flarum is working. It is either a Flarum Core bug, or this is the way the devs want it to work.

https://discuss.flarum.org/d/30033-js-library-from-forums-assets-folder-does-not-always-load

If we find out this is the way Flarum is supposed to work, then I'll have to abandon this extension.

CyberGene

010101 thanks, hopefully this gets solved because we’re a piano forum and would get use of an embedded player for audio files 👍🏻

010101

v3.0

Removed code to make as minimal as possible
JavaScript no longer served from public assets folder (this means more compatibility and less future bugs)
Changed from headphones icon, to play button (as far as the icon that shows in the post)
Clean, minimal, fast

CyberGene: This version works around that Flarum core bug. The bug was due to how the JavaScript was loaded. Also, this helps to give you a solution to also allow users to download the audio if they want. Because, with this player you simply right-click on the link and download/save the audio file.

CyberGene

010101 I’ll try that, thanks!

CyberGene

Tested it, works great. I noticed something though. When I have a post with an audio URL and post it, there's no play button, only the URL, although the player works. I have to refresh the page to see the little play button in front of the URL, is that normal?

010101

CyberGene Yeah that’s “normal” for this extension at least. 😁 But, let’s say immediately another user clicks on the post. They will see the play button. It’s a very temporary phenomenon that only the person who creates the post sees. And even then, the next time you view the post it’s there. 🤷‍♂️

And before anyone else comments who knows how to code Flarum extensions better than me. I know, there’s the oncreate vnode mithril stuff. It’s just, with the soundmanager audio library this uses, this was the best I could get it right now. 👍

CyberGene

010101 no problem, it’s OK. The extension works great on my forum now, thank you 🍻

CyberGene

Not sure when it stopped working, haven't paid attention but the only change recently is I updated some extensions and Flarum form 1.2 to 1.2.1, and I don't have the play button anymore... I haven't installed new extensions though. Not sure when exactly it stopped working though.

010101

CyberGene I haven’t updated to the latest minor release of Flarum yet. But, I wouldn’t think it would break this.

Any errors in the browser’s dev console?
Did you empty both Flarum cache and browser cache?

CyberGene

010101 OK, it turned out it's the AdGuard blocker. Disabling it on the forum and the play buttons are visible again. However I also notice the problem on Vivaldi and Brave browsers which have an embedded adblocker. This wasn't the case before.

CyberGene

Does this extension contain trackers or tracking technologies? Is it sending some data to Google or stuff like that?

010101

CyberGene No.

I have read that ad blockers can sometimes think certain JavaScript is an ad. I don’t think I can solve this.

There are no ads or tracking in this extension. It is simply, SoundManager 2.

CyberGene

It's OK now again. I guess there might have been a filtering rule definition that got messed up but was fixed later. Those filters are constantly being refined and published on the Internet, so all is OK again. I have re-enabled the ad-blocker.

« Previous Page