Predefined Avatars

Hari

Another Advantage of this extension is if multiple users selects a single default profile pic and if discussion page is loaded the single image will be loaded, no extra loading 😀 am I right ?

For example a user and b use having conversation and has same default profile pic only single image or svg will be loaded insted of two .

clarkwinkelmann

Hari correct. The avatars images will have the same src value, so the browser should make a single request.

clarkwinkelmann

Released version 1.0.0 with Flarum 1.0 compatibility.

susan2022

为什么我无法上传头像？文件夹已经给了777权限，并设置www用户组，

我上传的是png，可是到访服务器就变成jpg了

请问这种情况要怎么解决问题？

Prosperous

susan2022 I have approved your post purely due to the fact that it is relevant to this discussion. However, as per the guidelines, please ensure you are posting in English. Even using Google Translate is better than nothing. 🙂

mtdev

Getting the same issue as @susan2022 where the images aren't displaying properly.

Tried with different image formats but still got the same results. It seems like the images are being corrupted once they're uploaded to the server.

clarkwinkelmann

mtdev can you check the javascript console + network tab of your browser development tool to see the URL of the image that Flarum is attempting to load and what the error is? It's probably either a 404 error or a cross-origin issue. If the domain is wrong then it could be an issue with your forum canonical URL. If it's a 404 error with the correct domain maybe there was an issue writing the files to disk and they are actually missing from your server.

mtdev

clarkwinkelmann Not seeing any errors. The console log is empty, here's my network tab:

Braden

Justoverclock this can be a good way to learn how to extract the country flags in assets 😉

clarkwinkelmann

mtdev what happens if you force a full page refresh without browser cache? (CTRL+F5) or clear the browser cache manually / use private browsing.

The response shows the file has been loaded from the browser cache and the server informed the browser the file was not modified, so it seems whatever broken file is loaded comes from the browser cache.

mtdev

clarkwinkelmann Tried clearing cache + hard reload and also using incognito mode, no difference. I checked the files on the server directly in the /predefined directory and it seems that they're all corrupted there, so it might be an issue in the upload process?

clarkwinkelmann

mtdev can you send me example files (the original ones not broken) so I can try them on my test server? You can send them privately via Discord or email.

mtdev

clarkwinkelmann Sounds good, sent you an email.

clarkwinkelmann

mtdev thanks, I did some tests on my server but I could not replicate the issue.

There's only one thing I can think of that could cause an issue, which I have fixed in the new release. It would be caused by a different extension trying to read the files upload at the same time, but I can't think of any extension that would do that.

If that doesn't fix it, maybe it's an issue with the webserver not forwarding the file content properly, or the filesystem having an issue. But both seem unlikely because both would also break regular avatar upload.

Version 1.0.1

Updated javascript to Webpack 5, requires Flarum 1.2+
Fixed upload button styling
Potential fix for empty uploads by rewinding the stream before reading

mtdev

clarkwinkelmann Awesome! It works great now. Thanks a lot for the speedy fix.

mtdev

One more thing I noticed is that for predefined avatars, the image quality is lower when displayed in posts but seems fine in the user profile.

User profile:

Predefined avatar in post:

Normal avatar using the same image:

clarkwinkelmann

mtdev make sure to use 100x100 pixels image size if you want the same quality as native Flarum avatars. Smaller images or odd sizes could lead to resize/aliasing artifacts when the browser stretches the image.

Using even larger images should be even better for quality (but not as much for bandwidth!) as long as the browser doesn't do any strange aliasing there.

mtdev

clarkwinkelmann Yup that did the trick, thanks!

Wapriaily

Thank you very much. This update has also solved my problem！

PARADOXP

Whenever I am trying to choose an avatar from lists it's saying me "The avatar url format is invalid "

Please solve this 🥺

clarkwinkelmann

PARADOXP can you share your php flarum info output?

You mean you can successfully configure images in the admin but there's an error when trying to pick one as a user? Does it work for admins?

I have no idea where that message could be coming from. It seems like the output of a Laravel validator for an avatar_url attribute, but neither Flarum core nor my extension uses a validator that way.

I haven't used the extension recently though so maybe Flarum broke something, but I expect I would have received other reports if so.