@Davis, since this is going into core, maybe you have the developers' ears for this...
But one thing that becomes immediately clear for site owners employing a global identity/nav bar is that the site name value that gets inserted into <title>...</title> and <h1 class="Header-title">...</h1> is no longer ideal for search engines. These two elements need controlled separately.
For example, consider discussion.csf.community... With our use of a global identity/nav bar, we relegate the <h1 class="Header-title"> value as "Main page", which it is under this architecture. But that's no longer appropriate for the title because it provides no useful information to search engines, or when sharing links in social media.
So the Forum Title value in Admin > Basics should output to the title element only, and not to that h1 location too.
Looking ahead with this, and I know it's beyond scope of this thread, nor do I know how devs have decided to handle core implementation of your extension, but...
One good way to handle the issue is for devs to merge @sijad's Links and Pages extensions into core too as a single Local pages feature managed in Admin > Dashboard, or wherever. Then a site owner could use that native functionality to manage the class="Header-title" and class="Header-primary" items together easily, but under a more logical semantic.
For example, changing this:
<div class="container">
<h1 class="Header-title">...</h1>
<div id="header-primary" class="Header-primary">
<ul class="Header-controls">
<li class="item-link1">...</li>
<li class="item-link2">...</li>
...etc
</ul>
<div id="header-secondary" class="Header-secondary">
<ul class="Header-controls">
<li class="item-search">...</li>
<li class="item-flags">...</li>
...etc
</ul>
</div>
...
</div>
To this:
<div class="container">
<nav id="localNav">
<ul class="local-nav">
<li class="nav-item1 home">Main page</li>
<li class="nav-item2">Rules</li>
<li class="nav-item3">Groups</li>
<li class="nav-item4">Help</li>
</ul>
</nav>
<div id="access">
<ul class="access-controls">
<li class="item-search">...</li>
<li class="item-flags">...</li>
...etc
</ul>
</div>
</div>
I changed some selector names as well to demonstrate how the current redundant patterns in selector names could be cleared up a little too. (A problem throughout the markup that makes working with CSS harder than it needs to be).
