010101 Justoverclock Same as before. Invalid regular expression. Safari/iOS doesn’t like it. There’s a lot of posts online about it.
Justoverclock 010101 yes seems that Safari does not support look behind assertion....so i need to use a different regex. maybe @iPurpl3x can help me to find a solution? i will work on this btw
010101 Justoverclock Never mind on the above. I may have found a solution... Pull request submitted. Test it out.
Justoverclock 010101 this will parse even https://docs.flarum.org/#about-flarum anchor tag...so i think is not good https://regex101.com/r/JbJW8l/1
010101 Justoverclock Oops, ok, try new pull request... https://regex101.com/r/MdIxm1/1 Just some slight differences which Safari is OK with. And should work with all languages.
010101 Oh shoot. It's SO close... I just realized the latest one is ignoring anchor tags and other characters but it's including the preceding space...
010101 Justoverclock I'm not sure why but simply adding a space on line 15 where the hyperlink is created makes it work...
010101 Justoverclock You won't be able to just test it with the regex online tool. There's something about adding a space before the anchor on line 15 that makes it fully work.
Justoverclock @010101 unfortunately even this one can't work, because if u add 2 hashtag in the same post, the second return with "#" in the generated link
010101 Justoverclock Wow. Well, one of these times I'll get it. Another pull request is coming your way. This could be the winner. This solution adds in a couple extra .replace() and .trim() methods.
Justoverclock 0.1.9 010101 Give it a full test on your mac 🙂 and thx. Probably we have finally reached the goal toghether 🙂 Updating composer update justoverclock/flarum-ext-hashtag php flarum cache:clear
010101 Justoverclock Woohoo! I’m sure there will always be an extension or two not compatible (like that language selector). But, at least it works in all browsers and languages! 🍻
