- Edited
Justoverclock it works with Thai language
I am sorry to say this Its not working with the vowel
Justoverclock it works with Thai language
I am sorry to say this Its not working with the vowel
Akito mmhh i was pretty sure about the regex, i wil find a solution for these problems
Justoverclock Oh. The current regex matches unicode letters. Which covers most languages. But, I think some languages use characters which are technically a "mark" not a "letter." This may work:
const regex = /(^|\s)#(\p{L}\p{M}*+)/gu;
For this line:
https://github.com/justoverclockl/flarum-ext-hashtag/blob/91c75b0e7d178ba90fe935358e9a8f9d197e5d92/js/src/forum/ReplaceHashTag.js#L5
Not tested. Just read about \p{M} mid-page here: https://www.regular-expressions.info
There's possibly better/easier regex solutions. But, the problem we've run into in the past is that certain regex is not compatible in Safari.
010101 only look behind assertion are not compatible, I will test some variants
Odd bug. With this extension enabled, if I click the three dot menu for a post (next to reply/like), clicking on it causes the page to jump up. Must be something to do with the JavaScript this uses?
010101 odd, I can’t reproduce this, maybe a mix of extensions
Justoverclock What does this do? It’s the only part that sticks out as potentially the reason.
.click((e) => {
if (e.ctrlKey || e.metaKey || e.which === 2) return;
I don’t use too many other extensions that interact with the post. I do use the GIF extension. I’ll have to see what happens if I deactivate the GIF extension.
010101 is only an event that prevent the click with some keyboard button pressed
Works fine to me, and I installed many extensions.
Justoverclock Ok, sorry. Now it's fine. It's almost as if deactivating it and reactivating it fixed it. It was probably a ghost.
Pull request submitted to fix the reports above about certain accents not being detected. justoverclockl/flarum-ext-hashtag8
010101 i see that is closed
Justoverclock this one is open: justoverclockl/flarum-ext-hashtag8
I wrote this for information.
This extension works fine.
I enabled so many extension that I can't understand why there is so few conflicts. I did it for tests purpose.
improved regex, thx to 010101 for the pr
Justoverclock Thanks!
New idea. I replied to @Pipecraft here in the last pull request: https://github.com/justoverclockl/flarum-ext-hashtag/pull/8#discussion_r737431136
The idea is, eventually, add an admin setting with the RegEx. Then people can adjust the RegEx however they want. They can include numbers, other symbols, and whatever. A disclaimer could be added saying: Only edit this if you know what you’re doing.
I don’t have a lot of experience yet creating settings for extensions. But, I’m thinking/hoping it’s relatively easy. I may try later this week. Or, if you or anyone else has time this would be the ultimate update.
We would no longer need to adjust the RegEx because people could do it themselves!
Great! This will help me to search and found a regexp.
I tested the 0.2.0 version and the conflict was still present.
With a form, I can try easily regex without searching in source code.
010101 yes this could be a definitive solution