Updating syndication extension attempt #3

010101

Alright ya’ll. No more games. Just please tell me, what does app()->url() need to be changed to? 😌

$view->head[] = '<link rel="alternate" type="application/atom+xml" title="' . $title . '" href="' . app()->url() . '/' . $url . '" />';

While I understand developers want people to learn for themselves, I am trying to bring the syndication extension back to life. Please. Help.

clarkwinkelmann

https://docs.flarum.org/extend/update-b14.html#application-and-container

The app helper now points to an instance of Illuminate\Container\Container, not Flarum\Foundation\Application. You might need to resolve things through the container before using them: for instance, app()->url() will no longer work; you'll need to resolve or inject an instance of Flarum\Foundation\Config and use that.

Ideally you would resolve the Config class from a constructor parameter but if you need a one-liner you can use resolve(Flarum\Foundation\Config::class)->url

But if you're building a URL to a page and not just the homepage, you can use the UrlGenerator https://docs.flarum.org/extend/routes.html#generating-urls

The sitemap extension might be a good comparison for this. But the source code requires a bit of looking around because the log has been split across many files https://github.com/FriendsOfFlarum/sitemap/blob/master/src/Resources/Discussion.php#L30

010101

clarkwinkelmann So, somewhat related and somewhat unrelated: why?

Why was this change made? Isn’t app()->url easier?

I know there are usually very important reasons (security or to make something else easier) to change how things need to be coded. But, from a regular person’s perspective... why?

This is actually my biggest fear with Flarum. The fact that I know major changes will continue... even down to the LESS/CSS. There’s no way I personally can keep up and build what I want to build. Sigh. 😔

I’m just thinking out loud though. I realize this unfortunately is normal. You have to always improve your product as times change. It’s just a little exhausting for a non-developer.

Justoverclock

010101 that's why this community exist...toghether we can learn, step by step...is not a fast process 🙂

clarkwinkelmann

010101 Why was this change made? Isn’t app()->url easier?

It's a result of us splitting the Application and Container. We previously followed Laravel's approach which has the application and container interfaces implemented by the same class, but moved away to a custom implementation where the application no longer implements Laravel interface. This required us to split the application and container object.

The Application::url() method was part of the Laravel Application interface and it was just filled with information from the config file. It didn't make sense to implement that method in the new non-Laravel application object since it could be retrieved from the config object already.

010101 To pull in the base url, is this the solution?

$url = $this->url->to('forum');

For future reference, UrlGenerator::to($frontend) returns an instance of https://github.com/flarum/core/blob/master/src/Http/RouteCollectionUrlGenerator.php which has multiple methods. You can do:

$this->url->to('forum')->base() // Will return the root without trailing slash
$this->url->to('forum')->path('path/to/somewhere') // Will return <root>/<path>
$this->url->to('forum')->route($name, $parameters) // Will generate a URL from a route name

010101

Justoverclock I think it’s more about job security. You don’t want to make things TOO easy. Then why have developers?

To pull in the base url, is this the solution?

$url = $this->url->to('forum');

Or, would I literally use:

resolve(Flarum\Foundation\Config::class)->url

luceos

010101 I think it’s more about job security. You don’t want to make things TOO easy.

We do not intentionally make things more complex, really. It saddens me to read this from you.

What we try to achieve is to make an extensible product, the app helper has been shipped by Laravel, not Flarum, and as such should not have a place in our code. The app function in Laravel resolves the Application, which we detached (for good reasons) from the ioc/bindings container. I am sorry you feel this way and I promise that we do not intentionally make changes to make extension development harder (look at all those extenders for instance).

🤗

010101

You know what? Maybe this just isn’t worth me trying to figure out. I will pay $100 to the developer who updates the syndication extension. Paypal, or any other major payment system will work. You have my word here.

And, you can trust my word because this is the Internet. No, actually you can trust my word because I highly respect this community. I would not publish this if I wasn’t serious.

IanM

010101 is it this one? https://github.com/AmauryCarrade/flarum-ext-syndication

010101

IanM yes

IanM

010101 Lemme take a look...

IanM

010101 Maintainer abandoned, right? So needs a full fork?

010101

IanM I’m serious. I will pay the $100 bounty. You just tell me how to pay it.

Oh and it can be released MIT. Of course. For others to enjoy.

010101

IanM Yeah. Unfortunately. I got it almost working I think. But, I’m just not good with url routes.

IanM

010101 no worries, on it now...

I might need a little guidance on the atom feeds themselves, never used them 🙈 but I'll certainly whip this code into 1.0 shape for ya!

010101

IanM If/when you do this. What’s the best way to compensate you? I don’t do this often. I don’t know the proper protocol.

010101

luceos Maybe it just comes down to the fact that I’m out of my realm. And so, if I need something, I need to pay for it. 😛

010101

clarkwinkelmann $this->url->to('forum')->base() // Will return the root without trailing slash
$this->url->to('forum')->path('path/to/somewhere') // Will return <root>/<path>
$this->url->to('forum')->route($name, $parameters) // Will generate a URL from a route name

This is really good information for future developers and novices.

For people searching: get base url - get forum url - get root path - route name

Maybe the above will help for anyone searching the forum.

IanM

010101 I'm on it now 😉

010101 What’s the best way to compensate you? I don’t do this often. I don’t know the proper protocol.

Let's see if we can get this working first, if I fail, then nothing, it's a learning excerise too 🙂

So far, so good:

010101

IanM Yes I got it to the point where everything will load and the feeds are in the <head>. But, then I still got some errors. That’s where I gave up.

I assume it’s all about routes? Because I got it to almost work, it just couldn’t find the feed. I don’t know though.

Justoverclock

yeah, is back to life ? 🙂

IanM

Justoverclock Almost 😉 IanM