$ 100 bounty - Fix Ads extension

xasharma

davwheat

Great extension bro, Loved it <3 ...... all ads are working great.

Me to i will ping you on Discord @davwheat

davwheat

MikeJones

Yeah of course -- I can confirm that it was me (MrJeeves#6969).

You should be able to double check via Mutual Servers and see I'm in the Flarum one as a core dev.

MikeJones

davwheat Published v0.0.6, which should be the final version before this goes properly live.

I just updated. I am not seeing anything in my left sidebar on desktop.

Also in the settings when the header for the sidebar says this:

Code for "davwheat.ads.lib.locations.sidebar" ad unit

All the other headings are easy readable.

davwheat

Braden That's not valid CSS, and that's not how you would show that. You'd want:

.davwheat-ad::before {
  display: block;
  content: "Advertisement";
  color: @muted-color;
}

MikeJones Try clearing your forum cache. I renamed some keys in the extension.

Edit: Actually, I did an oopsie. I tried to hide that ad on small screens, but ended up doing it the other way round.

davwheat

xasharma MikeJones

This should be fixed with 0.0.7, and the discussion sidebar ad unit is back, too.

Braden

trying to display the word, its not showing for me

using

.davwheat-ad .Post::before {
title: "Advertisements";
}

xasharma

davwheat
one more problem .... the left sidebar ad on small screen device replace itself at the top (google place the sidebar ad at the top in mobile phones)

xasharma

Walys yes i reported it xasharma and should be fixed in 0.0.9 davwheat

xasharma

davwheat

wow ! ... many different ad spaces 🙌

Walys

Hello,

@xasharma In your forum https://hacksnation.com/ stay now testing the update version for this plugins?

I retesting now in incognito mode without any cache and view other problem

In mobile when go with any tag or alls discussion, example this link: https://hacksnation.com/t/tutorials-methods
View Two ads in a row without any original text in the middle and this is not good.
Screenshoot:

In PC working well and the second ad appear under the left sidebar in good possition but when go to mobile navigator, this sidebar hides and the ads go up, and view two ads in a row.