$ 100 bounty - Fix Ads extension

MikeJones

Looks like in post is working for me :-)

One interesting behavior is what it counts as a "post" for the count. It looks liek it counts a reply box as a post:

I have my count set to 5 and as you can see the ad is after the reply box which seems like it just looks odd. and makes it hard to reply.

davwheat

MikeJones

That's a great spot. I'll try to fix that.

xasharma

davwheat

i like this ad ..... please don't remove it 😅 (give a option to turn on or off)

xasharma

davwheat

1 question are these between the post ads are reloading when we scroll ??

I mean between the post ads are different from other extensions like ads load faster than replies. ( i am surprised)

take a look at this video - https://youtu.be/cOEK82SBfw8

MikeJones

xasharma i like this ad ..... please don't remove it 😅 (give a option to turn on or off)

Hahaha, yea I think it looks messy. The Reply box should be the lowest thing on the discussion page in my opinion but I get why you like it as well :-)

xasharma

MikeJones

i want it to shift down a little bit instead of removing it

MikeJones

xasharma definitely needs a little padding or something if it stays

davwheat

xasharma

I think that's actually the footer ad rather than an ad appearing under the placeholder. The footer one is a bit glitchy on discussion pages.

Justoverclock

xasharma

try adding this into css

 @media (min-width: 700px) {
            .DiscussionPage-nav, .DiscussionPage-nav>ul {
                position: sticky;
                top: 80px;
            }
            .App {overflow-x: visible;}
            }
           
           .Post::before, .Post::after {content:none;}

xasharma

MikeJones

.davwheat-ad-footer{
    margin: 50px auto;
}

Screenshot -

xasharma

davwheat

nope i using <center> code </code> to align it in center ... if i don't this for header and footer ad it will be on the left side

And on mobile it looks great >

Darkle

davwheat Yeah is for this (Justoverclock ), in fact any footer is glitchy if the position sticky is not added to the nav.

davwheat

xasharma I'll try to make aligning and stuff part of the extension itself so you don't need to 🤞

Are you still having issues with between post ads?

xasharma

Justoverclock

worked 🔥

davwheat

Darkle That's something we plan to improve for v2. No more float in CSS! 💪

Justoverclock Thanks! I'll add something like that to the ext 😛

xasharma

davwheat

Nope, it's fine ..... can "login to see" will be fixed in upcoming updates?

davwheat

xasharma

What do you mean?

Justoverclock

@davwheat could you add a css class so we can customize the padding/margin/center?

davwheat

Justoverclock

There are several classes on the ads already: davwheat-ad, davwheat-ad-header, davwheat-ad-footer, davwheat-ad-between-posts, davwheat-ad-between-posts--after-placeholder, davwheat-ad-sidebar, etc

Released 0.0.4: https://github.com/davwheat/flarum-ext-ads/compare/0.0.3...0.0.4

Justoverclock

davwheat i don't know why but i can change the padding for ads between post, can u show please an example? i've used

.davwheat-ad-between-posts{
}

but no effect

xasharma

davwheat

xasharma correct .... i disabled login to see now its working

There is a extension named Login to see plus .... I have disabled the extension for the between the post ads

if i enable this it cause xasharma

davwheat

xasharma Justoverclock

Ok, I'll take a look at both of these after dinner.

davwheat

xasharma

I can't find any issues with that extension.

« Previous Page Next Page »