It looks like the issue could be that the table name isn't escaped in the SQL query? That would be odd because it looks like it's this migration https://github.com/flarum/flags/blob/master/migrations/2018_09_15_043621_add_flags_indices.php which uses the Laravel Schema builder so everything should be automatically escaped for the database engine.
I have never tried a database prefix with a dash in it.
clarkwinkelmann Should I try to get back to latest version of MySQL and remove the dash?
luceos
Something went wrong: SQLSTATE[HY000]: General error: 3750 Unable to create or change a table without a primary key, when the system variable 'sql_require_primary_key' is set. Add a primary key to the table or unset this variable to avoid this message. Note that tables without a primary key can cause performance problems in row-based replication, so please consult your DBA before changing this setting. (SQL: create tableyeshivaposts_likes(post_idint unsigned not null,user_idint unsigned not null) default character set utf8mb4 collate 'utf8mb4_unicode_ci')
I reinstalled Flarum completely idk anymore... mysql version is mysql Ver 14.14 Distrib 5.7.35, for Linux (x86_64) using EditLine wrapper
It seems that sql_require_primary_key needs to be disabled yet DigitalOcean forces it to be enabled. Anyway to bypass this?
Oze I've had this issue once before and had to contact them. Not sure though if that's the only way.
Is this a MySQL instance on a digital ocean droplet or their hosted MySQL?
Tried it all still no luck sadly :/
I have tried this this locally and can confirm dashes in the table prefix will prevent Flarum installation. I have created an issue for it here flarum/core3022 I recommend trying without a dash in the meantime. An underscore can be used instead.
The problem is with Blueprint::renameColumn in this migration https://github.com/flarum/flags/blob/master/migrations/2018_06_27_101500_change_flags_rename_time_to_created_at.php
I have tried to do the same with a base Laravel installation and a single migration file and I get the same error, so it's something with Laravel or DBAL.
I can't find any existing issue for this though. The closest I saw was this issue about issues with dashes in database names doctrine/dbal1735
I cannot find any description of what Laravel considers a valid database prefix. All examples I can find only ever use underscores. I wonder if the easiest solution wouldn't be to just disallow dashes in the prefix field during installation.
This is great thanks, but now the main issue has changed. I am using MYSQL hosted by DigitalOcean, and they force the sql_require_primary_key option for MYSQL. For some reason Flarum only adds primary keys AFTER the tables are added, or not at all, I am unsure. There must be a way to fix this, I am not that knowledgeable on this subject so dont know if this was done purposely, or this was just the way this was built.
Oze oh sorry I focused on the original issue and didn't even notice the latest message.
It seems like the way the migrations work Flarum will be unable to create composite primary keys in this circumstance. For reference, the migration in question
Creating the database locally and then copying it over would work around that issue. But the same problem will likely happen again when you install extensions 
I found this SO question https://stackoverflow.com/q/62418099/3133038 and this Laravel issue laravel/framework33238 . From the comments in those two threads it seems like people were able to simply ask DigitalOcean to disable the setting on their instance.
Laravel doesn't consider it a bug and the various workarounds described in the comments would require rewriting a large part of Flarum's migrations so I don't think we would add a special case to handle this.
clarkwinkelmann I See. Thanks for all the info, I will contact DigitalOcean and hope for the best. Thanks a lot!
So DigitalOcean fixed my DB and now I get the error in the image below. I simply deleted where my Flarum was /var/www/flarum, and I installed via my fixed DigitalOcean DB. Any ideas haha...
Is it possible an extension is causing this? How can I delete all extensions from previous builds?
Getting the same error on Digital Ocean with a fresh install.
Something went wrong: SQLSTATE[HY000]: General error: 3750 Unable to create or change a table without a primary key, when the system variable 'sql_require_primary_key' is set. Add a primary key to the table or unset this variable to avoid this message. Note that tables without a primary key can cause performance problems in row-based replication, so please consult your DBA before changing this setting. (SQL: create table
discussions_tags(discussion_idint unsigned not null,tag_idint unsigned not null) default character set utf8mb4 collate 'utf8mb4_unicode_ci' engine = InnoDB)
Why not execute this in the SQL?:
SET SESSION sql_require_primary_key = 0;
Apologies if this is naive, I'm not terribly familiar with mysql, I've been on a postgres stack for years at this point
Apparently there's a programmatic fix as of early 2022:
https://stackoverflow.com/a/72438019
Added $pdo->exec('SET SESSION sql_require_primary_key=0;'); to \vendor\flarum\core\src\Install\Steps\ConnectToDatabase.php right after $pdo =... and I was able to install the db with php flarum install
For Azure there's also an option sql_generate_invisible_primary_key which needs to be set to OFF as well as sql_require_primary_key under Settings > Server Parameters
Might need to recreate the db as well.
️
