Restricted Tag visible for everyone

D-W

I don't know where to start...

Flarum 1.0.4
PHP 7.4.19

I'm facing (i believe this is) a bug that Tag is visible to everybody while it is restricted by groups.

One image is worth thousand words...
On the left when not logged in - On the right permissions settings
Image

Edit: had to set link as its not read as img

Braden

D-W Go to tag extension and disable it, then clear cache.

Then enable the tag extension again.

Go to your flarum frontpage where all discussion with all tags and reload or (force refresh F5).

Please report back back results 🥰

xasharma

D-W

1 question Is "internal" is a subtag of any other tag?

jordanjay29

D-W I can't replicate this on our demo site.

Here's my setup and results.

If you get the same result on our demo site, then can you paste the results of php flarum info in here? It's likely caused by some other factor, perhaps another extension, of your site that causes this behavior.

jordanjay29

D-W this is fixed and will be in the next release of Flarum.

D-W

Braden Thanks for quick reply. Tried what you said, then in incognito, then in MS edge. Nothing changed 🙁

Braden

D-W In my case, the last extension enabled was affecting tags extension. Try last step, disable and re-enable Statistics extension

D-W

Braden Unfortunatelly didn't helped. However now I saw additional bugs like mess in order of Tag "menu" elements + sometimes when visiting as a guest 'Internal' tag I see 'The page you requested could not be found.' but after few clicks Flarum opens it (from left side menu) and shows theres nothing in it (this is as expected but dont get why tag is visible this makes no sense at all).

Ah and plus - under '/tags' adress it is also listed. I'm kinda wtf ? 😧

P.S. I just recalled that I though it was Categories extension fault but seems that this indeed happens no matter what.

Braden

D-W Please re-upload the above image to a different site ibb is not accessable

D-W

xasharma

Yes it is. As on screen above 'Development' tag is main tag and 'Internal' is a sub-tag.

D-W

Braden

Now better? https://postimg.cc/0K6WvcgZ

Braden

D-W Could you have tried the main Tag Development, instead of sub tag internal, what could it have result with restriction? does it work or not?

xasharma

D-W

yes, buddy ... You have to hide main, because you can't use internal without development.
I think so.

D-W

Braden xasharma I can't hide whole tag as have other tags there.

jordanjay29 discussions are hidden (visible to permitted groups) but tag stays visible - so why to keep tag if its content should be hidden from typical members ?

I just checked demo site - and i see internal tag here without being logged. https://postimg.cc/WqvVfPmV

@jordanjay29 By this ocassion would you be so kind to try on demo site - https://discuss.flarum.org/d/23184-flarum-categories ?? As this is also messing with menu elements giving weird results in my case - i believe this is connected with this unexpected behavior -> https://discuss.flarum.org/d/23184-flarum-categories/194

jordanjay29

D-W Okay, now that I see your screenshot here, I have a better understanding of what you mean.

It looks like the tag itself is visible, even though the discussions in it are hidden. And it also appears that the tag is inaccessible by direct URL, only through the SPA.

Looks like there's no issue for this yet, so I'll add one in. Thanks for the report!

D-W

jordanjay29 I know this isn't vanilla Flarum but I believe that bug with "top bar" is also related to 1.0.4 not the extension itself - https://prnt.sc/1d1vf5a

jordanjay29

D-W That I can't say, I haven't played with Categories as much. It could be worth bringing this issue back to the extension author so they can follow it and see how it interacts with their extension. Given that it's Sasha, I believe he's already aware of it though, but it never hurts to have the reminder.

Issue created: flarum/core3050