Fof Best answer error after upgrade

Justoverclock

guys, after composer update, migrate and clear cache i can't access the forum anymore

(index):284 Uncaught TypeError: Cannot read property 'prototype' of undefined
    at index.js:26
    at Application.js:169
    at Array.forEach (<anonymous>)
    at e.boot (Application.js:169)
    at (index):279
(anonymous)	@	index.js:26
(anonymous)	@	Application.js:169
e.boot	@	Application.js:169
(anonymous)	@	(index):279
forum.js?v=2dec8046:538 Uncaught TypeError: Cannot read property 'attribute' of null
    at Object.success (forum.js?v=2dec8046:538)
    at c (jquery.js:3500)
    at Object.fireWith [as resolveWith] (jquery.js:3630)
    at S (jquery.js:9796)
    at HTMLScriptElement.n (jquery.js:10180)
    at HTMLScriptElement.dispatch (jquery.js:5430)
    at HTMLScriptElement.v.handle (jquery.js:5234)

Flarum core 1.0.4
PHP version: 7.4.23
Loaded extensions: Core, date, libxml, openssl, pcre, sqlite3, zlib, bcmath, bz2, calendar, ctype, curl, dba, dom, enchant, hash, fileinfo, filter, ftp, gd, gettext, gmp, SPL, iconv, session, intl, json, mbstring, standard, mysqlnd, pcntl, mysqli, PDO, pdo_mysql, pdo_pgsql, pdo_sqlite, pgsql, Phar, posix, pspell, readline, Reflection, imap, shmop, SimpleXML, soap, sockets, sodium, exif, sysvmsg, sysvsem, tidy, tokenizer, xml, xmlreader, xmlrpc, xmlwriter, xsl, zip, memcached, Zend OPcache
+-----------------------------------+---------+--------+
| Flarum Extensions                 |         |        |
+-----------------------------------+---------+--------+
| ID                                | Version | Commit |
+-----------------------------------+---------+--------+
| afrux-forum-widgets-core          | v0.1.5  |        |
| flarum-likes                      | v1.0.0  |        |
| flarum-markdown                   | v1.0.1  |        |
| flarum-suspend                    | v1.0.0  |        |
| flarum-flags                      | v1.0.0  |        |
| justoverclock-hot-discussions     | 0.1.0   |        |
| justoverclock-last-users-posts    | 0.1.4   |        |
| miniflar-top-like-givers-widget   | 0.1.0   |        |
| justoverclock-last-tweet          | 0.1.1   |        |
| malago-achievements               | 0.3.1   |        |
| afrux-online-users-widget         | v0.1.5  |        |
| flarum-lang-italian               | 1.0.29  |        |
| justoverclock-visitorstat         | 0.2.0   |        |
| justoverclock-contactme           | 0.2.0   |        |
| askvortsov-checklist              | v1.3.1  |        |
| flarum-pusher                     | v1.0.0  |        |
| flarumite-simple-discussion-views | 1.0.3   |        |
| fof-best-answer                   | 1.1.4   |        |
| phenomlab-fancybox-wrapper        | 0.8     |        |
| fof-user-bio                      | 1.0.0   |        |
| fof-socialprofile                 | 1.1.0   |        |
| fof-share-social                  | 1.0.0   |        |
| fof-analytics                     | 1.0.0   |        |
| fof-oauth                         | 1.0.2   |        |
| fof-formatting                    | 1.0.1   |        |
| flarum-tags                       | v1.0.3  |        |
| flarum-subscriptions              | v1.0.0  |        |
| flarum-sticky                     | v1.0.0  |        |
| flarum-statistics                 | v1.0.0  |        |
| flarum-mentions                   | v1.0.0  |        |
| flarum-lock                       | v1.0.0  |        |
| flarum-lang-english               | v1.0.0  |        |
| flarum-emoji                      | v1.0.0  |        |
| flarum-bbcode                     | v1.0.0  |        |
| flarum-approval                   | v1.0.0  |        |
| fof-links                         | 1.0.0   |        |
| justoverclock-guestengagement     | 1.0.2   |        |
| justoverclock-keywords            | 1.9.2   |        |
| justoverclock-dontgoaway          | 0.2.5   |        |
| ralkage-hcaptcha                  | 1.0.0   |        |
| afrux-forum-stats-widget          | v0.1.0  |        |
| afrux-top-posters-widget          | v0.1.3  |        |
| justoverclock-welcomebox          | 1.2.9   |        |
| afrux-news-widget                 | v0.1.0  |        |
| justoverclock-discussion-info     | 0.1.1   |        |

IanM

Justoverclock what got updated during composer update?

Justoverclock

IanM

Lock file operations: 0 installs, 45 updates, 1 removal
  - Removing fof/components (1.0.0)
  - Upgrading afrux/online-users-widget (v0.1.4 => v0.1.5)
  - Upgrading afrux/top-posters-widget (v0.1.2 => v0.1.3)
  - Upgrading brick/math (0.9.2 => 0.9.3)
  - Upgrading components/font-awesome (5.15.3 => 5.15.4)
  - Upgrading filp/whoops (2.14.0 => 2.14.1)
  - Upgrading fof/best-answer (1.0.1 => 1.1.4)
  - Upgrading fof/formatting (1.0.0 => 1.0.1)
  - Upgrading fof/oauth (1.0.1 => 1.0.2)
  - Upgrading illuminate/bus (v8.54.0 => v8.60.0)
  - Upgrading illuminate/cache (v8.54.0 => v8.60.0)
  - Upgrading illuminate/collections (v8.54.0 => v8.60.0)
  - Upgrading illuminate/config (v8.54.0 => v8.60.0)
  - Upgrading illuminate/console (v8.54.0 => v8.60.0)
  - Upgrading illuminate/container (v8.54.0 => v8.60.0)
  - Upgrading illuminate/contracts (v8.54.0 => v8.60.0)
  - Upgrading illuminate/database (v8.54.0 => v8.60.0)
  - Upgrading illuminate/events (v8.54.0 => v8.60.0)
  - Upgrading illuminate/filesystem (v8.54.0 => v8.60.0)
  - Upgrading illuminate/hashing (v8.54.0 => v8.60.0)
  - Upgrading illuminate/macroable (v8.54.0 => v8.60.0)
  - Upgrading illuminate/mail (v8.54.0 => v8.60.0)
  - Upgrading illuminate/pipeline (v8.54.0 => v8.60.0)
  - Upgrading illuminate/queue (v8.54.0 => v8.60.0)
  - Upgrading illuminate/session (v8.54.0 => v8.60.0)
  - Upgrading illuminate/support (v8.54.0 => v8.60.0)
  - Upgrading illuminate/translation (v8.54.0 => v8.60.0)
  - Upgrading illuminate/validation (v8.54.0 => v8.60.0)
  - Upgrading illuminate/view (v8.54.0 => v8.60.0)
  - Upgrading justoverclock/flarum-ext-guestengagement (1.0.1 => 1.0.2)
  - Upgrading laminas/laminas-escaper (2.8.0 => 2.9.0)
  - Upgrading laminas/laminas-zendframework-bridge (1.3.0 => 1.4.0)
  - Upgrading league/commonmark (2.0.1 => 2.0.2)
  - Upgrading league/config (v1.1.0 => v1.1.1)
  - Upgrading league/flysystem (1.1.4 => 1.1.5)
  - Upgrading league/oauth1-client (1.9.2 => v1.10.0)
  - Upgrading nesbot/carbon (2.51.1 => 2.53.1)
  - Upgrading nette/utils (v3.2.2 => v3.2.3)
  - Upgrading symfony/console (v5.3.6 => v5.3.7)
  - Upgrading symfony/event-dispatcher (v5.3.4 => v5.3.7)
  - Upgrading symfony/finder (v5.3.4 => v5.3.7)
  - Upgrading symfony/http-foundation (v5.3.6 => v5.3.7)
  - Upgrading symfony/mime (v5.3.4 => v5.3.7)
  - Upgrading symfony/process (v5.3.4 => v5.3.7)
  - Upgrading symfony/string (v5.3.3 => v5.3.7)
  - Upgrading symfony/translation (v5.3.4 => v5.3.7)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 45 updates, 1 removal
  - Downloading symfony/translation (v5.3.7)
  - Downloading symfony/mime (v5.3.7)
  - Downloading symfony/event-dispatcher (v5.3.7)
  - Downloading symfony/string (v5.3.7)
  - Downloading symfony/console (v5.3.7)
  - Downloading nesbot/carbon (2.53.1)
  - Downloading league/flysystem (1.1.5)
  - Downloading laminas/laminas-zendframework-bridge (1.4.0)
  - Downloading laminas/laminas-escaper (2.9.0)
  - Downloading illuminate/contracts (v8.60.0)
  - Downloading illuminate/collections (v8.60.0)
  - Downloading illuminate/support (v8.60.0)
  - Downloading symfony/finder (v5.3.7)
  - Downloading illuminate/bus (v8.60.0)
  - Downloading illuminate/events (v8.60.0)
  - Downloading illuminate/view (v8.60.0)
  - Downloading symfony/http-foundation (v5.3.7)
  - Downloading illuminate/validation (v8.60.0)
  - Downloading symfony/process (v5.3.7)
  - Downloading brick/math (0.9.3)
  - Downloading illuminate/database (v8.60.0)
  - Downloading illuminate/console (v8.60.0)
  - Downloading illuminate/queue (v8.60.0)
  - Downloading nette/utils (v3.2.3)
  - Downloading league/config (v1.1.1)
  - Downloading league/commonmark (2.0.2)
  - Downloading illuminate/mail (v8.60.0)
  - Downloading illuminate/cache (v8.60.0)
  - Downloading filp/whoops (2.14.1)
  - Downloading components/font-awesome (5.15.4)
  - Downloading afrux/top-posters-widget (v0.1.3)
  - Downloading afrux/online-users-widget (v0.1.5)
  - Downloading fof/best-answer (1.1.4)
  - Downloading fof/formatting (1.0.1)
  - Downloading league/oauth1-client (v1.10.0)
  - Downloading fof/oauth (1.0.2)
  - Downloading justoverclock/flarum-ext-guestengagement (1.0.2)
  - Removing fof/components (1.0.0)
  - Upgrading symfony/translation (v5.3.4 => v5.3.7): Extracting archive
  - Upgrading symfony/mime (v5.3.4 => v5.3.7): Extracting archive
  - Upgrading symfony/event-dispatcher (v5.3.4 => v5.3.7): Extracting archive
  - Upgrading symfony/string (v5.3.3 => v5.3.7): Extracting archive
  - Upgrading symfony/console (v5.3.6 => v5.3.7): Extracting archive
  - Upgrading nesbot/carbon (2.51.1 => 2.53.1): Extracting archive
  - Upgrading league/flysystem (1.1.4 => 1.1.5): Extracting archive
  - Upgrading laminas/laminas-zendframework-bridge (1.3.0 => 1.4.0): Extracting archive
  - Upgrading laminas/laminas-escaper (2.8.0 => 2.9.0): Extracting archive
  - Upgrading illuminate/macroable (v8.54.0 => v8.60.0): Extracting archive
  - Upgrading illuminate/contracts (v8.54.0 => v8.60.0): Extracting archive
  - Upgrading illuminate/collections (v8.54.0 => v8.60.0): Extracting archive
  - Upgrading illuminate/support (v8.54.0 => v8.60.0): Extracting archive
  - Upgrading symfony/finder (v5.3.4 => v5.3.7): Extracting archive
  - Upgrading illuminate/filesystem (v8.54.0 => v8.60.0): Extracting archive
  - Upgrading illuminate/container (v8.54.0 => v8.60.0): Extracting archive
  - Upgrading illuminate/pipeline (v8.54.0 => v8.60.0): Extracting archive
  - Upgrading illuminate/bus (v8.54.0 => v8.60.0): Extracting archive
  - Upgrading illuminate/events (v8.54.0 => v8.60.0): Extracting archive
  - Upgrading illuminate/view (v8.54.0 => v8.60.0): Extracting archive
  - Upgrading symfony/http-foundation (v5.3.6 => v5.3.7): Extracting archive
  - Upgrading illuminate/translation (v8.54.0 => v8.60.0): Extracting archive
  - Upgrading illuminate/validation (v8.54.0 => v8.60.0): Extracting archive
  - Upgrading illuminate/session (v8.54.0 => v8.60.0): Extracting archive
  - Upgrading symfony/process (v5.3.4 => v5.3.7): Extracting archive
  - Upgrading brick/math (0.9.2 => 0.9.3): Extracting archive
  - Upgrading illuminate/database (v8.54.0 => v8.60.0): Extracting archive
  - Upgrading illuminate/console (v8.54.0 => v8.60.0): Extracting archive
  - Upgrading illuminate/queue (v8.54.0 => v8.60.0): Extracting archive
  - Upgrading nette/utils (v3.2.2 => v3.2.3): Extracting archive
  - Upgrading league/config (v1.1.0 => v1.1.1): Extracting archive
  - Upgrading league/commonmark (2.0.1 => 2.0.2): Extracting archive
  - Upgrading illuminate/mail (v8.54.0 => v8.60.0): Extracting archive
  - Upgrading illuminate/hashing (v8.54.0 => v8.60.0): Extracting archive
  - Upgrading illuminate/config (v8.54.0 => v8.60.0): Extracting archive
  - Upgrading illuminate/cache (v8.54.0 => v8.60.0): Extracting archive
  - Upgrading filp/whoops (2.14.0 => 2.14.1): Extracting archive
  - Upgrading components/font-awesome (5.15.3 => 5.15.4): Extracting archive
  - Upgrading afrux/top-posters-widget (v0.1.2 => v0.1.3): Extracting archive
  - Upgrading afrux/online-users-widget (v0.1.4 => v0.1.5): Extracting archive
  - Upgrading fof/best-answer (1.0.1 => 1.1.4): Extracting archive
  - Upgrading fof/formatting (1.0.0 => 1.0.1): Extracting archive
  - Upgrading league/oauth1-client (1.9.2 => v1.10.0): Extracting archive
  - Upgrading fof/oauth (1.0.1 => 1.0.2): Extracting archive
  - Upgrading justoverclock/flarum-ext-guestengagement (1.0.1 => 1.0.2): Extracting archive

the only things with updates are FOF extension

i will restore a backup...

IanM

Justoverclock looking at that, it could by anything 🙁

The only thing I can suggest for the moment is update one at a time and see where the issue begins?

Braden

Justoverclock haha buddy i almost thought someone else was using your profile picture, justoverclock cant not be defeated with errors, please 🤣

Justoverclock

IanM it happen after fof best answer (and i stopped after that, and reverted to 1.0.1) and it works

IanM

Justoverclock 🤔 1.0.1 => 1.1.4, right, let me test this locally...

IanM

Justoverclock I can reproduce this, but a disable/re-enable of fof/best-answer seems to resolve it.

The issue appears to be load order related (we now rely on JS exports from flarum/tags)

I'll continue to look into this, just wanted to give you an update so far 🙂

Hari

Justoverclock I also updated the best answer, I am not experiencing any issues so far. Does this only happen to devs? 😂

Justoverclock

IanM thank you ianm, glad that we find the culprit 🙂

Justoverclock

Hari 😆 i hope not....

depends on the order/amount of installed extension, so it can be randomly affect some forums

meetdilip

Braden haha buddy i almost thought someone else was using your profile picture

For a moment, the same here 😆

Braden

meetdilip he can be that guy, a newbie can get along with very easily, interesting and funny always

meetdilip

I have only praises for my fellow team member 🙂