Collapsible Posts

clarkwinkelmann

Hari can we un-collapse a collapsed post?

yes absolutely!

I'll add some screenshots if I get the opportunity, but the YouTube videos (particularly the last one) give a good idea of the UX.

When you click on the collapse button in the post dropdown actions, you can choose between reasons or "not collapsed".

Greenreader9

Can community members hide posts?

Wadera

You can set permissions for any group. You can keep it for Admin only. You can give ability to Mods only or your can set any trusted group or give access to do so for all.

Wadera

Bugs found:

Question: Can we collapse posts again after clicking Load more button? Or we need to reload page?

clarkwinkelmann

Wadera When latest post in discussion is collapsed - flarum won't mark discussion as readed.

I'll check that out. This might be tricky. Flarum might have the same issue if the last post of the discussion is deleted or under approval.

Wadera there is no counter of how many posts are collapsed

There should be a counter.

If you provided a custom reason message, you can include {count} in your text to be replaced with the count value. If you don't provide a custom reason, the default message should include the count automatically.

If that doesn't help, can you share a screenshot?

I'm not sure I have actually provided documentation for this. I'll add it to the README if it's missing.

Wadera Can we collapse posts again after clicking Load more button

No, I have intentionally made this one way only, like GitHub implemented. While it would theoretically be possible to hide the posts back, I have no idea how to design a UI for that without making the interface more cluttered than it needs to be. There would need to be somehow a single button somewhere, so I would probably have to keep the collapsed post announcement block visible and change its content, but that's tricky because the announcement block is the post itself so it has to be switched to the real post when expanded. I don't think it would make much sense to be able to visually collapse posts back one by one.

Wadera

clarkwinkelmann If you provided a custom reason message, you can include {count} in your text to be replaced with the count value.

Thank you! That solve issue with missing counter.

Wadera

When we collapse few posts one after another with different reasons - expanding is broken.

Example situation - 5 collapsed posts one after another with different reasons:

Offtop
NSFW
NFSW
Incorrect information
Offtop

In result flarum displays:
"5 Offtop posts collapsed"
After expanding - only first one is displayed and there is no way to see 4 remainings.

Only way to fix it is "uncollapse" first one by mod, and then counter changing to: "4 NSFW posts collapsed", which will allow to expand poststs 2 and 3 leaving 4 and 5 still unavailable etc.

clarkwinkelmann

Wadera I'll check that out. Admittedly, I have not done many tests with multiple reasons.

phloo

Probably a stupid question but how can I allow all users to collapse their own posts but no others?

Thanks for the extension. Very helpful

clarkwinkelmann

phloo if you don't find the permission for it, it's maybe not implemented. It's been a while since I worked on this extension so I don't remember, I would have to review the code

phloo

@clarkwinkelmann there is one option but I assume its for marking every post as offtopic.
I cannot test it cause I only have an admin account. Guess there should be a second option to collapse "own posts".

clarkwinkelmann

phloo the challenge is that since you can configure multiple collapse reasons, you might need to only allow self-setting specific reasons. Then you might want to allow of not allow changing or removing the collapse. And finally since the original use case was for marking groups of off-topic content, it wouldn't be very useful if you cannot also hide the content of other users that must be collapsed together with your own post.

In conclusion that wasn't part of the original use case. But this could certainly be added as a sponsored feature.

phloo

clarkwinkelmann I understand. Thanks for the explanation.

In our old forum, we had a custom function to mark an own reply as "irrelevant/offtopic".
That's where my request comes from. It's nothing we necessarily need - it's more of a "fun feature".
Mods and admins could always mark a reply as offtopic but yeah, we do not have mods anymore (little community).

clarkwinkelmann

Version 1.0.1

Fixed compatibility with Flarum 1.8+ when Mentions or Likes are enabled

phloo

My problem: I marked several (following) posts as offtopic.
It says "6 posts were marked ...", when I click the button it loads the first one and then an error message without any details pops up. The rest of the posts are not visible/missing. So I am even unable to remove the collapse setting or view them when they should be loaded.

clarkwinkelmann

phloo can you try to obtain an error message? https://docs.flarum.org/troubleshoot

If the frontend breaks, it might be a javascript error. Take a look at the browser javascript console.

In any case, verify if there's anything in the PHP log.

You could also try again with debug mode enabled to see if anything else is displayed in the frontend.

If you need to restore some posts urgently you can edit the value in the collapse related columns on the posts table in the database. Set to null to un-collapse.

phloo

clarkwinkelmann
here is the console error (500):

XHRGET
https://XXXX.XXX/api/collapsed-posts?filter[discussion]=849&page[after]=22
[HTTP/2 500  284ms]

And here is the PHP error log

[22-Feb-2024 13:12:27] WARNING: [pool www] child 1746 said into stderr: "[22-Feb-2024 12:12:27 UTC] PHP Warning:  foreach() argument must be of type array|object, null given in /XXX/html/vendor/clarkwinkelmann/flarum-ext-collapsible-posts/src/Visibility/PostScope.php on line 14"
[22-Feb-2024 13:12:27] WARNING: [pool www] child 1746 said into stderr: "[22-Feb-2024 12:12:27 UTC] PHP Warning:  foreach() argument must be of type array|object, null given in /XXX/html/vendor/clarkwinkelmann/flarum-ext-collapsible-posts/src/Visibility/PostScope.php on line 14"
[22-Feb-2024 13:12:27] WARNING: [pool www] child 1746 said into stderr: "[22-Feb-2024 12:12:27 UTC] PHP Warning:  foreach() argument must be of type array|object, null given in /XXX/html/vendor/clarkwinkelmann/flarum-ext-collapsible-posts/src/Visibility/PostScope.php on line 14"
[22-Feb-2024 13:12:28] WARNING: [pool www] child 31857 said into stderr: "[22-Feb-2024 12:12:28 UTC] PHP Warning:  foreach() argument must be of type array|object, null given in/XXX/html/vendor/clarkwinkelmann/flarum-ext-collapsible-posts/src/Visibility/PostScope.php on line 14"
[22-Feb-2024 13:12:28] WARNING: [pool www] child 31857 said into stderr: "[22-Feb-2024 12:12:28 UTC] PHP Warning:  foreach() argument must be of type array|object, null given in /XXX/html/vendor/clarkwinkelmann/flarum-ext-collapsible-posts/src/Visibility/PostScope.php on line 14

clarkwinkelmann

phloo thanks, can you share your php flarum info as well?

It seems odd that the code could receive an invalid value at that particular place. Maybe the Scope is being invoked elsewhere in a context I didn't expect. If I can't figure it out I'll add a proper check and error in the code so you can get a backtrace if you try again.

maisen20

phloo

I had to adjust the following for class PostScope because I always had messages in the logs:

class PostScope
{
    public function __invoke(User $actor, Builder $query)
    {   
        $getQuery_columns = $query->getQuery()->columns;
        
        if($getQuery_columns) {
            foreach ($getQuery_columns as $column) {
                // This is a way for us to bypass the logic from below
                // By adding this column to the SELECT clause, it will have no impact on the output, but we can read it here
                if ($column instanceof Expression && $column->getValue() === "'1' as collapsed_include_hidden") {
                    return;
                }
            }
        }
...

Log warning:

PHP Warning: foreach() argument must be of type array|object, null given in .../vendor/clarkwinkelmann/flarum-ext-collapsible-posts/src/Visibility/PostScope.php on line 14

phloo

clarkwinkelmann

Flarum core: 1.8.5
PHP version: 8.1.27
MySQL version: 10.6.17-MariaDB
Loaded extensions: Core, date, libxml, openssl, pcre, zlib, filter, hash, json, pcntl, readline, Reflection, SPL, session, standard, restrictdocroot, bcmath, bz2, calendar, ctype, curl, dba, dom, mbstring, fileinfo, ftp, gd, gettext, gmp, iconv, imap, intl, ldap, exif, mysqlnd, PDO, pgsql, Phar, posix, shmop, SimpleXML, soap, sockets, sodium, sqlite3, sysvmsg, sysvsem, sysvshm, tidy, tokenizer, xml, xmlwriter, xsl, mcrypt, mysqli, pdo_mysql, pdo_pgsql, pdo_sqlite, xmlreader, xmlrpc, zip, amqp, apcu, decimal, gnupg, igbinary, imagick, mailparse, msgpack, yaml, mongodb, redis, Zend OPcache
+--------------------------------------+------------+------------------------------------------+
| Flarum Extensions | | |
+--------------------------------------+------------+------------------------------------------+
| ID | Version | Commit |
+--------------------------------------+------------+------------------------------------------+
| flarum-flags | v1.8.0 | |
| flarum-approval | v1.8.1 | |
| flarum-tags | v1.8.0 | |
| flarum-suspend | v1.8.1 | |
| flarum-markdown | v1.8.0 | |
| fof-byobu | 1.3.5 | |
| flarum-mentions | v1.8.3 | |
| flarum-subscriptions | v1.8.0 | |
| flarum-likes | v1.8.0 | |
| therealsujitk-gifs | v4.1.1 | |
| matteocontrini-imgur-upload | v3.9.1 | |
| ianm-log-viewer | 0.1.1 | |
| fof-user-directory | 1.3.3 | |
| fof-user-bio | 1.3.2 | |
| fof-terms | 1.3.0 | |
| fof-subscribed | 1.1.4 | |
| fof-split | 1.1.1 | |
| fof-reactions | 1.4.0 | |
| fof-polls | 2.1.2 | |
| fof-pages | 1.0.8 | |
| fof-nightmode | 1.5.3 | |
| fof-merge-discussions | 1.4.1 | |
| fof-linguist | 1.1.2 | |
| fof-ignore-users | 1.2.1 | |
| fof-formatting | 1.0.3 | |
| fof-follow-tags | 1.2.2 | a4b36e0c056439b2784b026b5570c2e828924f91 |
| fof-doorman | 1.1.4 | |
| fof-bbcode-details | 1.1.2 | |
| fof-anti-spam | 1.1.2 | |
| flarum-sticky | v1.8.0 | |
| flarum-statistics | v1.8.0 | |
| flarum-pusher | v1.8.0 | |
| flarum-lock | v1.8.0 | |
| flarum-lang-german | 1.8.3 | |
| flarum-lang-english | v1.8.0 | |
| flarum-bbcode | v1.8.0 | |
| datlechin-add-like-controls | v1.0.6 | |
| clarkwinkelmann-selective-mediaembed | 1.0.1 | |
| clarkwinkelmann-post-bookmarks | 1.0.0 | |
| clarkwinkelmann-likes-received | 1.0.2 | |
| clarkwinkelmann-collapsible-posts | 1.0.0 | |
| clarkwinkelmann-author-change | 1.0.3 | |
| cadiducho-bbcode | 1.1 | |
+--------------------------------------+------------+------------------------------------------+
Base URL: https://XXX.XXX
Installation path: /XXX/html
Queue driver: sync
Session driver: file
Scheduler status: Aktiv
Mail driver: smtp
Debug mode: off

edit: just updated to the latest version and the error is gone 🙂
clarkwinkelmann/flarum-ext-collapsible-posts 1.0.0 1.0.1 Collapse unimportant posts

clarkwinkelmann

phloo edit: just updated to the latest version and the error is gone

ah, so it might not have been the warning from the log after all. I still need to fix that properly at some point.

Boss81 can you also look at your log files and browser console for any hint, and include your php flarum info output? Make sure you are on the latest version of both Flarum and my extension.

Boss81

Unfortunately, it also gives me an error. I collapsed the post and it completely disappeared. Can't even open it.