Birthdays

Litalino

datlechin
I edited the AddBirthdayValidation.php file and it works fine with the "required" registration part.

public function __invoke(UserValidator $flarumValidator, Validator $validator): void
    {
        $rules = $validator->getRules();

        $isRequired = $this->settings->get('datlechin-birthdays.required')
            && $this->settings->get('datlechin-birthdays.set_on_registration');

        $rules['birthday'] = [
            'nullable',
            Rule::requiredIf($isRequired && ! $flarumValidator->getUser()),
            $set_isRequired,
            'date_format:Y-m-d',
            'before:today',
            function ($attribute, $value, $fail) {
                if ($value) {
                    $birthday = new DateTime($value);
                    $now = new DateTime();
                    $diff = $now->diff($birthday);
                    if ($diff->y <= (int) $this->settings->get('datlechin-birthdays.min_age')) {
                        $fail($this->translator->trans('datlechin-birthdays.api.invalid_age_message', [
                            'minAge' => (int) $this->settings->get('datlechin-birthdays.min_age')
                        ]));
                    } else if ($diff->y > 100) {
                        $fail($this->translator->trans('datlechin-birthdays.api.invalid_dob_message'));
                    }
                }
            },
        ];

        $validator->setRules($rules);
    }

FIX:

public function __invoke(UserValidator $flarumValidator, Validator $validator): void
    {
        $rules = $validator->getRules();

        $isRequired = $this->settings->get('datlechin-birthdays.required')
            && $this->settings->get('datlechin-birthdays.set_on_registration');

        if ($isRequired  && ! $flarumValidator->getUser()) {
            $set_isRequired = 'required';
        } else {
            $set_isRequired = 'nullable';
        }

        $rules['birthday'] = [
            //'nullable',
            //Rule::requiredIf($isRequired && ! $flarumValidator->getUser()),
            $set_isRequired,
            'date_format:Y-m-d',
            'before:today',
            function ($attribute, $value, $fail) {
                if ($value) {
                    $birthday = new DateTime($value);
                    $now = new DateTime();
                    $diff = $now->diff($birthday);
                    if ($diff->y <= (int) $this->settings->get('datlechin-birthdays.min_age')) {
                        $fail($this->translator->trans('datlechin-birthdays.api.invalid_age_message', [
                            'minAge' => (int) $this->settings->get('datlechin-birthdays.min_age')
                        ]));
                    } else if ($diff->y > 100) {
                        $fail($this->translator->trans('datlechin-birthdays.api.invalid_dob_message'));
                    }
                }
            },
        ];

        $validator->setRules($rules);
    }

DEMO TEST: https://flarum.khatvongsong.vn/

DISABLE: Required entering birthdays

B1-

B2-

ENALBLE: Required entering birthdays

B3-

joanaranda

Is the name of the "Birthday" field really embedded as a text string that can be localized? In my setup, it always appears in English:

In case it is not going to be fixed, is there any hack that I can do? I cannot translate it either through Weblate or FoF Linguist.

Boss81

joanaranda

I also have this one problem, everything else works fine.
Do you have a solution for this @datlechin ?

clarkwinkelmann

The placeholder text on the sign up modal appears to be hard-coded so cannot be translated. This will require a change by the extension author datlechin/flarum-birthdaysblob/6a2dff0601eb2a391180bbd7a7ab6c420c2fff4e/js/src/forum/index.js#L125

Boss81

clarkwinkelmann

I trust that @datlechin can help with the solution.

joanaranda

Boss81 - Right, let's hope that @datlechin can work on it soon. And thank you, @clarkwinkelmann, to check where the issue was.

datlechin

I will fix in end of week

Boss81

datlechin

Thanks, great.

joanaranda

datlechin - One zillion thanks! 👏👏👏

datlechin

V2.1.0

What's Changed

make placeholder text of date of birth field on registration modal translatable
allow user to display birth-year only by @pplulee in datlechin/flarum-birthdays18
Fixed Double click when disable year
Improve validation rules

Full Changelog: datlechin/flarum-birthdaysv2.0.1 → v2.1.0

Boss81

datlechin

I tried to translate it in vain, but unfortunately something is wrong. You can see the error in the picture.

clarkwinkelmann

Boss81 try clearing cache if you haven't already

joanaranda

Certainly, I can confirm Boss81 :

Boss81

clarkwinkelmann

I already deleted it. But unfortunately, it didn't turn out well either.

Litalino

Error file lang ..waiting fixer

placeholder={app.translator.trans('datlechin-birthdays.forum.sign_up.dob_placeholder')}

clarkwinkelmann

The new lines in the Yaml file seem improperly indented, making the translation register under forum.page.sign_up instead of forum.sign_up.

joanaranda

clarkwinkelmann - Oh, ok. Now I understand it. I'm not very familiar with yaml. I hope @datlechin fixes it soon. Thank you for raising the root cause!

Boss81

Hi @datlechin

Hello!

Unfortunately, I found a small problem with the extension.

In the mobile browser, when I want to register and click to enter the date of birth, there will only be a white field, the option to choose the date does not appear.
If I go to another field, it doesn't matter which one, and then I go back to the birthday entry field, only then will it be possible to select the date.

It is an iOS system, I tested it in 12 browsers, deleted the history and cookies everywhere, but the result is the same everywhere. A friend of mine also tried the registration, and the situation is the same for him.

On a mobile device, you have to click on the field twice to select the date.

It shows normally in a virtual environment, but not on a live device.

datlechin

Boss81 I will take a look on the weekend.

Boss81

@datlechin Can you help me with this?

https://discuss.flarum.org/d/29793-birthdays/117

Boss81

datlechin

Thanks 🙂

Mirzaagha

datlechin Hi, how to remove left side this Birthdays today word?

« Previous Page Next Page »