utf encoding error in title

Umutcan

Hello
We separate some suffixes that come to words in Turkish with the (') sign.

Sometimes we have to use the (') sign in the titles we write. But on the title, instead of seeing this sign ('), we see the ' code. This is very bad for Flarum's SEO reputation in the Turkish market. If you want to test live, click the link below

https://demo.flarum.site/d/49

askvortsov

Umutcan This should be fixed in Flarum v1.2

flarum/core3259

Umutcan

It's not utf it's an ASCII error I guess.

Umutcan

Interestingly, this problem is not encountered on FreeFlarum. See:

Umutcan

askvortsov demo.flarum.site not in version 1.2?

https://lab.migratetoflarum.com/scans/fe47c334-6228-4812-911d-8158180102ad

https://demo.flarum.site/d/49

Umutcan

My forum and two other forums are upset about this issue. I ask you to test it. The forums I mentioned are using the latest version. v1.2

Kalecgos

I've just made a quick test - the problem indeed appears to be still there in 1.2. Interestingly, the page title on the admin pages is shown fine whereas the title on the discussion pages contains the &-sequence.

clarkwinkelmann

We discovered and "fixed" this issue during quality testing, but I just confirmed that single quotes are still broken.

We fixed a list of characters including carets and double quotes and didn't re-test the single quote specifically 😬

I have opened an issue to track the missing fix askvortsov1/rich-icu-message-formatter2

We'll discuss internally how we want to release the patch. We might group it with other things for a first 1.2 patch release.

PS: impact on SEO should be limited because the bug only affects the javascript version of the page. The nojs version of the page and social sharing previews shouldn't be affected.

Umutcan

clarkwinkelmann I'm asking because I'm curious. Why was FreeFlarum not caught in this situation? I have mention the sample links in the bottom.

https://flarumtestforum.freeflarum.com/d/4-c-x

askvortsov

clarkwinkelmann it's fixed in the main branch but we haven't released it in a version yet.

Hari

MikeJones answered clarkwinkelmann

askvortsov

Umutcan They haven't updated to v1.2 yet.

Hari

askvortsov I am using v1.2 this issue still persist Hari

i have gone through the flarum/core3259 not sure it is added to v1.2 or not

i am not using FreeFlarum

MikeJones

askvortsov Any idea when it might be released? Or will it wait until the next release?

Hari

Edit: sorry, i just read Clark's reply 👍

askvortsov

Fixed in v1.2.1

MikeJones

askvortsov Are there update instructions anywhere? Thanks!

MikeJones

askvortsov Are there any update instructions anywhere?

Hari

MikeJones

composer update --prefer-dist --no-plugins --no-dev -a --with-all-dependencies
php flarum migrate
php flarum cache:clear

https://docs.flarum.org/update

MikeJones

Sorry for the spam... Every time I reply it says there was a problem....

MikeJones

Hari updated perfectly thanks! Looks like the issue is resolved as well!