Link Preview
Is it possible to add a favicon in front of the link header?
In the context of the recent GDPR discussions and transparency in general, could you consider listing the external services used in the README? I see Google servers are used to serve the favicons.
Who operates meta-grabber.herokuapp.com? It it your own app or a third-party?
Looking at the code I assume this extension also loads oembed images in the user browser without proxy?
- Edited
clarkwinkelmann sorry about that, idk
This is just temporary using
I'll switch to using PHP or JS library to get data soon
As for proxies, I don't know about this, but I'll try to find out
- Edited
clarkwinkelmann I see Google servers are used to serve the favicons.
@datlechin an idea I know it would not be as “cool” but you could just remove favicons. Then you aren’t having to use that Google service. Still, one day, like you said, also using something else to get the meta data would be best. But, either way, not worrying about favicons keeps it more simple.
I'm have updated external services used for now
- Edited
v0.1.5 @6bb55bf, v0.1.6 @d9680ae
- Using PHP library to fetch open grap instead of a third-party app.
- Edited
v0.1.7 datlechin/flarum-link-previewafee215
- Now the title will show "This site cannot be reached" instead of returning an exception when the domain name is cannot reached.
Haven’t had time to install and try this yet. How is it on page load performance? I assume it has to ping the website and get the open graph data each time? Because I think the only way around that is some sort of caching or database storing just for the meta data.