Link Preview

010101

datlechin it would be difficult, I think. One option would be, as you post, it grabs the meta og image, and uploads it somewhere. Like the upload extension does. You then at least have the link’s image stored. But I don’t know how. That is still above my programming knowledge. 😳

datlechin

010101 what if store them on localstorage 🤔

010101

datlechin

I fear, then too much ends up being stored locally. And I think people would need to add to their privacy polices that this site stores images locally.

datlechin

010101 Just store the link image, title, and description of each link..... I think storing them in session storage would be better. Because after closing the browser, the data stored on it will be destroyed.

010101

datlechin Oh ok. Yes, this would probably help.

I just assume the big sites (Facebook/Twitter), they somehow cache not just the link to the image, but the image itself. This way, every time you load the page it’s not asking that website for its open graph image.

But, some kind of local storage could be one step in the right direction.

Another question: How’s this working for inline links? For example I may not want this link turned into a preview.

Umutcan

In this way, it is less tiring on the eyes.

/* Link Preview */
.LinkPreview {
background: @hero-bg !important;
}
.LinkPreview-description {
color: @muted-color !important;
}
.LinkPreview a {
color: @muted-color !important;
}
.LinkPreview .fa-spinner{
color: @muted-color !important;
}
/* Link Preview End */

[deleted]

Umutcan
Thanks for sharing this code...

datlechin

010101 How’s this working for inline links? For example I may not want this link turned into a preview.

It works for this way. create links using markdown

010101

datlechin thanks I plan on trying it out today or tonight. Another argument for somehow saving or caching what the meta grabber gets is if a website goes down, then your link preview is broken. I wish I knew how to do it. Still this seems like the closest Flarum has gotten in a long time to a link preview extension that’s free.

datlechin

010101 if a website goes down

datlechin you mean this?

datlechin

V0.1.8 datlechin/flarum-link-preview`9de53e6`

Now you can enter blacklist urls or domains to exclude from link preview.
Larger and fixed image on top of Link preview on tablets and desktops.

010101

datlechin

How hard is it to add a whitelist box instead? Only allow a few URLs.

ctml

datlechin

Great work! My first thought when I saw this thread was it would be nice to exclude local domains for intranet sites as I don't want external services to learn about my internal domains... Read through all the posts and sure enough you added this blacklist feature 🤯

Does the whole domain need to match, or only partial?

E.g. would site1.company.com be ignored if company.com was in the ignore list, if not would it be possible to add that behavior or alternatively support regex?

datlechin

010101
I think the blacklist will be more necessary than the whitelist.
Most people just want to exclude certain domains or urls.

010101

datlechin I was thinking if I ever noticed a slight performance issue I might want to only allow it to work with a few "featured" links. But, there may not be any performance issue. That's just me over worrying. 🙂

Edit: Just installed this, working great. And, I suppose there wouldn't ever be a performance issue because worst case if an image cannot load, you would just see the loading spinner forever inside of the preview box, but the actual page at least would still load. Does this sound correct?

datlechin

010101 Hmm...

Maybe I'll add an option to be able to choose a blacklist or whitelist for link preview.

datlechin

ctml It only excludes the domain that you add to the blacklist, just a partial
I am using the includes method not regex

ctml

datlechin ok gotcha, so then adding flarum.org should exclude all subdomains as well correct (docs.flarum.org, discuss.flarum.org, merch.flarum.org)? If so then this is good, as it is the behaviour I am after.

datlechin

ctml maybe i will use regex instead of the old one.

010101

datlechin Sorry for all of the replies, I'm just getting a chance to fully test this. We definitely need regex. Because I need it to ignore audio URLs, such as: .mp3, .m4a, .wav, etc.

Instead of my audio player detecting the audio URL, this extension is converting the link.

Idea: If any URL ends in a file extension of any kind, don't convert it.

Stylix58

Just noticed you use one of my Heroku apps! Anyways, it's looking good!

datlechin

Stylix58 I switched to using PHP to get the graph meta

« Previous Page Next Page »