The post links are broken

CyberGene

I have my Flarum installed in a sub-folder:

Base URL: https://myforum.com/forum
Installation path: /home/customer/www/myforum.com/public_html/forum

If I click on the timestamp of a post to reveal the URL link to that post, the path segment forum is repeated, for example:
https://myforum.com/forum/forum/d/388-new-car/20

I'm not sure when that happened, maybe after 1.2.1 or maybe earlier, I haven't used that functionality for long but it's now broken.

clarkwinkelmann

CyberGene is the url value in config.php correct? (no ending slash)

CyberGene

clarkwinkelmann Hmm, does it make difference? I think I might have edited that a few months ago and I removed the end slash, I was not sure what's the correct way though. Should I put an end slash or keep it without? If I put one now, how should I rebuild the forum, would a clean be enough for that?

clarkwinkelmann

CyberGene I'm not sure whether that value is directly used to generate the permalinks, so maybe it's not actually related. If that was the case, internal links between pages probably would have issues as well.

The value in config.php should not contain an ending slash.

CyberGene

How can I troubleshoot this issue?

CyberGene

Is it better to report this issue on the Flarum GitHub page?

clarkwinkelmann

Unfortunately I don't have a Flarum installation in a subfolder to confirm whether the issue is general or not.

Are you able to create a second Flarum installation to see if it's an issue that exists out of the box? Or does somebody else have a forum in a subfolder where they can verify it?

Usually we'd ask to replicate on our demo forums but since they have their own domains it can't be tested there...

If it's confirmed to be a bug on all subfolder installations, then yes a GitHub issue would be nice 👍️

CyberGene

clarkwinkelmann Are you able to create a second Flarum installation to see if it's an issue that exists out of the box?

OK, I just tested with a brand new Flarum installation in another subfolder of public_html and I can confirm the issue with permalinks exists. Should I open this as an issue to a GitHub project (which one?) or will some of you look into it?

To summarize the issue:
I installed the forum into public_html/forum, so that it's accessed through mydomain.com/forum. If I get the permalink to a discussion post, the sub-folder is duplicated: https://mydomain.com/forum/forum/d/1-test/2

CyberGene

It would take me a lot of time to try to install a new forum instance in another sub-folder to test the issue.

Can someone else having their forum installed in a sub-folder (e.g. under a sub-folder of publuc_html on a shared hosting) and on 1.2.1 confirm if he can reproduce this issue? Open a discussion, then find a post within that discussion, click on the time of post (e.g. “five minutes ago”) and then copy the URL that appears there and check if it’s correct? Like paste it in another browser tab and see if it works?

askvortsov

CyberGene Found the issue. Relevant code is https://github.com/flarum/framework/blob/5bf0be7bd3370d589164c6827e2e57422bbd9a7c/framework/core/js/src/forum/components/PostMeta.js#L60-L62. Both basePath and baseUrl contain the subdirectory path so it gets duplicated.

Opened a PR: flarum/framework3354

CyberGene

askvortsov thank you!

CyberGene

askvortsov when is this going to be released? I just opened the Google Search Console and noticed there are errors related to this bug with Google trying to index those broken links, probably crawling the forum and encountering the wrong permalinks.

CyberGene

Ahh, never mind, I just checked that it has been merged in master 5 days ago and is going to be put in 1.3. Hopefully that will be soon 🙂