luceos would be great to implement it as configurable
why flarum search is bad and how to improve with a new extension?
tankerkiller125 why flarum is not using innoDB by default? I mean are there any disadvantages?
- Best Answerset by Hari
Hari never mind actually, Flarum has used InnoDB by default for far longer than that. I just investigated our codebase and there is a bug preventing languages like Telugu from being searched, I've posted a fix here: flarum/framework3385
- Edited
SychO thanks for the quick fix. Like Shasha said this gonna be the biggest PR in flarum's history for sure.
Please give me the test environment URL I would like to test, as I can see you have mentioned that you did these changes locally, could you deploy it somewhere.
I will take a few songs lyrics and perform a search
Telugu
ఒకటే జననం ఒకటే మరణం
ఒకటే గమనం ఒకటే గమ్యం
గెలుపు పొందె వరకూ అలుపు లేదు మనకు..
బతుకు అంటె గెలుపూ గెలుపుకొరకె బ్రతుకు..
కష్టాలు రానీ కన్నీళ్ళు రానీ
ఏమైన గానీ ఎదురేది రానీ
ఓడిపోవద్దు రాజీపడొద్దు
నిద్ర నీకొద్దు నీకేది హద్దు
Hindi
किसी को सपना लगे तू … किसी को बहती हवा किसी को बस बातों में, करे पल में यहाँ वहाँ किसी के सौ झूठ सुन ले, किसी का सच्च भी गुनाह किसी का बस यादों में, करे हलचल सारा जहां टी यामो मी टी यमो तू छाँव है, तू धुप है टी यामो मी टी यमो तेरे हजारों रूप हैं
Kannada
(ಗ) ನಿನ್ನ ಜೊತೆ ನನ್ನ ಕಥೆ
ಒಂದೊಂದು ಸಾಲು ಜೀವಿಸಿದೆ
ನನ್ನ ಜೊತೆ ನಿನ್ನ ಕಥೆ
ಬೇರೊಂದು ಲೋಕ ಸೃಷ್ಟಿಸಿದೆ
ಎಂದು ಹೀಗೆ ಆಗೇ ಇಲ್ಲ
ಏನು ಇದರ ಸೂಚನೆ
ನೂರು ವಿಷತ ಇದ್ದರೂನು
ನಿನ್ನದೊಂದೇ ಯೋಚನೆ
Malyalam
ഇന്റര്നെറ്റിനെ ആകമാനം പിടിച്ചുലച്ച ഗാനമാണ് വെളിപാടിന്റെ പുസ്തകം എന്ന ചിത്രത്തലെ എന്റമ്മേടെ ജിമിക്കി കമ്മല് എന്ന് തുടങ്ങുന്ന ഗാനം. പാട്ടും അതിനൊത്ത താളച്ചുവടുകളും കൊണ്ട് കേരളം മാത്രമല്ല, മറ്റ് സംസ്ഥാനങ്ങളിലും ഈ പാട്ട് അലകളുണ്ടാക്കി. പാട്ടിന്റെ മുഴുവൻ വരികൾ ഇതാ..
Tamil
நியூயார்க் நகரம்
உறங்கும் நேரம் தனிமை
அடர்ந்தது பனியும் படர்ந்தது
கப்பல் இறங்கியே காற்றும்
கரையில் நடந்தது
நான்கு கண்ணாடி
சுவர்களுக்குள்ளே நானும்
மெழுகுவர்த்தியும் தனிமை
தனிமையோ கொடுமை
கொடுமையோ
Sinhala
ෆ්ලාරම් සඳහා සිංහල භාෂා ඇසුරුම
- Edited
Hari the pr is merged, not sure but probably you can install Flarum dev master locally into your pc?
- Edited
Justoverclock how to install dev-master, what is the command? is the below command correct?
composer create-project flarum/flarum dev master
Edit:
git clone git@github.com:flarum/flarum.git <target directory>
cd <target directory>
https://discuss.flarum.org/d/9829-installing-flarum-dev-master
looks like not easy. can i try this? https://demo.flarum.site/
- Edited
Hari The dev-master demo Nightly (https://nightly.flarum.site/) is under 6f72c7f
not sure if it is updated or not.
If you prefer local, I think the easiest thing to do would be:
composer create-project flarum/flarum:"@"dev" Sorry, forget it, it's not like that to install it locally.
- Edited
YAYYYYYY! search is working The reason I am mentioning these many languages is I want flarum to consider every langue equally so the search will work in any scenario
Telugu is working: ఒకటే జననం
https://nightly.flarum.site/?q=ఒకటే%20జననం
Hindi is not working: किसी को
https://nightly.flarum.site/?q=किसी%20को
Kannada is not working: ಸಾಲು ಜೀವಿಸಿದೆ
https://nightly.flarum.site/?q=ಸಾಲು%20ಜೀವಿಸಿದೆ
Malayalam is not working: പിടിച്ചുലച്ച ഗാനമാണ്
https://nightly.flarum.site/?q=പിടിച്ചുലച്ച%20ഗാനമാണ്
Tamil is not working : நியூயார்க்
https://nightly.flarum.site/?q=நியூயார்க்
Sinhala is not working: සිංහල භාෂා
https://nightly.flarum.site/?q=සිංහල%20භාෂා
i request to support all the possible languages from this Unicode Scripts
https://wpastra.com/docs/complete-list-wordpress-locale-codes/
\p{Common}
\p{Arabic}
\p{Armenian}
\p{Bengali}
\p{Bopomofo}
\p{Braille}
\p{Buhid}
\p{Canadian_Aboriginal}
\p{Cherokee}
\p{Cyrillic}
\p{Devanagari}
\p{Ethiopic}
\p{Georgian}
\p{Greek}
\p{Gujarati}
\p{Gurmukhi}
\p{Han}
\p{Hangul}
\p{Hanunoo}
\p{Hebrew}
\p{Hiragana}
\p{Inherited}
\p{Kannada}
\p{Katakana}
\p{Khmer}
\p{Lao}
\p{Latin}
\p{Limbu}
\p{Malayalam}
\p{Mongolian}
\p{Myanmar}
\p{Ogham}
\p{Oriya}
\p{Runic}
\p{Sinhala}
\p{Syriac}
\p{Tagalog}
\p{Tagbanwa}
\p{TaiLe}
\p{Tamil}
\p{Telugu}
\p{Thaana}
\p{Thai}
\p{Tibetan}
\p{Yi}
- Edited
Hari I tested all of those locally and they actually work, I'm not entirely sure if nightly is updating since we switched to a monorepo.
here's a good way of figuring out if certain language characters are not filtered out. If a character is highlighted then it's a problem: https://regex101.com/r/qesbFx/1 I can already see there is still an issue with Malayalam lang, not sure yet how to escape those.
- Edited
SychO awesome these little things matters a lot. When can we expect v1.3 public release?
Can we implement same to the discussion slugs too? Generating discussion slugs in different language other than English (Telugu, Hindi)
Justoverclock could you install latest dev master version and check related discussions are working or not.
Hari Can we implement same to the discussion slugs too? Generating discussion slugs in different language other than English (Telugu, Hindi)
This is possible with a relatively simple custom extension that just adds a slug driver that doesn't transliterate.
Changed tags as requested by discussion originator.
Can this make an improvement in Chinese language search? If it does, this PR will be historic
https://flarum.it/?q=%E4%B8%AD%E6%96%87%E8%AF%AD%E8%A8%80
In the above test, it was found that three characters must be searched for a search, and a search will not work properly if two or less characters are entered
JerryYang The relevant PR doesn't address that, and I don't think that the problem evoked with Chinese search can be fixed by any tweaks to Flarum's codebase, it seems to be a lack in MySQL's fulltext search, perhaps this might help: https://discuss.flarum.org/d/22321-improving-search-for-chinese-characters/15