Page doesn't load properly when refresh with "Reply ID in URL"

masihdindar

When i enter a topic from topic lists, i can see all replies and posts in a topic, but when i refresh that page with reply id included, page can't get posts.
For example try to open this: *********
Nothing load! and in console there is this error:

mount-redraw.jss:13 TypeError: Cannot read properties of undefined (reading 'id')
    at e.<anonymous> (AddLists.jss:56:48)
    at e.Mr.forEach.t.<computed> (extend.tss:37:7)
    at e.Mr.forEach.t.<computed> (extend.tss:36:68)
    at e.Mr.forEach.t.<computed> [as footerItems] (extend.tss:36:68)
    at e.n.view (Post.jss:52:35)
    at Function.a (render.jss:27:2)
    at render.jss:154:28
    at render.jss:156:45
    at c (render.jss:164:20)
    at l (render.jss:47:3)

a	@	mount-redraw.jss:13
(anonymous)	@	mount-redraw.jss:20
requestAnimationFrame (async)		
u	@	mount-redraw.jss:15
(anonymous)	@	PostStreamState.jss:120
Promise.then (async)		
e.goToNumber	@	PostStreamState.jss:112
n.show	@	DiscussionPage.tsxx:214
setTimeout (async)		
n.load	@	DiscussionPage.tsxx:156
n.oninit	@	DiscussionPage.tsxx:56
a	@	render.jss:27
M	@	render.jss:916
(anonymous)	@	render.jss:151
(anonymous)	@	render.jss:156
c	@	render.jss:164
l	@	render.jss:47
(anonymous)	@	render.jss:100
c	@	render.jss:105
(anonymous)	@	render.jss:485
p	@	render.jss:495
f	@	render.jss:300
(anonymous)	@	render.jss:961
a	@	mount-redraw.jss:11
m	@	router.jss:110
Promise.then (async)		
t	@	router.jss:124
E	@	router.jss:125
a	@	render.jss:27
(anonymous)	@	render.jss:970
mount	@	mount-redraw.jss:39
y	@	router.jss:157
e.mount	@	Application.tsxx:296
Mr.forEach.t.<computed>	@	extend.tss:36
n.mount	@	ForumApplication.tss:105
e.boot	@	Application.tsxx:269
(anonymous)	@	19:270

But if you open main URL of this topic, it works fine: ********

So anyone have any idea what's wrong here?

masihdindar

and if you try to go to home page, another error will add to browser's console:

mount-redraw.jss:13 TypeError: Cannot read properties of undefined (reading 'id')
    at e.<anonymous> (AddLists.jss:56:48)
    at e.Mr.forEach.t.<computed> (extend.tss:37:7)
    at e.Mr.forEach.t.<computed> (extend.tss:36:68)
    at e.Mr.forEach.t.<computed> [as footerItems] (extend.tss:36:68)
    at e.n.view (Post.jss:52:35)
    at Function.a (render.jss:27:2)
    at render.jss:154:28
    at render.jss:156:45
    at c (render.jss:164:20)
    at l (render.jss:47:3)
a @ mount-redraw.jss:13
4mount-redraw.jss:13 TypeError: Cannot read properties of undefined (reading 'onremove')
    at k (render.jss:712:28)
    at k (render.jss:719:14)
    at k (render.jss:719:14)
    at k (render.jss:714:28)
    at k (render.jss:719:14)
    at k (render.jss:719:14)
    at k (render.jss:719:14)
    at k (render.jss:719:14)
    at k (render.jss:714:28)
    at S (render.jss:666:16)
a @ mount-redraw.jss:13

masihdindar

Edit:
Things going weird!
Open this: *******
It works fine,
But now try to open this: ******
It have problem! Reply with ID 14 and 15 are exist in that topic, But in some unknown reason, only some of reply URLs works.

clarkwinkelmann

The error seems to be coming from michaelbelgium-discussion-views extension, but it's because the pre-loaded data is not formatted according to Flarum's expected format. So there's likely a second extension being the real root cause.

Can you share your php flarum info output so we get an idea of which extensions are enabled?

Disabling the discussion views extension should make the issue go away. You could try disabling other extensions to see if they are the one that's causing the issue together.

The issue at https://betalk.ir/d/96-mgmoaah-mtn-o-shaar-o-byamk-drbarh-hmdly/18 is that the Discussion Views extension tries to access post at index 0, but the first 4 items in the array are undefined, which is not supposed to happen:

app.store.getById('posts',215).discussion().posts()
Array(16) [ undefined, undefined, undefined, undefined, {…}, {…}, {…}, {…}, {…}, {…}, … ]

masihdindar

clarkwinkelmann Hi, Here the output:

Flarum core 1.2.0
PHP version: 7.4.28
MySQL version: 10.3.34-MariaDB-log-cll-lve
Loaded extensions: Core, bcmath, calendar, ctype, date, filter, hash, iconv, json, SPL, pcre, readline, Reflection, session, standard, mysqlnd, tokenizer, zip, zlib, libxml, dom, PDO, bz2, SimpleXML, xml, xmlreader, xmlwriter, openssl, curl, fileinfo, gd, gettext, mbstring, exif, mysqli, pdo_mysql, pdo_sqlite, Phar, ftp
+-------------------------------------+---------+--------+
| Flarum Extensions                   |         |        |
+-------------------------------------+---------+--------+
| ID                                  | Version | Commit |
+-------------------------------------+---------+--------+
| flarum-flags                        | v1.2.0  |        |
| flarum-nicknames                    | v1.2.0  |        |
| flarum-tags                         | v1.2.0  |        |
| flarum-likes                        | v1.2.0  |        |
| flarum-approval                     | v1.2.0  |        |
| flarum-markdown                     | v1.2.0  |        |
| afrux-forum-widgets-core            | v0.1.7  |        |
| v17development-user-badges          | v1.0.0  |        |
| v17development-seo                  | v1.8.0  |        |
| the-turk-flamoji                    | 1.0.2   |        |
| sycho-profile-cover                 | v1.3.1  |        |
| nearata-internal-links-noreload     | v2.0.1  |        |
| michaelbelgium-discussion-views     | v7.1.2  |        |
| justoverclock-purify                | 0.1.7   |        |
| justoverclock-hashtag               | 0.2.3   |        |
| justoverclock-contactme             | 0.2.3   |        |
| justoverclock-auto-post-count-badge | 0.1.9   |        |
| irmmr-rtl                           | V0.1.2  |        |
| fof-username-request                | 1.0.1   |        |
| fof-upload                          | 1.1.0   |        |
| fof-subscribed                      | 1.0.2   |        |
| fof-stopforumspam                   | 1.2.0   |        |
| fof-split                           | 1.0.1   |        |
| fof-socialprofile                   | 1.1.1   |        |
| fof-sitemap                         | 1.0.3   |        |
| fof-secure-https                    | 1.0.1   |        |
| fof-recaptcha                       | 1.0.0   |        |
| fof-pretty-mail                     | 1.0.1   |        |
| fof-pages                           | 1.0.1   |        |
| fof-merge-discussions               | 1.2.1   |        |
| fof-links                           | 1.0.3   |        |
| fof-linguist                        | 1.0.3   |        |
| fof-formatting                      | 1.0.2   |        |
| fof-best-answer                     | 1.1.8   |        |
| flarum-suspend                      | v1.2.0  |        |
| flarum-subscriptions                | v1.2.0  |        |
| flarum-sticky                       | v1.2.0  |        |
| flarum-statistics                   | v1.2.0  |        |
| flarum-mentions                     | v1.2.0  |        |
| flarum-lock                         | v1.2.0  |        |
| flarum-lang-english                 | v1.2.0  |        |
| flarum-bbcode                       | v1.2.0  |        |
| datlechin-title-length              | v0.1.1  |        |
| clarkwinkelmann-who-read            | 1.4.0   |        |
| clarkwinkelmann-likes-received      | 1.0.0   |        |
| clarkwinkelmann-first-post-approval | 1.0.0   |        |
| askvortsov-rich-text                | v2.1.1  |        |
| askvortsov-markdown-tables          | v1.2.1  |        |
| afrux-top-posters-widget            | v0.1.4  |        |
| afrux-online-users-widget           | v0.1.5  |        |
| afrux-forum-stats-widget            | v0.1.1  |        |
| acpl-mobile-tab                     | 1.1.0   |        |
| acpl-lscache                        | 0.4.1   |        |
+-------------------------------------+---------+--------+
Base URL: https://betalk.ir/public
Installation path: C:\xampp\htdocs\flarum
Queue driver: sync
Mail driver: smtp
Debug mode: off

And yes, i just disabled discussion views extension and this problem fixed!
Do you have any idea which extension cause this problem? Somehow i like "View" extension and want to keep using that. 😞

@MichaelBelgium Sorry to mention you mate, But seems your extension have a bug or interferes with another extension. I thought you may have received such a report before and know what other extensions can cause this problem.

MichaelBelgium

masihdindar So what steps do you do exactly to get a white page on a post?

If i try to:

enable footer viewlist
go to a topic directly by url (for example https://discuss.flarum.org/d/30447-page-doesnt-load-properly-when-refresh-with-reply-id-in-url/12)

It does load the whole thread and posts without any problems

clarkwinkelmann The issue at https://betalk.ir/d/96-mgmoaah-mtn-o-shaar-o-byamk-drbarh-hmdly/18 is that the Discussion Views extension tries to access post at index 0, but the first 4 items in the array are undefined, which is not supposed to happen:

app.store.getById('posts',215).discussion().posts()
Array(16) [ undefined, undefined, undefined, undefined, {…}, {…}, {…}, {…}, {…}, {…}, … ]

It does get the first post in a thread because it needs to add those footer views, if there isn't a first post - then how could there be a thread?

luceos

masihdindar try this one instead: https://extiverse.com/extension/flarumite/simple-discussion-views

masihdindar

@MichaelBelgium I tried config View extension and i found out that "Enable footer viewlist" cause this problem. Now this extension is enabled and without "Enable footer viewlist" option everything works fine. Can you check what's wrong with this option?
@clarkwinkelmann Seems one option in settings cause this bug. Somehow i just disabled this option and all urls working as expected 😮

@luceos Thanks man, i will test this extension 👍️

MichaelBelgium

masihdindar I tried config View extension and i found out that "Enable footer viewlist" cause this problem. Now this extension is enabled and without "Enable footer viewlist" option everything works fine. Can you check what's wrong with this option?

So when u enable this option, the first 4 posts of the discussion are undefined? (as seen in post #5)
How are they undefined in the first place

masihdindar

MichaelBelgium Somehow, this bug will prevent a topic loading from a specific post

For example, if i try to open a topic in post #6 directly by topic's url, the topic won't load at all and show empty section instead of posts.
But as is mentioned before, this problem solved after disabling "Enable footer viewlist" option.

Braden

Mine does load correctly, but something with replied ID, the one he mentioned, i discovered that when you're using devwheat ads extension, the ads on replies could affect the sequence of the url I'D s?

With that said, my encounter, switching On/Off the ads unit may be a bad idea, because of the crawler's, may post a counted reply URL with an Id and publish it, which later the url may be missing

So you left with a slash with no replie number, and flarum retries to show the original post