Rich Embeds

CyberGene

@clarkwinkelmann I've been seeing a peculiar effect since the very beginning but never bothered posting about it since it’s very minor but here it is anyway. ~~All~~ Many links to forum’s own discussions appear with a picture that is my own avatar 😀 Why would that be? I’m the first user on the forum (as its creator) after the embedded admin user, if that’s a clue? Could it be that the extension just uses the very first image asset it finds on the file system and maybe that’s my avatar? Not a big deal anyway, because my avatar is a picture of grand piano keys which is what the forum is about but still, it’s a bit odd.

P.S. Actually that’s not always, just found some embeds are using pictures extracted from the discussion which is great.

clarkwinkelmann

CyberGene can you share with me the output of the command php flarum kilowhat:rich-embeds:process <url> -vvv where <url> is one of the URLs for which you see the issue?

For example php flarum kilowhat:rich-embeds:process https://discuss.flarum.org/d/30516-rich-embeds -vvv

Would then produce something like

Retrieved: 2024-02-04T21:25:12+00:00
HTTP Status: 200
OpenGraph: null
Icons: [
    {
        "href": "https:\/\/discuss.flarum.org\/assets\/favicon-hppi83fd.png"
    }
]
Fallback: {
    "title": "Rich Embeds - Flarum Community",
    "images": [
        {
            "alt": "Flarum Community",
            "src": "https:\/\/discuss.flarum.org\/assets\/logo-2q2rcevl.png"
        },
        {
            "alt": "Extiverse badge",
            "src": "https:\/\/extiverse.com\/extension\/kilowhat\/flarum-ext-rich-embeds\/badge"
        },
        {
            "alt": "Post with 2 different styles of embed",
            "src": "https:\/\/kilowhat.net\/medias\/extensions\/rich-embeds\/post.png"
        },
        {
            "src": "https:\/\/i.ibb.co\/4KcJG13\/DE630615-129-E-4910-BEBE-A28-D0-D710367.jpg"
        },
        {
            "src": "https:\/\/i.ibb.co\/L1TM09X\/F07580-F3-347-B-41-C3-AE9-C-7429251934-B0.jpg"
        },
        {
            "src": "https:\/\/i.ibb.co\/X2CPDYQ\/BDC9-B0-E7-F81-F-411-F-8-EDC-78278-C3-C0-EA9.jpg"
        },
        {
            "src": "https:\/\/i.imgur.com\/1qIUYsX.png"
        }
    ],
    "description": "Get support using and extending Flarum, the next-generation forum software that makes online discussion fun."
}
API Resource: null

You can sent it to my support email address if you would rather not share the URL here. But the payload won't contain anything confidential.

CyberGene

clarkwinkelmann the output of the command is here

P.S. Ohh, never mind, I got what it is. I’ve set that picture as “social media image” in the SEO extension. I’ll remove it there.

P.P.S. Why would sometimes the extension take a picture from the discussion instead? I like that and would prefer it over using the forum logo, if possible.

clarkwinkelmann

CyberGene glad you figured the first mystery out!

There are a number of fallback methods that impact which images are chosen:

First, if there is an opengraph image, it will take priority. This is what happens when the SEO extension is active
Second, if the forum advertises the X-Powered-By: Flarum header (Flarum does it by default), and the link points to the first post/page of the discussion, then the extension will intelligently extract images from the first post of the discussion
Finally, if the link is not recognized as Flarum or is not for a discussion, any image on the page will be picked, in the order they appear

If you experience a different behavior, let me know and I'll double-check if my explanation above is correct. I might have changed a few things with each update.

I could add a setting to blacklist specific image URLs, so that you could exclude a particular site logo if it doesn't look good. But if I find a way to make the parser better by default for everyone I will also try that. The problem is, it's difficult to guess what is a site logo or part of the content when doing what is already a fallback solution. The ideal solution would be for all sites to implement opengraph so they can choose which image they want to promote.

Clamours

Thank you very much for your great work, but sorry, is it possible for this extension to only enable rich image embedding functionality without enabling other features such as link previews? I only need the functionality to avoid image loading offsets and nothing else.
There are a large number of pictures in the discussion list and post content of my Flarum site (https://www.moresound.club/). In the iOS Safari browser, if I enter a discussion content page and then return to the homepage discussion list, the image will reload and cause serious offset. Jump offset, this problem is suspected to be caused by the lack of height label of the image. Can your extension solve this problem? Or where can I see this extension in action? Thank you again.

clarkwinkelmann

Clamours it's true that there is currently no separate settings, I should add more options and make the existing options clearer.

Looking at the code, the way things are currently implemented, the image parsing does not follow the general embed permission, so you should be able to achieve what you desire by forbidding members from using embeds. The images should still be parsed in their posts.

The image embed also disregards the "disable embeds on this post" feature. Even if someone who can post embeds then hides the link embeds, the image embed feature will continue to work.

Do you already have the extension? Let me know if that doesn't work and I'll try to add more options soon. If you don't have the extension yet, you can purchase it for testing and if it doesn't fit your needs I'll refund the purchase.

CyberGene

BTW, I used to hate Flarum for that scrolling issue on iPhone and it’s only now that I realize Rich Embeds solved it for me long ago 🥳 You rock @clarkwinkelmann

Darkle

I have migrated (server) and updated extensions, I have noticed that this extension doesn't work, the cached links work but there is no way to create any new ones.

In the admin preview when entering a test link it stays in "Retrieving...", I have no logs neither from Flarum/php, so it is complicated to debug what is happening, any idea?

clarkwinkelmann

Darkle please share your php flarum info

If you are able to, check the browser JavaScript console while using the preview feature and see if any error is generated there

Darkle

clarkwinkelmann I deleted this message, as I wasn't 100% sure:

I was testing with almost everything disabled, I seem to have found the problem, redis (when disabled it seems to work), I will share the details of the configuration.

But yeah, the problem is when using redis, I am using this extension (https://discuss.flarum.org/d/21873-redis-sessions-cache-queues), extend.php:

// Redis configuration
    (new Blomstra\Redis\Extend\Redis([
       'scheme' => 'unix', 
       'path' => '/tmp/redis.sock',
       'port' => 0,
       'database' => 1
    ])),

By deactivating redis and purging the extension, it works again.

clarkwinkelmann

Darkle it's probably not related to the cache, because only the Google Drive preview feature relies on the cache. Most likely it's related to the jobs running asynchronously. I would need to do tests on my own server to investigate.

If you have access to the queue log or the database, could you check if you see any indication of the job starting and/or completing? The job is called ProcessUrl. In the kilowhat_rich_embeds table, you could look for the URL that was entered in a preview and check if retrieved_at column is still NULL or contains a date.

Darkle

clarkwinkelmann You pointed me in the right direction, the issue was with the redis queue, and it was a issue with my environment (a configuration for another site that was preventing the queue from running correctly), so nothing to do with the extension, sorry about that. I left you a message on discord about another matter related to this extension, thank you.

« Previous Page