Discussion Count

Ffuser1

Sivoph this is worth merging. Do a PR in github.

Wellwisher

Does this plugin round the numbers up I feel that will be more useful. E.g any posts over 1000 posts is shown as "1K+"

Sivoph

Wellwisher

I have forked Datlechin's core extension to include an admin setting to adjust the bar thickness:

Also added a '1k+' conditional statement when posts reach over 1,000, per request:

Fork Link:
Github

Please let me know if anything goes awry. Remember, I'm still a noob so you are likely on your own, lol.
Thanks once again, Datlechin, for the great extension!

Wellwisher

Sivoph this mod has a lot of potential. It's a nice improvement. Looks pretty cool. Congrats. I hopefully one day will reach your stage of releasing my own plugin.

bachmx

Sivoph How to install that fork? Thanks.

fakruzaruret

I think this count ext. calculate wrong. There are 13 discussion on category but it shows 112. İnteresting!

fakruzaruret

fakruzaruret is not there anyone who has this problem?

fakruzaruret

fakruzaruret hey there is a bug.

datlechin

fakruzaruret i think it calculates the number of discussions incorrectly due to flarum/tags

vspurg

fakruzaruret
I have the same error.
I noticed that the discrepancy in the number appears after the transfer of messages from one Discussion to several discussions. A new discussion created in this way does not count towards the total until the tag is manually changed.

datlechin

fakruzaruret Could you provide me your forum url? I have tested on my local and it calculates normaly

fakruzaruret

datlechin I have send a message from discord.

fakruzaruret

datlechin may be, unfortunately I dont have programming knowledge so I can't solve. I hope flarum team release bugfix for this. Thank you.

fakruzaruret

datlechin what do you think about this @luceos ? I could not create issue for tags because its repo readonly.

fakruzaruret

@datlechin I get this error at tags page when I activate the extension. Also discussion count numbers are wrong.

mount-redraw.js:15 TypeError: Cannot read properties of undefined (reading 'children')
    at index.js:33:37
    at NodeList.forEach (<anonymous>)
    at e.<anonymous> (index.js:30:14)
    at forEach.t.<computed> [as oncreate] (extend.ts:39:16)
    at Function.a (render.js:30:16)
    at render.js:971:48
    at Function.a [as sync] (mount-redraw.js:14:10)
    at m (router.js:114:28)

zaja

The extension correctly displays the number of posts when the posts are published manually, but I made an import from MyBB to Flarum and out of 90,000 posts, not one is counted. Any suggestions?

datlechin

zaja What tool do you use to import data from myBB to Flarum? I think that that tool doesn't calculate discussions for discussion_count column in tags table.

zaja

datlechin I used MyBB to flarum extension:
https://discuss.flarum.org/d/5506-mybb-to-flarum

Yes, discussion_count column in tags table is empty. Is there a way to do a recount?

This seems to be a known problem with imports..
https://discuss.flarum.org/d/32589-is-there-a-way-to-recount-tagdiscussion-count

fakruzaruret

This extension is not updated for 2 years and it shows counts wrong because of fof/tags extension according to @datlechin .

is there any planned bugfix for this? (sorry for I tagged you in discussion, I may have violated community rules)
@luceos @SychO @IanM

datlechin

fakruzaruret I will check it over the weekend.

Litalino

datlechin I temporarily encountered this error and fixed it as follows

extend(TagsPage.prototype, ['oncreate'], function () {
  let in_setInterval = setInterval(()=> {
    const tags = this.tags;
    const tagsItem = document.querySelectorAll('.TagTile-info');

    tagsItem.forEach(function (item) {
      const tagName = item.querySelector('.TagTile-name').innerText;
      const tag = tags.find((tag) => tag.name() === tagName);
      const children = sortTags(tag.children() || []);
      const discussionCount = tag.discussionCount();

      const childrenLinks = item.querySelectorAll('.TagTile-children a');

      childrenLinks.forEach(function (link) {
        const childTagName = link.innerText;
        const childTag = children.find((tag) => tag.name() === childTagName);
        const childDiscussionCount = childTag.discussionCount();
        link.innerText = `${childTagName} (${childDiscussionCount})`;
      });

      item.querySelector('.TagTile-name').innerText += ` (${discussionCount})`;
    });
  }, 1000);

  setTimeout(() => { clearInterval(in_setInterval); }, 1000);
});

kudos101

datlechin Thanks for such a cool extension! I am also encountering the issue with the discussion count not working correctly due to fof/tags being installed. Were you able to solve this?A

Thank you!