Prominent Post Numbers

m4v3rick

Deleted posts count. Could you change that please?

clarkwinkelmann

m4v3rick this extension doesn't assign post numbers, Flarum does it. Even without the extension, you can click on any post date to see its number.

Furthermore, post numbers are immutable. Once assigned, they don't change. Soft or permanent deletion doesn't cause a discussion to be re-numbered. This would break perma-links to existing posts.

m4v3rick

clarkwinkelmann

Problem is: discussion list shows 35 posts. In the discussion I see the last post with number 46. That might be irritating.

Maybe there could be a second "post number" which counts posts that are not deleted only.

m4v3rick

Could be added here aswell, thanks to @Miracle

Miracle I like this extention - Simple but useful and the post number at the perfect position on the page. 👍
Only one issue - Deleted posts count in the total number , which will confuse the users.
Cause it causes two confusing scenes if one user deletes the second floor within total 5 posts:

The post number will jump #1 directly to #3
The last post shows #5 but the right bar shows 4 posts

abczoujin

I checked Show on right, why is it displayed behind the name on the computer, but the mobile side has become displayed on the right, and the cache has been cleared

clarkwinkelmann

abczoujin please share a screenshot or link where the behavior can be seen. From your description I am unable to confirm whether it's the expected behavior or not.

There could be conflict with Flarum themes or custom CSS.

abczoujin

clarkwinkelmann
Below is my forum link, my forum has the arisem theme installed, css I can't check what went wrong, can you help me take a look? There is no problem on the mobile side, but there are two problems on the computer side.

Problem 1: After installing this extension, the first time you open the post details on the computer, duplicate content will appear when you scroll down: for example, after loading a comment, it will load again from the banner to the comment (a total of two times)

Problem 2: That is, the floor display is only displayed behind the user's name (the background has been turned on to display on the right), not on the far right

Thank you so much

clarkwinkelmann

abczoujin the problem is the .Post-header > ul { display: flex; } CSS rule. I assume it might be part of Arisem.

I could write an alternate version of my extension that works with flex position instead of floating, but this would have to be sponsored. If you know someone who can write the CSS for you, this is something you could easily fix locally by adding custom CSS that changes the flex items order and margins.

abczoujin

clarkwinkelmann
I've fixed this and also appreciate your reply, thank you very much

Nodeloc

Got a error message when trying to render in frontend.

PostStreamState.ts:125  TypeError: r.slug is not a function
    at index.ts:68:67
    at Array.find (<anonymous>)
    at e.<anonymous> (index.ts:67:51)
    at forEach.t.<computed> [as view] (extend.ts:39:16)
    at Function.a (render.js:30:16)
    at render.js:155:45
    at render.js:160:3
    at c (render.js:66:8)
    at l (render.js:50:5)
    at render.js:103:4

clarkwinkelmann

Version 1.0.1

Fix possible issue if posts were loaded without a discussion relation

Nodeloc I was not able to replicate the issue on my test forum but I'm pretty sure I identified the problem. Could you give the new release a try?

If that doesn't solve your issue, could you share your php flarum info output?

Nodeloc

clarkwinkelmann Thank you for your quick response and speedy resolution. The issue has been resolved. 🥳