Discontinuation of my work for Flarum

Justman10000

Since my work was also trampled on by Flarum himself, I hereby stop my work and will no longer support Flarum in any way! It's a pity there are so many id***s who treat other people's work like shit! I not only developed a Dockerfile, but also a docker-compsoe, using MY time and MY efforts

Darkle

Justman10000 You are very dramatic, you are not trying to contribute you are trying to impose and with that ignoring everything the team is kindly telling you, on the other hand if the PR require some structure (like 100% of consolidated OSS projects) why should they make the exception with you? It's sad that after the Justoverclock thing you haven't learned anything.

JasperVriends

Just my two cents, I just checked this PR you mentioned and don't think they threated you as you think they did. Just read what they said slowly.

They just ask you to open another PR with some more information, such as why did you make it, what does it solve, why did you make some specific decisions etc. You can select the same branch in the new PR.

Making changes to PR's is normal and maybe (realistically) even unavoidable. Developers who work on a project usually have specific ways how they'd like to see code in their project and other developers should adapt this. PR's are usually the way to go to discuss things that were changed as well.

None of my PR's have ever been merged instantly, there is always feedback and things need to change. For example, look at this PR or this PR, feedback, changes, changes and in some cases even more changes. And that's good, if they merge everything without hesitation, the project wouldn't be as it is now and would get a bad reputation.

At the end, everyone is happy. But, it can take a while. Patience and being comfortable on receiving and process feedback is the best weapon you can have in these situations.

P.S. Downloading files in a Docker container from pastebin.com (an external provider) is just not safe for a project as this (it can harm the security if the service is being taken over in the future, down or is hacked showing different code). This is what they meant.

Justman10000

I would like to continue my work, but I would have to have confidence that the work of the community will be appreciated

JasperVriends They just ask you to open another PR with some more information, such as why did you make it, what does it solve, why did you make some specific decisions etc. You can select the same branch in the new PR.

Exactly not! As far as I remember, it was said that Docker want not to be supported, and even if this should be in the future that the maintainers do this themselves

Justman10000

Darkle It's sad that after the Justoverclock thing you haven't learned anything.

If someone closes PRs WITHOUT reasons or comments, he is an a****le! There is nothing with, learn from it! But cheer up

010101

It’s also purposefully hard to contribute to most high quality open source projects. I can empathize with the situation to a point. It’s possible for one to put a lot of work into a pull request but at the end of the day it doesn’t work out. I tend to (all humans do) take things personally as well. But, it’s important to pause, take deep breaths, and try as best you can to not take it personally. As you have time, work on what the core developers are asking.

Those are my 2 cents. In short, I feel ya, but it’s normal for things to be heavily scrutinized. And thank goodness the team is strict will pull request so that I don’t install something dangerous.

Everything will be OK. Keep coding. Keep creating.

CyberGene

Sleep over it. I work for a big software company and I've seen this type of frustration a lot, where people get emotional about inability to proceed with merge requests due to not following the established best practices about descriptions or getting it personal about code comments, etc. But people tend to learn to accept it and become valuable contributors. Acting impulsively is never good, I know it myself since I tend to react like that and I'm always sorry later. Just give it some time 👍🏻

Darkle

Justman10000 You had the reason for it even before the PR was closed:

I don't know what you don't understand about that, a nice comment with recommendations and a resource you can use to contribute better to any git project in the future....

Also, you should understand that it's not a personal thing, there have been very good PRs that were not accepted for one reason or another, some things have important implications, especially if they involve ongoing maintenance over time by the Flarum team, so it's up to them to evaluate and decide where to spend their resources and time, and therefore whether it's worth including such a thing.

Justman10000 Where was the discussion concluded?

After a year, it's taken for granted, don't you think?

GreXXL

Justman10000 people are always welcome to use and contribute to Flarum. Warming up an already past discussion - including language that is not welcome in this community (see guidelines) does not contribute to others welcoming you back. I suggest giving it a fresh start and thinking about how you want to use Flarum and what you can / should contribute. As this is OpenSource, you can always create your own packages to enrich your experience with Flarum.

Justman10000

GreXXL Warming up an already past discussion - including language that is not welcome in this community (see guidelines) does not contribute to others welcoming you back.

Where was the discussion concluded?

Justman10000

And I can go again with pleasure! I do not care, is my work that Flarum miss

Justman10000

Darkle some things have important implications, especially if they involve ongoing maintenance over time by the Flarum team, so it's up to them to evaluate and decide where to spend their resources and time, and therefore whether it's worth including such a thing.

Well, just not! I have authored the Dockerfile, so I maintain this as well... Since it's in Flarum's repo, it would be easy for the maintainers to help with maintenance... Yes

Darkle After a year, it's taken for granted, don't you think?

Not necessarily

Justman10000

And I don't know if the screen is from the right repo