Selective MediaEmbed

clarkwinkelmann

poVoq there's nothing I can do on my end.

I think Sami's extension would work out of the box with mine, it just needs to change its requirements to allow fof/formatting to be disabled.

phloo

Currently having a problem with CodePen.
I installed the ext. Enabled all except Codepen modules. Cleared cache
Edited the post and its still embedding the codepen instead of showing a link to it.

clarkwinkelmann

phloo does it appear on new posts or not?

If you edited an older post, make sure to change at least one character for Flarum to re-parse the input.

phloo

clarkwinkelmann it's not a new post and its edited all the time.
But no change. There is always a codepen iframe.
And it's not even possible to use the link-function (breaks the codepen link)

clarkwinkelmann

phloo but if you create a new post with a codepen link, is it embedded or not? If you edit the post so there's no longer any codepen link at all, then edit to add it back in, does the iframe come back? If you edit a post that never had a codepen and add one, does the iframe appear? Trying to narrow down where the issue is.

EDIT: now I see you posted more messages in the FoF Formatting discussion. If you have MediaEmbed enabled in FoF Formatting it will override my extension and always enable all embeds.

phloo

Ah, that was what I misunderstood. I thought your extension overwrites FoF Formatting not the other way.
I now disabled mediaEmbed in FoF and it seems to work.

You can use this extension at the same time as FoF Formatting, but you should not enable MediaEmbed in FoF Formatting when doing so.

I missed this part obviously. Mea culpa 🙂

clarkwinkelmann

Version 1.0.1

Fix error if previously supported site is removed in a TextFormatter update.
Remove leftover console.log in admin panel.

Oshvam

clarkwinkelmann Hi Clark, would it be possible to add an X embed to Media Embed? The current problem that many forums are facing is that users are already starting to share links from x.com instead of twitter.com, so the embed is not generated. Over time this is only going to get worse. I've tried to do it myself, but my knowledge doesn't go that far, I thought it would be easy by replacing the domains and using Twitter's embed.js, but apparently not, as the extension still uses the s9 script.

CyberGene

clarkwinkelmann thank you for this fix 👍🏻

clarkwinkelmann

Oshvam see https://discuss.flarum.org/d/17770-friendsofflarum-formatting/427

My extension does not cover this, the plugins are in TextFormatter source code.

Support for X is already included, but only in the latest releases which require PHP 8.0.

Make sure your server is running PHP 8.0+ and run composer update s9e/text-formatter

Oshvam

clarkwinkelmann Perfect, now I do. But for some reason this isn't working for me:

<xsl:if test="$MEDIAEMBED_THEME=\'dark\'">#theme=dark</xsl:if>

I understand that it conditions the tweet to dark/white mode depending on the active theme. But it only inserts them with a white background, is there anything I should be aware of? I have FOF Formated and Selective Media Embed. With neither of the two extensions does it change the colour of the tweet.

clarkwinkelmann

Oshvam I don't believe the $MEDIAEMBED_THEME feature of TextFormatter is used by Flarum or any extension.

I remember playing with it in the past but didn't manage to get anything working.

It can be changed using a local extender if you are ever going to be using dark mode, but to use it together with Nightmode would require compiling 2 different TextFormatter instances which Flarum doesn't natively support and would be complicated to maintain.

JoshyPHP

clarkwinkelmann That's a template parameter, you can change it on the renderer itself with something like this:

$renderer->setParameter('MEDIAEMBED_THEME', 'dark');

You only have to set it once, but nothing bad happens if you overwrite it before every call to the renderer. You can also configure the renderer used for live preview the same way:

s9e.TextFormatter.setParameter('MEDIAEMBED_THEME', 'dark');

Make sure the API is exported:

diff --git a/framework/core/src/Formatter/Formatter.php b/framework/core/src/Formatter/Formatter.php
index 2dbc97c..a219696 100644
--- a/framework/core/src/Formatter/Formatter.php
+++ b/framework/core/src/Formatter/Formatter.php
@@ -121,7 +121,7 @@ class Formatter
         $configurator->rendering->getEngine()->cacheDir = $this->cacheDir; // @phpstan-ignore-line
 
         $configurator->enableJavaScript();
-        $configurator->javascript->exports = ['preview'];
+        $configurator->javascript->exports = ['preview', 'setParameter'];