get web notifications for posts and discussions when they are approved

meihuak

When the forum is set up so that everyone's discussions and posts need to be approved (except Admin and Mods), they cannot properly receive Web notifications.

I hope that in this case, they will also receive Web notifications normally.

please check this discuss:
https://discuss.flarum.org/d/31352-when-someone-reply-my-post-why-i-can-not-get-the-notification

meihuak

It seems that my suggestion was not supported by the official development team 🙁

meihuak

I want to pay for this extension, who can develop it 🙂

luceos

I think the issue is with the 1st party extension approval. For these notifications their visibility is reduced and thus they're not send out. I don't know an immediate fix, but this definitely needs to be looked into and resolved.

If you want to commission this work, I can open a bounty on this, but the requirements would be rather vague as we don't know the exact cause yet. What do the others think?

@SychO @davwheat @askvortsov etc?

PS my apologies @meihuak for ignoring this, I knew this was an issue and should have responded sooner.

meihuak

luceos thanks for your response man.
I have found 2 PHP engineers to develop this extension in my country before, but they said it is hard to do that.
Today I get your response like that, so I think I will wait for the official team to complete this.

SychO

luceos I think this lacks an exact description of what the problem/feature is. I can only assume that OP is referring to the fact that non-admins and non-mods don't receive notifications of new posts being created when after those posts get approved. But it could be something different as well.

If my assumption is correct, then one would probably need to:

Listen to the PostWasApproved event.
Fire a new reply notification.
Add tests of the wanted/expected behavior (would be easier to do tests first).

These changes would go into the subscriptions extension.

luceos

The problem is when posts are held for approval they don't trigger a notification once approved.

Also with realtime they are marked read for some reasons for mods. But that's outside of this issue.

luceos

I've talked this over with the team today and we're going to tackle this.

What needs to be done is that the Flarum Subscriptions extension needs to also listen to the PostApproved event so that it dispatches the notification to users. It is a straightforward fix, but the foundation will compensate the respective core developer for the time regardless. Issues like these are annoying and reporting them helps us understand their priority.

The ability for the foundation to invest in these matters highly depends on the amount of donations we get. Pledging (which I enabled on this issue now) and becoming a supporter/sponsor are fundamental sources for this.

meihuak

I sponsored $70 by Stripe, the project only got $52.5, 😂

luceos

meihuak I sponsored $70 by Stripe, the project only got $52.5, 😂

Our newly added Payments guidelines states:

25 % of all payments related to bounties are reserved by Flarum to allocate people to the management, confirmation and reviews of tasks from bounties.

This applies to all pledges, even those meant for ourselves.

meihuak

luceos got it

SychO

Submitted: flarum/framework3656

meihuak

SychO May I ask that when I can use this function, thanks

luceos

meihuak as this is a pull request/change on Flarum itself it needs to be reviewed by at least 2 other core developers. Once that is completed it will be released in the next update.

meihuak

luceos in next version like v1.5.1, right?

luceos

Part of the next release. This discussion is closed, for support or questions related to it, create a new discussion.