GreXXL The main issue I do see is that currently posts get flagged (not users). So adding an option that acts on the user account is in my opinion a mismatch because it's post-specific actions only. The ideal behaviour would be an integration with blomstra/spam-prevention that flags a user account
I basically agree with that, however from my experience I always have two scenarios happening with the spam-prevention:
- A spammer just registered and created a discussion with some spam links (I don't know why I am invaded by some "keto-gummies" spammers...) and the discussion gets flagged.
- A genuine user just registered and posted a link to some external website and that post gets flagged.
In both cases I open the flagged post/discussion and it's immediately clear when it's spam or not. So I ether approve the discussion/post (when genuine user), or I have to open the profile of the spammer from the flagged post and click on the "Spammer" button. It's only one additional click, so not a big drama. But it would nevertheless be easier to have a button that can be named "Mark post's author as spammer", so that there's no confusion with the fact we're reviewing a flagged post/discussion and not a user.
P.S. Ohh, and BTW @IanM , maybe it's a good idea to navigate to (and refresh?) the main discussion list after a hard-deletion of user/post/discussion since currently we are invoking the "mark as spammer" command from within the user's profile which will eventually be deleted. Also, I remember when I clicked on the top-left arrow button to go back to the discussion list I had the red error label about missing content for some reason (maybe the deleted discussion/post was still cached but the API couldn't load it, I'm not familiar with how Flarum works), so just in case it would be better to just hard-refresh everything to make sure the hard-deleted stuff is not on screen anymore.
