Show less posts on the homepage via extend.php, is that possible?

Darkle

Currently and by default 20 discussions are shown before clicking on the show more button, is it possible to change this number? maybe via extend.php as it is done to change the default filters (https://discuss.flarum.org/d/23363-how-do-i-change-the-default-sort-to-the-newest-discussion/10)?

clarkwinkelmann

Unfortunately I don't think it can currently be changed without overriding the Index content class.

If I remember correctly, the number is in 3 places: the API controller (can be changed via extender), the javascript state class (can be monkey-patched) and the content class (cannot be changed without overriding the class).

So no, it cannot be done just by editing extend.php (unless inline-ing a ton of javascript and PHP code)

I do hope we can consolidate that into a single constant in the future to make changing it easier.

Something else that's currently not supported is having the initial page have a different length from subsequent pages. I don't think the logic supports it at all.

luceos

The AbstractListController actually has a $maxLimit to cap the number of items requested. But I see no easy way to globally change it nor a way to do it per controller 🤔

Wait, you can use the static beforeDataCallbacks, maybe this works:

<?php

/*
 * This file is part of Flarum.
 *
 * For detailed copyright and license information, please view the
 * LICENSE file that was distributed with this source code.
 */

use Flarum\Api\Controller\ListDiscussionsController;
use Flarum\Extend;

return [
    (new Extend\ApiController(ListDiscussionsController::class))->setMaxLimit(10)
];

Untested!

Possible thanks to @SychO two years ago: flarum/framework2451

Darkle

luceos Nice try and without testing 😝, it works partially, if I enter the forum directly via URL, it works fine, but when the main page is reloaded via internal link or also when entering a tag or similar, it recovers the original value, I guess if I have understood Clark correctly as it's hard coded it will be trying to recover the value at every opportunity(?)

luceos

Darkle the max value should override the limit set on any request on that controller. I've never used this override before so it might misbehave. Because officially this max limit should override any limit/size the frontend requests from the backend.

clarkwinkelmann

luceos I believe (EDIT: link seems to confirm it) frontend will still multiply its hard-coded value by the page number to get the offset to request, so restricting the max results to 10 server-side will likely lead to half the content missing from the output.