Spoiler Alert

wignu

@sijad, thanks for that, would you be able to do that but with spoiler BBCode?

sijad

wignu you mean title?

wignu

sijad wignu you mean title?

Yes with the title, the ability to hide whatever's spoilt completely and just have a default spoiled label if no title is set ?. Be great if it was possible thanks.

sijad

wignu I'll put title in todo but I'm not sure about hiding as long as details do the same

JoshyPHP

@sijad The spoiler markup currently uses a span element. It prevents it from hosting a block element like a quote or code block, or an embedded video with a responsive div wrapper. Have you thought about using a div element, perhaps with display: inline-block?

This is related to that post.

sijad

JoshyPHP thanks for informing me.
do you think it's ok?
sijad/flarum-ext-spoiler-alertd238f43

I'm not sure about display: inline-block, because other elements (like <p> tags) are display: block;, and it prevents displaying spoiler inline with other elements any way, what do you think?

JoshyPHP

You're right about p and div. If you change it to a div I think it'll break the current paragraph. The best solution might be to have different BBCodes for inline spoilers and block spoilers.

jordanjay29

JoshyPHP Maybe add in the original click-to-show implementation for block-style spoilers? Makes sense you'd want to hide large items like quotes and codes, but keep inline content "hidden" just behind a blur.

sijad

JoshyPHP The best solution might be to have different BBCodes for inline spoilers and block spoilers.

don't you think there might be a better solution? this may confuse users

JoshyPHP

If there is one, I can't see it at the moment. I think that having two distinct BBCodes for inline text and blocky things is better than having only one that does both.

wignu

For simplicity for users it would be preferable to have one spoiler code to rule them all ?

DAMNimST0NED

wignu This exactly.

wignu For simplicity for users it would be preferable to have one spoiler code to rule them all

sijad

wignu I just followed discourse naming, can you please explain how users can handle both spoiler and detail with only one extension?

f0r3v3r

It is just weird because Details does what the original BBCode spoiler does, and this hijacks spoiler and makes it do something entirely different. I feel like details should still be spoiler (I know this ship has sailed) and this extension should be named and called with something else.

Just my two-cents, albeit too late...

DAMNimST0NED

f0r3v3r I understand what your getting at. This seems more like a pay to unlock or like to unlock thing then a true spoiler tag. But luckily we still have the other option.

HalilEsen

sijad mobile web not work

hanleylau22

Kulga Ok, that's pretty cool

i like that

sijad

sorry @hanleylau22 can you please let me know more details? device, os, browser?

wignu

@sijad I can confirm that this works fine with Android 6.0.1 with Firefox on a Samsung S7.

Have you give any thought to my requests posted above?

wignu

sijad I was referring more to my request to have an administrator option as to whether the content is blurred or made invisible. Yes I know your details extension does this however the forum standard is to use spoiler for this and it just confuses things to use another term that means basically nothing.

Not sure what you mean by discourse naming?

One last question/request ... is it possible to change the arrow to a picture or text?

sijad

wignu Not sure what you mean by discourse naming?

discourse uses same naming for this two extension:
https://github.com/discourse/discourse/tree/master/plugins/discourse-details
https://github.com/discourse/discourse-spoiler-alert

wignu One last question/request ... is it possible to change the arrow to a picture or text?

you mean details extension arrow? you can do that by css, but as details tag is supported by
most modern browsers now I'm not sure have exactly it's possible.

« Previous Page Next Page »