How to downgrade from 1.6.2 to 1.4

CyberGene

Is a bounty needed for fixing this bug? It really drives me crazy lately and I’m sure it’s probably a CSS one-liner. I’m OK paying a small bounty amount for this being fixed soon because I see no activity in the issue and I’m afraid it might not get fixed for the next release.

CyberGene

I’d really appreciate it if you can manage to fix this for 1.7 since it’s one of the only 4 open issues for the 1.7 milestone and I don’t see any activity in it. I bet it’s a one liner CSS or something else that’s trivial, so please, please, please Flarum devs 🙏🏻 It’s a very annoying issue on the iPhone.

cilia

CyberGene When will the 1.7 be released?

CyberGene

cilia as far as I know it will be very soon, probably in a week or two.

SychO

I can confirm this will not be fixed in 1.7, but perhaps in 1.8.

Milestones on GitHub only reflect what we would like done for said release, it unfortunately does not mean all items get done for the release. For reasons of manpower and time.

CyberGene

SychO maybe in a hotfix? Or maybe a CSS override will fix it?

SychO

jslirola They will be moved to 1.8

SychO Milestones on GitHub only reflect what we would like done for said release, it unfortunately does not mean all items get done for the release. For reasons of manpower and time.

CyberGene

Apologies for the second post in a row but it's more in regards to the original question of the discussion.

Let's assume that some of the developers fixes the issue in flarum/framework3703 after 1.7 is already released. Does it go in a branch that is dedicated to 1.8? Or does it go to the master branch? How can I get this fix immediately after it's ready, not waiting for 1.8? Is that not recommended? How easy it would be for me to upgrade to 1.8 from that branch then?

As a side note, I understand iPhone issues are not a priority and I'm OK with that, it's not a preferred platform for developers to work on, not following the web standards, etc. 😕 How about if we create bounties for fixes related to iPhone issues? Will that make it more likely for issues like that to be prioritized and get more attention?

SychO

CyberGene Does it go in a branch that is dedicated to 1.8? Or does it go to the master branch?

The main branch.

CyberGene How can I get this fix immediately after it's ready, not waiting for 1.8?

If the fix turns out to be a simple CSS modification, you could copy that as custom CSS code in your admin panel.
If the fix requires JS modifications you would have to install flarum/core from main or at least from the commit in main. Which is definitely not recommended, as changes in main are work in progress and often times are tied to changes from extensions as well, so you might end up breaking your instance.

CyberGene As a side note, I understand iPhone issues are not a priority and I'm OK with that

I don't think anybody said iOS issues are not a priority, and we did a lot of work in past releases to fix issues specific to iOS :/

CyberGene

SychO thanks for the answer, I will wait for the official release.

SychO I don't think anybody said iOS issues are not a priority, and we did a lot of work in past releases to fix issues specific to iOS :/

That's great! Maybe I was mistaken but I was really under the impression that iOS is not a priority because there are always some problems and incompatibilities introduced in the iOS updates, hence it's not Flarum fault but Apple and so, to "fix" an issue is rather creating a workaround. Which is why I thought a bounty might be a good idea since it's not Flarum problem. But still, thank you for also working to ensure Flarum works on iOS too 👍🏻

CyberGene

I've found a CSS on StackOverflow that stops horizontal scrolling on iOS and I tested it and it seems to fix the issue:

html, body{
  overflow-x: hidden;
}

Let me know if this can potentially affect something important. However I still think the underlying issue of why when you open a discussion on an iPhone there's horizontal scrolling (and not when viewing the discussion list) should be found. And that's a regression which appeared after 1.5

BTW, the discussion title might need to be updated.

cilia

CyberGene Hi, thanks for this workaround, it works pretty good aside from that it's nullifying the extension: Sticky Sidenav, otherwise it's perfect!

Subarist

cilia When you are limited to mobile CSS, should Sticky Sidenav not be affected?

CyberGene

cilia indeed, I just discovered the sidebar is affected on desktop but by combining some stuff I found on the Internet about CSS, the following makes it only applicable to mobile phones and not to desktop:

/* Do not allow horizontal scrolling (an issue on the iPhone) */
@media @phone {
  html, body{
    overflow-x: hidden;
  }
}

« Previous Page