Show profile picture of the last person replied, rather than OP - Pledge £100

rob006

Wellwisher Any chance someone can test this extension with Byōbu please?

What is special with Byobu? AFAIK it uses standard avatar logic and I'm not sure why Byobu discussions should behave differently in terms of avatars , than regular discussions.

Wellwisher

rob006 What is special with Byobu?

I am just going by Luceos' input:

luceos as this avatar should be different for byobu discussions vs regular ones, best would probably creating a new API field for this avatar and seeding it based on the type of discussion

rob006

Wellwisher AFAIK he was referring to your request in first post:

These changes in "all discussions" page should be ignored for private messaging extensions

rob006

I just tested Byobu with https://discuss.flarum.org/d/32368-last-post-avatar, and it works fine. But it does not have any special rules for displaying avatars - it works in the same way as for regular discussions.

CyberGene

rob006 thanks for the extension!

Wellwisher

rob006 Having special rules is the correct way of building this extension and that's why I am willing to pay the premium. I am slowly aiming to build my forum like https://brickrr.com. Hence, I want to ensure the avatars are only changed in certain areas of the forum.

If I wanted a quick solution, I would have installed Last posted user Avatar in DiscussionList and created some janky CSS to make it all work. 😂

I look at long-term solutions for my production site. Whenever I install extensions, I am constantly thinking of:

Longevity (i.e will it work with future extensions & new themes) or will it break my forum
Is the extension an overkill (can this be solved using a more simple solution)
Do I have the time to maintain the extension if the author discontinues it?
Is the feature necessary to my community and if there's no solution, what's a reasonable price to have it made?

luceos

Wellwisher Having special rules is the correct way of building this extension and that's why I am willing to pay the premium.

Crowdfunding is about everyone's opinion, not just yours. You are also not paying the premium, the premium would be having this custom built, regardless of how it is published. Nevertheless the requirement is set for the payout to happen and the extension by @rob006 - although good of intent - does not meet them.

@rob006 if you'd incorporate the feature request, we can close this and pay open bounties, should you like to consider it.

rob006

luceos Right now I don't have plans to make an exception for Byobu and any other extension. This would increase complexity and add unnecessary coupling with unrelated extension. And I still do not understand reasoning behind this requirement - Byobu is using default component do display private discussions on list (and they can be mixed with regular discussions), having different behavior here is inconsistent and confusing. IMO it would make more sense to customize these discussions directly in Byobu extension.

But if someone knows clean way of detecting these private discussions (or create some generic API to detect non-standard discussions), I could merge it to my extension. I have no claims to the declared bounties, so the author of the solution will get all of them.

rob006

rob006 But if someone knows clean way of detecting these private discussions (or create some generic API to detect non-standard discussions), I could merge it to my extension. I have no claims to the declared bounties, so the author of the solution will get all of them.

This was implemented by @Nearata and available in latest release: https://discuss.flarum.org/d/32368-last-post-avatar/9

luceos

This sounds like all requirements have been completed? @Wellwisher can you confirm.

Wellwisher

luceos, I am not a pro-coder bro. 😂
Well done lads, brilliant work. This will be much appreciated by the flarum community.

I think @rob006 has implemented everything in their extension so maybe I'll just pay them directly and he can pay what he wants to @Nearata

@rob006 what's your paypal?
Let me know so I can settle my end of the bounty, thanks.

rob006

Wellwisher I declared that author of the patch can take the whole bounty, so it belongs to @Nearata. But if he decides to share bounty, please send my part to Flarum Foundation: https://flarum.org/donate/

Wellwisher I can see on Github @Nearata 's code checks if Byobu extension exists and if it does, ignores the Last avatar discussion layout. It doesn't use an API key to achieve this.

It checks if discussion is private using JS API provided by Byobu, which to me is the most reasonable solution. I'm not sure what kind of API key you're referring.

Wellwisher

@luceos I can see on Github @Nearata 's code checks if Byobu extension exists and if it does, ignores the Last avatar discussion layout. It doesn't use an API key to achieve this.

But I am happy with the work around. I am more than happy to settle the bounty.

Nearata

Wellwisher nearata@protonmail.com

10% of the bounty to me. it looks more than enough.

90% should go to rob, more precisely

rob006 if he decides to share bounty, please send my part to Flarum Foundation: https://flarum.org/donate/

I hope this decision demonstrates my respect for the community, the developers first and foremost, and my commitment to act ethically and fairly. I want to make it clear that my intention is to act in a way that is respectful and fair to all parties involved (including the community itself). Declining the entire bounty, accepting too much or less, could be perceived as disrespectful by some.

Wellwisher

@Nearata what's your paypal buddy and let me know if u want to share the bounty with @rob006 and how much.

Wellwisher

@rob006 what's your paypal, I'd personally like to buy ya some coffee. 😉

rob006

Wellwisher Thanks, but I don't have PayPal anymore and I don't accept donations. If you want to thank me for my work, supporting Flarum project is probably the best way to do this. 🙂

Sponsoring through GitHub may be the easiest way: https://github.com/sponsors/flarum?frequency=one-time - GitHub does not have any fees and AFAIK they still support PayPal.

Wellwisher

My end of the bounties have been settled, this had been paid out today 13/02/23:
10% to @Nearata
90% to Flarum project via "https://paypal.me/flarumforum"

May the force be with you all.

Wellwisher

@luceos feel free to close the bounties as per @rob006 wishes.

« Previous Page