FoF Polls : add poll in a post

Wlork

Following the advice of @hrvoje_hr, I create a discussion to a suggestion for the extension by @FriendsOfFlarum, FoF Polls, which has a very good basis :

Ability to create poll in a post

Description :

I use FoF Polls as a base.

I repeat, this extension is already very good. It lacks some features.

First of all, it would be nice if we have the ability to create a poll in any post, not only in the first message. I suggest adding the "Add Poll" button when replying to a discussion , as is the case when creating a thread :

Permissions would be exactly the same.

Thank you 🙂

Another proposal : https://discuss.flarum.org/d/32942-fof-poll-allow-multiple-votes

GreXXL

Wlork picking up from your other discussion you should describe ok detail what you want to achieve with this proposal. Only if there is a good traceable description a bounty could be enabled.

A good description is how it should look like, what it should do, what permissions are needed and may also include some mock-up.

Wlork

GreXXL It's done.

I hope it's good 🙂

clarkwinkelmann

I think it would be wise to split this into 2 separate Proposals, since I don't see any overlap between the 2. This will give a better visibility to which feature is most requested by users, and individual tasks will have a better chance of being picked up

Wlork

clarkwinkelmann Yes, I thought spliting into 2 proposals, but I'm "afraid" that the volunteers will create several extensions ? 🙂

luceos

Wlork it's irrelevant whether they do or don't create this as an extension or integrate this in the existing extension. We cannot open bounties unless the features are split between two proposals.

Wlork

luceos

OK. I split into two proposals :

https://discuss.flarum.org/d/32721-fof-polls-add-poll-in-a-post-and-allow-multiple-votes
Can you rename title please : FoF Polls : Have ability to create poll in any post ?
https://discuss.flarum.org/d/32942-fof-poll-allow-multiple-votes (multiple choices)

🙂

GreXXL

Bounty is now enabled for this proposal. Funds can be claimed by a developer implementing this change to the existing FoF Polls extension (for example via a Pull request).

Wlork

Thank you 🙂

Wlork

@GreXXL I've already given a bounty for this proposal and I'd like to increase it. It's possible ? 🙂

GreXXL

Wlork yes you can always add another pledge to the bounty and it will add up.

Wlork

GreXXL Thank 🙂

I've increased my contribution, in part, thanks to my (small) community.

It's probably not much, but if it helps, we're happy 🙂

Wlork

I see no one has volunteered to add this feature yet.

I just hope it's not something complicated to develop ? 🙂

datitisev

I'm going to attempt to tackle this.

Due to the amount of refactoring needed, I'm also going to either add full support for multiple polls per post or at least leave some initial infrastructure for it, to prevent the need of changing that again later on.

datitisev

I've made a PR - FriendsOfFlarum/polls73.

It's in draft state because the change in associating a poll with a post instead of a discussion means that existing polls need to be pointed at their discussion's first post. However, if this post cannot be found, the poll is deleted since (in theory) it wouldn't have been shown at all anyways already, before the update with this change.

Still, this is a destructive operation, and so I'd prefer a lot more testing be done to it. If anyone has forum data they can test this migration on (NOT IN PRODUCTION, and have backups of this data -- mainly polls and group_permission tables - before testing!) and compare the amount of polls before & after, and whether the ones deleted (if any) made sense to, that'd be greatly appreciated. More info over at the PR.

Alongside that, once that's all good, I'll also be implementing other changes that break any kind of backwards compatibility, since this change already does that. It's plan on combining the removal of deprecations and other breaking features in a v2.0.0.

Anyways, enough tech talk - have some screenshots