Deprecated: json_decode() after updating to 1.8.1

KarlWard

The issue

After updating from Flarum 1.6 to 1.8.1, I get the error below. PHP version 8.1, and also tried PHP 8.2, which returns the same error. Downgrading to PHP 8.0 solved the issue.

Flarum information

Deprecated: json_decode(): Passing null to parameter #1 ($json) of type string is deprecated in /srv/users/serverpilot/apps/forum-files-gallery/vendor/flarum/core/src/Extend/Settings.php on line 115

clarkwinkelmann

KarlWard you can safely disable deprecation warnings in your php.ini. Those are meant for developers only.

If you share the remaining of the error trace we should be able to see which extension is responsible for triggering the warning and they can address it in a future update.

KarlWard

clarkwinkelmann Thanks. This is full error I get when changing to PHP 8.1 or 8.2:

Deprecated: json_decode(): Passing null to parameter #1 ($json) of type string is deprecated in (path)/vendor/flarum/core/src/Extend/Settings.php on line 115

Fatal error: Uncaught Laminas\HttpHandlerRunner\Exception\EmitterException: Unable to emit response; headers already sent in (path)/vendor/laminas/laminas-httphandlerrunner/src/Exception/EmitterException.php:19 Stack trace: #0 (path)/vendor/laminas/laminas-httphandlerrunner/src/Emitter/SapiEmitterTrait.php(36): Laminas\HttpHandlerRunner\Exception\EmitterException::forHeadersSent() #1 (path)/vendor/laminas/laminas-httphandlerrunner/src/Emitter/SapiEmitter.php(27): Laminas\HttpHandlerRunner\Emitter\SapiEmitter->assertNoPreviousOutput() #2 (path)/vendor/laminas/laminas-httphandlerrunner/src/RequestHandlerRunner.php(98): Laminas\HttpHandlerRunner\Emitter\SapiEmitter->emit(Object(Laminas\Diactoros\Response\HtmlResponse)) #3 (path)/vendor/flarum/core/src/Http/Server.php(45): Laminas\HttpHandlerRunner\RequestHandlerRunner->run() #4 (path)/public/index.php(26): Flarum\Http\Server->listen() #5 {main} thrown in (path)/vendor/laminas/laminas-httphandlerrunner/src/Exception/EmitterException.php on line 19

Deprecated: json_decode(): Passing null to parameter #1 ($json) of type string is deprecated in (path)/vendor/flarum/core/src/Extend/Settings.php on line 115

Fatal error: Uncaught Laminas\HttpHandlerRunner\Exception\EmitterException: Unable to emit response; headers already sent in (path)/vendor/laminas/laminas-httphandlerrunner/src/Exception/EmitterException.php:19 Stack trace: #0 (path)/vendor/laminas/laminas-httphandlerrunner/src/Emitter/SapiEmitterTrait.php(36): Laminas\HttpHandlerRunner\Exception\EmitterException::forHeadersSent() #1 (path)/vendor/laminas/laminas-httphandlerrunner/src/Emitter/SapiEmitter.php(27): Laminas\HttpHandlerRunner\Emitter\SapiEmitter->assertNoPreviousOutput() #2 (path)/vendor/laminas/laminas-httphandlerrunner/src/RequestHandlerRunner.php(98): Laminas\HttpHandlerRunner\Emitter\SapiEmitter->emit(Object(Laminas\Diactoros\Response\HtmlResponse)) #3 (path)/vendor/flarum/core/src/Http/Server.php(45): Laminas\HttpHandlerRunner\RequestHandlerRunner->run() #4 (path)/public/index.php(26): Flarum\Http\Server->listen() #5 {main} thrown in (path)/vendor/laminas/laminas-httphandlerrunner/src/Exception/EmitterException.php on line 19

I guess this is because it has already output the deprecated header ...

clarkwinkelmann

KarlWard yes EmitterException happens because PHP wrote an error to the program output when Flarum doesn't expect anything to have been written yet. Usually this is when a warning or deprecation gets written to the output, which PHP recommends to disable in production. I don't know why so many hosting still have the warnings output enabled by default when it's not recommended by PHP to do so. It's only useful for developers.

Unfortunately the error log doesn't show which extension makes that deprecated call. The full trace seems to refer to the EmitterException while the Deprecated error only shows one message and no trace.

In any case if you disable PHP warning/deprecation output in php.ini it should solve it and even the extension that makes the deprecated call should work just fine.

KarlWard

Yep, thanks for your help. I did disable PHP errors, and the issue is resolved. I did post the errors here, in case it's related to Flarum core, but apparently not. I will go through extensions when I find the time.

clarkwinkelmann I don't know why so many hosting still have the warnings output enabled by default when it's not recommended by PHP to do so. It's only useful for developers.

I use DigitalOcean+Serverpilot, and wasn't actually aware that reporting was on by default. I don't mind turning it off, but then again, I don't mind intercepting warnings before for my awareness before disabling. Because I'm lazy to test everything local/dev first.

Much appreciated 🧡 Flarum