Close threads once a certain number of messages have been posted

Oshvam

Hello everyone, is there a way to close threads when they reach a certain number of posts? For performance reasons, exceeding 2000 messages makes threads slow and heavy, and I would like to know if there is a way to automate the closing of threads once that number of messages is reached.

I've looked into doing this with the Automoderator, but it doesn't have the capability to do this.

clarkwinkelmann

Oshvam I don't think a bespoke extension exists for this, but this would not be very complicated to achieve using a few lines of PHP and the Flarum extension API.

Though if your concern is performance, maybe the time/cost to develop this extension would be better spent identifying and optimizing the performance issue.

If you have many extensions, maybe some of them cause long threads to load more slowly than Flarum would natively.

Oshvam

@"clarkwinkelmann"#p218945I'm convinced that the problem is generated by some extensions, but I've already made an inventory of extensions and eliminated the unnecessary ones, so the ones that remain (there are quite a few) are essential for me.

My current community comes from Discourse, so they are already used to threads being closed every 2,000 posts. For time and resources I think the most comfortable solution for me and possibly for many active communities would be to be able to have this extensible that you mentioned Clark.

I don't know much about the Flarum API, so I'll start looking to see if I can solve the problem. Although any help or hint will be welcome 🙂

luceos

    (new Extend\Event)
        ->listen(\Flarum\Post\Event\Posted::class, function (\Flarum\Post\Event\Posted $event) {
            // Check if we reached 2000 comments to a discussion and it isnt locked yet.
            if ($event->post->discussion->comment_count > 2000
                && !$event->post->discussion->is_locked) {
                // Lock the discussion.
                $event->post->discussion->is_locked = true;
                // Save the discussion if any of its properties are modified.
                $event->post->discussion->isDirty() && $event->post->discussion->save();
            }
        }),

Add that in your root extend.php between [], see:

https://github.com/luceos/flarum-extender-examples/blob/bc15d334caddeea54d20e36fe6723c248ccb8b1f/extend.php#L119-L129

This is untested but should work.

Oshvam

luceos Doesn't work for my. This is my extend.php:

<?php

/*
 * This file is part of Flarum.
 *
 * For detailed copyright and license information, please view the
 * LICENSE file that was distributed with this source code.
 */

use Flarum\Extend;

return [

    (new Extend\Event)
        ->listen(\Flarum\Post\Event\Posted::class, function (\Flarum\Post\Event\Posted $event) {
            // Check if we reached 1575 comments to a discussion and it isnt locked yet.
            if ($event->post->discussion->comment_count > 1575
                && !$event->post->discussion->is_locked) {
                // Lock the discussion.
                $event->post->discussion->is_locked = true;
                // Save the discussion if any of its properties are modified.
                $event->post->discussion->isDirty() && $event->post->discussion->save();
            }
        }),


];

Oshvam

m4v3rick While a Redis queue may help mitigate the problem, it will not solve it. The main problem is that you have too many extensions. So ideally you should take stock of extensions and decide which ones are critical or not. I recently went through a similar problem.

Based on my experience, I can tell you some of the extensions that impact performance a lot. These extensions I removed from 3 installations because of high resource consumption. Think of two factors, loading and publishing, I will break them into two stages, and try to give you some advice if you can't do without them:

Performance issues when publishing:

therealsujitk-gifs v4.1.1: It is not adapted to the latest versions of Flarum and consumes high resources. Will have to optimise it.
fof-drafts | 1.2.8: Use the Flarum scheduler to glue the drafts, or Redis.

Performance issues when reading:

justoverclock-popular-tags: Both this extension and any other view-based extension are resource gluttons, you have to register each view in the database and write to it. If you can, apply some kind of cache or use a method to display popular tags that doesn't depend on views.
fof-sitemap 2.2.0: It consumes resources every time you submit a new comment, technically it has to load every new comment in the sitemap, so I advise you to use the cron method if you can't do without it.
fof-analytics: I haven't tried this one, but you'll want to replace it with Ianm's HTML Head, which is more effective and allows you to load multiple tgs in the head.
afrux-online-users-widget and afrux-top-posters-widget: Try to use some kind of cache, otherwise if your community is active you will have problems.

It would also be good to know if you are using the default Flarum theme or any other theme like Asirem, which gives a lot of problems.

I took a practical approach to limiting posts, so that after a certain number of posts, the discussion closes automatically. It's a solution that luceos helped me with, you can read more here, but basically you should add this code to your extend.php and change the 2000 to the maximum number of posts allowed, think that every time a discussion starts to generate performance problems, it's not only affecting one user, but the whole installation (it can exhaust the server resources), so the approach of limiting the number of posts and the PHP memory_limit can be a good and healthy solution.

 (new Extend\Event)
        ->listen(\Flarum\Post\Event\Posted::class, function (\Flarum\Post\Event\Posted $event) {
            // Check if we reached 2000 comments to a discussion and it isnt locked yet.
            if ($event->post->discussion->comment_count > 2000
                && !$event->post->discussion->is_locked) {
                // Lock the discussion.
                $event->post->discussion->is_locked = true;
                // Save the discussion if any of its properties are modified.
                $event->post->discussion->isDirty() && $event->post->discussion->save();
            }
        }),

luceos

Oshvam any errors or it doesn't do anything?

Litalino

Oshvam
ADD

use Carbon\Carbon;
use Flarum\Discussion\Discussion;
use Flarum\Extend;
use Flarum\Post\CommentPost;
use Flarum\Post\Event\Saving;
..
(new Extend\Console)
->command(App\Command\RenumberPostsCommand::class),
(new Extend\Console)
->command(App\Command\RecountPostsCommand::class),

View https://github.com/luceos/flarum-extender-examples/blob/bc15d334caddeea54d20e36fe6723c248ccb8b1f/extend.php#L119-L129

Oshvam

luceos It does nothing 🙁

Oshvam

luceos Finally, this seems to be working for me. It just doesn't play on the messages I set up, but has a delay of 20/30 extra messages before closing. I guess it's a cache thing that can affect the message count.

Litalino What does this piece of code actually contribute? The previous one works without it.

wbntff

Much needed is auto-lock after 'N' number of days.
If a topic is NEWS or LIVE activity, it has to be set an expiry date and auto-locked after specified date

luceos

Oshvam those commands aren't needed, they are examples to answers for other peoples questions 😉